diskimage-builder/diskimage_builder/elements/dpkg/cleanup.d/40-unblock-daemons

#!/bin/bash

if [ ${DIB_DEBUG_TRACE:-0} -gt 0 ]; then
    set -x
fi
set -eu
set -o pipefail

[ -n "$TARGET_ROOT" ]

sudo mv $TARGET_ROOT/sbin/start-stop-daemon.REAL $TARGET_ROOT/sbin/start-stop-daemon

if [ -f $TARGET_ROOT/sbin/initctl.REAL ]; then
    sudo mv $TARGET_ROOT/sbin/initctl.REAL $TARGET_ROOT/sbin/initctl
fi

sudo rm $TARGET_ROOT/usr/sbin/policy-rc.d
Move the dpkg specific stuff to a dpkg element rather than being hardcoded. This includes the install-packages implementation for dpkg, apt http proxy config, daemon blocking and unblocking. Change-Id: I8f159021d2b223d7003cec067de3aa605ad06974 2013-02-13 22:16:00 +00:00			`#!/bin/bash`

Standarise tracing for scripts There is a wide variety of tracing options through the various shell scripts. Some use "set -eux", others explicity set xtrace and others do nothing. There is a "-x" option to bin/disk-image-create but it doesn't flow down to the many scripts it calls. This adds a global integer variable set by disk-image-create DIB_DEBUG_TRACE. All scripts have a stanza added to detect this and turn on tracing. Any other tracing methods are rolled into this. So the standard header is --- if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then set -x fi set -eu set -o pipefail --- Multiple -x options can be specified to dib-create-image, which increases the value of DIB_DEBUG_TRACE. If script authors feel their script should only trace at higher levels, they should modify the "-gt" value. If they feel it should trace by default, they can modify the default value also. Changes to pachset 16 : scripts which currently trace themselves by default have retained this behaviour with DIB_DEBUG_TRACE defaulting to "1". This was done by running [1] on patch set 15. See the thread beginning at [2] dib-lint is also updated to look for the variable being matched. [1] https://gist.github.com/ianw/71bbda9e6acc74ccd0fd [2] http://lists.openstack.org/pipermail/openstack-dev/2014-November/051575.html Change-Id: I6c5a962260741dcf6f89da9a33b96372a719b7b0 2014-09-04 04:56:29 +00:00			`if [ ${DIB_DEBUG_TRACE:-0} -gt 0 ]; then`
			`set -x`
			`fi`
set -u and -o pipefail everywhere As with the previous similar changes, this is intended to catch problems as they happen instead of ignoring them and continuing on to potentially fail later. Setting this on all existing scripts will allow us to enforce use via Jenkins. Change-Id: Iad2d490c86dceab148ea9ab08f457c49a5d5352e 2014-04-03 02:24:15 +00:00			`set -eu`
			`set -o pipefail`
Move the dpkg specific stuff to a dpkg element rather than being hardcoded. This includes the install-packages implementation for dpkg, apt http proxy config, daemon blocking and unblocking. Change-Id: I8f159021d2b223d7003cec067de3aa605ad06974 2013-02-13 22:16:00 +00:00
			`[ -n "$TARGET_ROOT" ]`

			`sudo mv $TARGET_ROOT/sbin/start-stop-daemon.REAL $TARGET_ROOT/sbin/start-stop-daemon`
Uses policy-rc.d to prevent dpkg starting daemons Currently the dpkg element fakes start-stop-daemon, initctl and invoke-rc.d to stop dpkg from starting a bunch of daemons in the chroot. This is problematic when packages use service, start, stop or restart commands. This patch uses a policy-rc.d instead of faking invoke-rc.d to achieve the same thing. This approach now aligns exactly with debootstrap. Without this patch DIB runs on some debian distributions fail when trying to umount the chroot loop device as there are daemons running. The log will now show "invoke-rc.d: policy-rc.d denied execution of start." instead of "Warning: Fake invoke-rc.s called, doing nothing." Change-Id: I6db192127aca19b5b7915179b781f5192078bfc7 Related-Bug: #1211564 2014-03-26 13:24:51 +00:00
Correction: if then statement code style. Corrected the if; then statement to follow bash convention. Change-Id: Ia3f80520bb9446c4feb5ce36dccffa2b1c1d72c4 2014-07-01 09:27:41 +00:00			`if [ -f $TARGET_ROOT/sbin/initctl.REAL ]; then`
Don't block the upstart daemon if it doesn't exist Check if Upstart exists before blocking the daemon. Not all dpkg based OS's have Upstart installed so this should help increase compatibility. Closes-Bug: #1251949 Change-Id: I2dcb1ff3641778b5653ca5762a728398adb57da1 2013-11-17 03:42:17 +00:00			`sudo mv $TARGET_ROOT/sbin/initctl.REAL $TARGET_ROOT/sbin/initctl`
			`fi`
Uses policy-rc.d to prevent dpkg starting daemons Currently the dpkg element fakes start-stop-daemon, initctl and invoke-rc.d to stop dpkg from starting a bunch of daemons in the chroot. This is problematic when packages use service, start, stop or restart commands. This patch uses a policy-rc.d instead of faking invoke-rc.d to achieve the same thing. This approach now aligns exactly with debootstrap. Without this patch DIB runs on some debian distributions fail when trying to umount the chroot loop device as there are daemons running. The log will now show "invoke-rc.d: policy-rc.d denied execution of start." instead of "Warning: Fake invoke-rc.s called, doing nothing." Change-Id: I6db192127aca19b5b7915179b781f5192078bfc7 Related-Bug: #1211564 2014-03-26 13:24:51 +00:00
			`sudo rm $TARGET_ROOT/usr/sbin/policy-rc.d`