sig_cloud/diskimage-builder
11
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
diskimage-builder/diskimage_builder/elements/redhat-common/finalise.d/01-clean-old-kernels

27 lines
565 B
Text
Raw Normal View History

Add redhat-common element Add an element intended for use in both Fedora and RHEL. This allows them to share install steps that are common to both. Change-Id: Ie4e820a7b777b8701514351b1f802cfe57c3812e
2014-02-18 22:14:43 +00:00
#!/bin/bash
Standarise tracing for scripts There is a wide variety of tracing options through the various shell scripts. Some use "set -eux", others explicity set xtrace and others do nothing. There is a "-x" option to bin/disk-image-create but it doesn't flow down to the many scripts it calls. This adds a global integer variable set by disk-image-create DIB_DEBUG_TRACE. All scripts have a stanza added to detect this and turn on tracing. Any other tracing methods are rolled into this. So the standard header is --- if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then set -x fi set -eu set -o pipefail --- Multiple -x options can be specified to dib-create-image, which increases the value of DIB_DEBUG_TRACE. If script authors feel their script should only trace at higher levels, they should modify the "-gt" value. If they feel it should trace by default, they can modify the default value also. Changes to pachset 16 : scripts which currently trace themselves by default have retained this behaviour with DIB_DEBUG_TRACE defaulting to "1". This was done by running [1] on patch set 15. See the thread beginning at [2] dib-lint is also updated to look for the variable being matched. [1] https://gist.github.com/ianw/71bbda9e6acc74ccd0fd [2] http://lists.openstack.org/pipermail/openstack-dev/2014-November/051575.html Change-Id: I6c5a962260741dcf6f89da9a33b96372a719b7b0
2014-09-04 04:56:29 +00:00
if [ ${DIB_DEBUG_TRACE:-0} -gt 0 ]; then
set -x
fi
set -e all the things Using set -e in all of our scripts will prevent some subtle bugs from slipping in, and will allow us to enforce use of set -e with tooling. This change also adds -u and set -o pipefail in the less complex scripts where it is unlikely to cause problems. A follow-up change will enable those options in the complex scripts so that if it breaks something it can be reverted easily. Change-Id: I0ad358ccb98da7277a0ee2e9ce8fda98438675eb
2014-03-29 03:28:22 +00:00
set -eu
set -o pipefail
Allow to skip kernel cleanup For some use cases, it can be useful to keep all the kernels and not just keep the latest one. Add a parameter that allows it, and continue cleaning up kernels by default. Change-Id: Ia6e6c1fa18e3724c1eb89226151d81e9e748b793
2016-08-11 11:29:29 +00:00
if [ $DIB_DISABLE_KERNEL_CLEANUP -ne 0 ]; then
echo "Skipping kernel cleanup as configured"
exit 0
fi
Use dnf to cleanup old kernels As described in the comment, there is a dnf equivalent of this command that doesn't require us installing yum-utils (which drags in yum on dnf-only systems such as f23) This is a small consequence to this -- due to us not installing yum-utils some installs will now be completely yum free. This causes a breakage in ironic-agent 99-remove-extra-packages where we remove the yum package. There is a long-standing bug/feature where missing packages in a group of packages do not cause yum/dnf to exit with failure, but uninstalling a single package will. Because we have made the systems yum-free, the uninstall of yum can fail in this corner case. It has always been like this, so I'm in favour of the "ain't broke" approach. To work-around this, I have just put yum into the existing list of packages to be cleaned up. I have added a note to the yum installer taking note of this behaviour for future reference. Change-Id: I8bbdc07ccdb89a105b4fc70d5a215077c42fcd03
2015-11-25 03:31:50 +00:00
YUM=${YUM:-yum}
Add redhat-common element Add an element intended for use in both Fedora and RHEL. This allows them to share install steps that are common to both. Change-Id: Ie4e820a7b777b8701514351b1f802cfe57c3812e
2014-02-18 22:14:43 +00:00
Use dnf to cleanup old kernels As described in the comment, there is a dnf equivalent of this command that doesn't require us installing yum-utils (which drags in yum on dnf-only systems such as f23) This is a small consequence to this -- due to us not installing yum-utils some installs will now be completely yum free. This causes a breakage in ironic-agent 99-remove-extra-packages where we remove the yum package. There is a long-standing bug/feature where missing packages in a group of packages do not cause yum/dnf to exit with failure, but uninstalling a single package will. Because we have made the systems yum-free, the uninstall of yum can fail in this corner case. It has always been like this, so I'm in favour of the "ain't broke" approach. To work-around this, I have just put yum into the existing list of packages to be cleaned up. I have added a note to the yum installer taking note of this behaviour for future reference. Change-Id: I8bbdc07ccdb89a105b4fc70d5a215077c42fcd03
2015-11-25 03:31:50 +00:00
if [[ ${YUM} == "dnf" ]]; then
# cribbed from
# http://dnf.readthedocs.org/en/latest/cli_vs_yum.html
Fix latest-limit command line It turns out dnf argparse can't handle negative numbers without "=". It's actually documented in the man page --latest-limit <number> ... If <number> is negative skip <number> of latest packages. If a negative number is used use syntax --latest-limit=<number> But who reads that :) This started failing with Fedora 26 Change-Id: I884af94c07fa11b010f69863047a04711b14f21e
2017-07-18 03:15:09 +00:00
_old_kernels="$(dnf repoquery --installonly --latest-limit=-1 -q)"
Use dnf to cleanup old kernels As described in the comment, there is a dnf equivalent of this command that doesn't require us installing yum-utils (which drags in yum on dnf-only systems such as f23) This is a small consequence to this -- due to us not installing yum-utils some installs will now be completely yum free. This causes a breakage in ironic-agent 99-remove-extra-packages where we remove the yum package. There is a long-standing bug/feature where missing packages in a group of packages do not cause yum/dnf to exit with failure, but uninstalling a single package will. Because we have made the systems yum-free, the uninstall of yum can fail in this corner case. It has always been like this, so I'm in favour of the "ain't broke" approach. To work-around this, I have just put yum into the existing list of packages to be cleaned up. I have added a note to the yum installer taking note of this behaviour for future reference. Change-Id: I8bbdc07ccdb89a105b4fc70d5a215077c42fcd03
2015-11-25 03:31:50 +00:00
if [[ -n "${_old_kernels}" ]]; then
Use rpm -e instead of dnf for cleaning old kernels If the running kernel of the system building the image matches the kernel that is to be removed dnf will fail. Repalce use use of dnf with rpm -e. Closes-Bug: #1623409 Change-Id: Ie2481ea8a02b7b0720e46fa179f24badf4aa25c5
2020-03-19 21:27:51 +00:00
rpm -e ${_old_kernels}
Use dnf to cleanup old kernels As described in the comment, there is a dnf equivalent of this command that doesn't require us installing yum-utils (which drags in yum on dnf-only systems such as f23) This is a small consequence to this -- due to us not installing yum-utils some installs will now be completely yum free. This causes a breakage in ironic-agent 99-remove-extra-packages where we remove the yum package. There is a long-standing bug/feature where missing packages in a group of packages do not cause yum/dnf to exit with failure, but uninstalling a single package will. Because we have made the systems yum-free, the uninstall of yum can fail in this corner case. It has always been like this, so I'm in favour of the "ain't broke" approach. To work-around this, I have just put yum into the existing list of packages to be cleaned up. I have added a note to the yum installer taking note of this behaviour for future reference. Change-Id: I8bbdc07ccdb89a105b4fc70d5a215077c42fcd03
2015-11-25 03:31:50 +00:00
fi
else
install-packages yum-utils
package-cleanup --oldkernels -y --count=1
fi
Reference in a new issue Copy permalink