diskimage-builder/elements/rpm-distro/post-install.d/05-fstab-rootfs-label

#!/bin/bash

if [ ${DIB_DEBUG_TRACE:-0} -gt 0 ]; then
    set -x
fi
set -eu
set -o pipefail

# Fedora 18 sets up for root to have a label of "_/"
# Fedora 19 sets up for root to have a UUID
# This regex will catch both
sed -i "s%.*\s\/\s%LABEL=${DIB_ROOT_LABEL} / %" /etc/fstab
Change the rootfs label in fedora's /etc/fstab. The images produced by the diskimage-builder have their filesystem with a label of "cloudimg-rootfs", so we need to change the default /etc/fstab on fedora to reflect that. Change-Id: Id1bb00cb81cb200a114f500e26272624be577da0 2013-06-05 10:44:32 +00:00			`#!/bin/bash`

Standarise tracing for scripts There is a wide variety of tracing options through the various shell scripts. Some use "set -eux", others explicity set xtrace and others do nothing. There is a "-x" option to bin/disk-image-create but it doesn't flow down to the many scripts it calls. This adds a global integer variable set by disk-image-create DIB_DEBUG_TRACE. All scripts have a stanza added to detect this and turn on tracing. Any other tracing methods are rolled into this. So the standard header is --- if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then set -x fi set -eu set -o pipefail --- Multiple -x options can be specified to dib-create-image, which increases the value of DIB_DEBUG_TRACE. If script authors feel their script should only trace at higher levels, they should modify the "-gt" value. If they feel it should trace by default, they can modify the default value also. Changes to pachset 16 : scripts which currently trace themselves by default have retained this behaviour with DIB_DEBUG_TRACE defaulting to "1". This was done by running [1] on patch set 15. See the thread beginning at [2] dib-lint is also updated to look for the variable being matched. [1] https://gist.github.com/ianw/71bbda9e6acc74ccd0fd [2] http://lists.openstack.org/pipermail/openstack-dev/2014-November/051575.html Change-Id: I6c5a962260741dcf6f89da9a33b96372a719b7b0 2014-09-04 04:56:29 +00:00			`if [ ${DIB_DEBUG_TRACE:-0} -gt 0 ]; then`
			`set -x`
			`fi`
set -e all the things Using set -e in all of our scripts will prevent some subtle bugs from slipping in, and will allow us to enforce use of set -e with tooling. This change also adds -u and set -o pipefail in the less complex scripts where it is unlikely to cause problems. A follow-up change will enable those options in the complex scripts so that if it breaks something it can be reverted easily. Change-Id: I0ad358ccb98da7277a0ee2e9ce8fda98438675eb 2014-03-29 03:28:22 +00:00			`set -eu`
			`set -o pipefail`

Change the rootfs label in F18 and F19 The images produced by the diskimage-builder have their filesystem with a label of "cloudimg-rootfs", The regex changing fstab on fedora didn't match the F19 case. This regex matches both F18 : LABEL=_/ / ext4 defaults 1 1 F19 : UUID=f2da0fc8-2e12-4a6e-8e95-a31a474aa1a8 / ext4 defaults,noatime 0 0 Change-Id: Iafcf5e069199f1df76874309b2d5064f343fb5e5 2013-08-07 08:39:23 +00:00			`# Fedora 18 sets up for root to have a label of "_/"`
			`# Fedora 19 sets up for root to have a UUID`
			`# This regex will catch both`
Allow custom rootfs labels Per [1], our current root label of cloudimg-root does not work with XFS because XFS only allows 12 character labels. This change addresses that by allowing a custom rootfs label to be specified in the call to disk-image-create. There should be no backwards compatibility concerns as the default label is unchanged. Any external elements dealing with the label would need to be updated to support this new feature, but should continue to work as before as long as a custom label is not specified. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1139584 Change-Id: I596104d1a63b5dc6549e8460a1ae3da00165ef04 2014-09-16 18:11:07 +00:00			`sed -i "s%.*\s\/\s%LABEL=${DIB_ROOT_LABEL} / %" /etc/fstab`