diskimage-builder/elements/rpm-distro/pre-install.d/00-usr-local-bin-secure-path

#!/bin/bash

if [ ${DIB_DEBUG_TRACE:-0} -gt 0 ]; then
    set -x
fi
set -eu
set -o pipefail

sed -i -e "/secure_path/ s@\([\'\"]\?\)\$@:/usr/local/bin/\1@" /etc/sudoers
visudo -c
Extracting common functionality for rpm based distros Rather than dublicating code to implement rhel or any other derivitive, this patch introduces an rpm-distro element that should be used as a dependency. Change-Id: I8a92bb041764d03f430b438f0013704f79a8674c 2013-08-20 20:02:57 +00:00			`#!/bin/bash`

Standarise tracing for scripts There is a wide variety of tracing options through the various shell scripts. Some use "set -eux", others explicity set xtrace and others do nothing. There is a "-x" option to bin/disk-image-create but it doesn't flow down to the many scripts it calls. This adds a global integer variable set by disk-image-create DIB_DEBUG_TRACE. All scripts have a stanza added to detect this and turn on tracing. Any other tracing methods are rolled into this. So the standard header is --- if [ "${DIB_DEBUG_TRACE:-0}" -gt 0 ]; then set -x fi set -eu set -o pipefail --- Multiple -x options can be specified to dib-create-image, which increases the value of DIB_DEBUG_TRACE. If script authors feel their script should only trace at higher levels, they should modify the "-gt" value. If they feel it should trace by default, they can modify the default value also. Changes to pachset 16 : scripts which currently trace themselves by default have retained this behaviour with DIB_DEBUG_TRACE defaulting to "1". This was done by running [1] on patch set 15. See the thread beginning at [2] dib-lint is also updated to look for the variable being matched. [1] https://gist.github.com/ianw/71bbda9e6acc74ccd0fd [2] http://lists.openstack.org/pipermail/openstack-dev/2014-November/051575.html Change-Id: I6c5a962260741dcf6f89da9a33b96372a719b7b0 2014-09-04 04:56:29 +00:00			`if [ ${DIB_DEBUG_TRACE:-0} -gt 0 ]; then`
			`set -x`
			`fi`
set -e all the things Using set -e in all of our scripts will prevent some subtle bugs from slipping in, and will allow us to enforce use of set -e with tooling. This change also adds -u and set -o pipefail in the less complex scripts where it is unlikely to cause problems. A follow-up change will enable those options in the complex scripts so that if it breaks something it can be reverted easily. Change-Id: I0ad358ccb98da7277a0ee2e9ce8fda98438675eb 2014-03-29 03:28:22 +00:00			`set -eu`
			`set -o pipefail`

secure_path in sudoers: deal with possible quotes Sometimes the secure_path option value in /etc/sudoers is surrounded by quotes, in this case the current command creates an invalid entry and it's not possible to sudo anymore. This fix adjust the sed command to deal with possible quotes Change-Id: Ifd6f9e29b3c0d04d6f65d3f55524ad202fb3294e 2016-08-03 13:03:14 +00:00			`sed -i -e "/secure_path/ s@\([\'\"]\?\)\$@:/usr/local/bin/\1@" /etc/sudoers`
Check sudoers file after editing "visudo -c" should be run after the sudoers file has been edited. This will ensure that the file is still syntactically correct, and exit 1 if it isn't. Otherwise, obscure errors can occur later on, and it is difficult to track them back to this script as the source of the error. Change-Id: Id0e5114d72c0779952a0c2c2c06696929c6c8b17 2016-07-07 12:21:43 +00:00			`visudo -c`