sig_cloud/diskimage-builder
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Set LC_ALL in disk-image-create

Browse Source 
It seems that the redhat nodepool job is quite reliably geting a
"floating point" error during centos image build.  This happens after
03-yum-cleanup which is pruning the locales.  This might be a
red-herring, since the logs are full of

  /bin/bash: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)

I think in our recent de-puppetisation of hosts, something might have
changed that is setting LC_ALL=C.UTF-8 for the jenkins user, at least
on Ubuntu.  This is a problem for centos, as it doesn't have C.UTF-8
locale.  I then think using the invalid locale is what leads the the
floating-point error when doing some maths in dib-run-parts to
calculate runtimes.

We are currently overriding LANG, but we really want LC_ALL to ensure
this applies globally.

Change-Id: I8e7cae093c4b32e0d20b73ae0086f14c7cc6a9cb
This commit is contained in:
Ian Wienand 2017-05-03 11:31:11 +10:00
parent 340451ea00
commit 91ba21dd6c
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
diskimage_builder/lib/disk-image-create
View File

@ -16,9 +16,13 @@
set -eE set -eE
# Prevent perl from complaining a lot, but also remove any unexpected side-effects # Set/override locale. This ensures consistency in sorting etc. We
# of $LANG varying between build hosts # need to choose a lowest-common denominator locale, as this is
export LANG=C # applied when running in the building chroot too (maybe a bug and we
# should prune this?). Thus "C" --centOS 7 doesn't include C.utf-8
# (fedora does, centos 8 probably will). Note: LC_ALL to really
# override this; it overrides LANG and all other LC_ vars
export LC_ALL=C
# Store our initial environment and command line args for later # Store our initial environment and command line args for later
export DIB_ARGS="$@" export DIB_ARGS="$@"