sig_cloud/diskimage-builder
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Enhance dib-run-parts usage message

Browse Source 
and fix $1: unbound variable issue when run dib-run-parts --list.

Change-Id: Id18e21683f785f318bce11d401cb4f826bed1b01
This commit is contained in:
JUN JIE NAN 2013-11-27 17:38:19 +08:00
parent 476ec8feec
commit afc07e2b2d
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
elements/dib-run-parts/bin/dib-run-parts
View File

@ -24,10 +24,15 @@ set -ue
name=$(basename $0)
usage() {
echo "usage: $name [OPTION] scripts_directory" >&2
echo " --list print names of all valid files" >&2
echo "Usage: $name [OPTION] scripts_directory"
echo "Option:"
echo " --list print names of all valid files"
echo
echo "Examples:"
echo " dib-run-parts --list /opt/stack/os-config-refresh/configure.d/"
echo " dib-run-parts /opt/stack/os-config-refresh/configure.d/"
exit 1
}
} >&2
output () {
echo $name $(date) $* >&2
@ -42,10 +47,10 @@ if [ "$1" == "--list" ] ; then
shift
fi
target_dir=$1
target_dir="${1:-}"
if ! [ -d $target_dir ] ; then
output $target_dir must exist and be a directory
if ! [ -d "$target_dir" ] ; then
output "Scripts directory [$target_dir] must exist and be a directory"
usage
fi