Merge "[ironic-agent] Use svc-map for enabling agent"

elements/ironic-agent/README.rst

@@ -16,5 +16,10 @@ Beyond installing the ironic-python-agent, this element does the following:
   in order to support source based installation of ironic-python-agent and its
   dependencies.
 
+.. note::
+   The package based install currently only enables the service when using the
+   systemd init system. This can easily be changed if there is an agent
+   package which includes upstart or sysv packaging.
+
 .. note::
    Using the ramdisk will require at least 1.5GB of ram

elements/ironic-agent/element-deps

@@ -1,2 +1,5 @@
 dhcp-all-interfaces
+package-installs
+pkg-map
 source-repositories
+svc-map

elements/ironic-agent/install.d/ironic-agent-source-install/60-ironic-agent-install

@@ -28,8 +28,7 @@ case "$DIB_INIT_SYSTEM" in
         install -D -g root -o root -m 0755 ${SCRIPTDIR}/ironic-python-agent.conf /etc/init/ironic-python-agent.conf
         ;;
     systemd)
-        install -D -g root -o root -m 0755 ${SCRIPTDIR}/ironic-python-agent.service /usr/lib/systemd/system/ironic-python-agent.service
-        systemctl enable ironic-python-agent.service
+        install -D -g root -o root -m 0755 ${SCRIPTDIR}/ironic-python-agent.service /usr/lib/systemd/system/$(svc-map ironic-python-agent).service
         ;;
     sysv)
         install -D -g root -o root -m 0755 ${SCRIPTDIR}/ironic-python-agent.init /etc/init.d/ironic-python-agent.init

elements/ironic-agent/install.d/ironic-agent-source-install/ironic-python-agent.conf

@@ -14,7 +14,7 @@ umask 022
 expect stop
 
 pre-start script
-    echo Starting Ironic Python Agnet
+    echo Starting Ironic Python Agent
 end script
 
 exec /usr/bin/ironic-python-agent

elements/ironic-agent/post-install.d/80-ironic-agent

@@ -23,11 +23,10 @@ case "$DIB_INIT_SYSTEM" in
         ;;
     systemd)
         systemctl disable iptables.service
-        systemctl enable openstack-ironic-python-agent.service
+        systemctl enable $(svc-map ironic-python-agent).service
         ;;
     sysv)
         update-rc.d iptables disable
-        update-rc.d openstack-ironic-python-agent enable
         ;;
     *)
         echo "Unsupported init system"

elements/ironic-agent/svc-map

@@ -0,0 +1,4 @@
+ironic-python-agent:
+  default: openstack-ironic-python-agent
+  redhat: openstack-ironic-python-agent
+  debian: ironic-python-agent