sig_cloud/diskimage-builder
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge "Check source-repository-* files for trailing newline"

Browse Source
This commit is contained in:
Zuul 2017-12-18 02:16:35 +00:00 committed by Gerrit Code Review
commit be8d9b6520
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
bin/dib-lint
View File

@ -86,6 +86,15 @@ for i in $(find $ELEMENTS_DIR -type f \
exclusions=("$(parse_exclusions $i)") exclusions=("$(parse_exclusions $i)")
# source-repository does a read < $file and can miss the last line
# (or only line, if there's only one) when not newline terminated.
if [[ $(basename "${i}") =~ "source-repository-" ]]; then
nl=$(tail -c 1 ${i})
if [[ "${nl}" != "" ]]; then
error "$i does not end with a newline"
fi
fi
# Check that files starting with a shebang are +x # Check that files starting with a shebang are +x
firstline=$(head -n 1 "$i") firstline=$(head -n 1 "$i")
if [ "${firstline:0:2}" = "#!" ]; then if [ "${firstline:0:2}" = "#!" ]; then