elements: Drop executable bits from environment files
Files in $element/environment.d are meant to be sourced, so drop the executable bit. Moreover, drop the executable bit from a couple of other scripts that are either meant to be sourced or simply because they are configuration files. Change-Id: I7f724dd9d409f4a835a136f12f48a84aa9acc41e
This commit is contained in:
parent
ef1effd202
commit
e22faa0f77
@ -156,11 +156,15 @@ for i in $(find elements -type f \
|
|||||||
fi
|
fi
|
||||||
fi
|
fi
|
||||||
|
|
||||||
# check that environment files don't "set -x"
|
# check that environment files don't "set -x" and they have no executable
|
||||||
|
# bits set
|
||||||
if [[ "$i" =~ (environment.d) ]]; then
|
if [[ "$i" =~ (environment.d) ]]; then
|
||||||
if grep -q "set -x" $i; then
|
if grep -q "set -x" $i; then
|
||||||
error "Environment file $i should not set tracing"
|
error "Environment file $i should not set tracing"
|
||||||
fi
|
fi
|
||||||
|
if [[ -x $i ]]; then
|
||||||
|
error "Environment file $i should not be marked as executable"
|
||||||
|
fi
|
||||||
fi
|
fi
|
||||||
|
|
||||||
# check that sudo calls in phases run outside the chroot look
|
# check that sudo calls in phases run outside the chroot look
|
||||||
|
0
elements/centos/environment.d/00-bootloader.bash
Executable file → Normal file
0
elements/centos/environment.d/00-bootloader.bash
Executable file → Normal file
0
elements/debian-minimal/test-elements/stable-build-succeeds/environment.d/10-set-distro.bash
Executable file → Normal file
0
elements/debian-minimal/test-elements/stable-build-succeeds/environment.d/10-set-distro.bash
Executable file → Normal file
0
elements/debian-minimal/test-elements/testing-build-succeeds/environment.d/10-set-distro.bash
Executable file → Normal file
0
elements/debian-minimal/test-elements/testing-build-succeeds/environment.d/10-set-distro.bash
Executable file → Normal file
0
elements/debian/test-elements/build-succeeds/environment.d/09-debian-stable
Executable file → Normal file
0
elements/debian/test-elements/build-succeeds/environment.d/09-debian-stable
Executable file → Normal file
0
elements/devuser/environment.d/50-devuser
Executable file → Normal file
0
elements/devuser/environment.d/50-devuser
Executable file → Normal file
0
elements/dynamic-login/init-scripts/upstart/dynamic-login.conf
Executable file → Normal file
0
elements/dynamic-login/init-scripts/upstart/dynamic-login.conf
Executable file → Normal file
0
elements/gentoo/environment.d/00-gentoo-envars.bash
Executable file → Normal file
0
elements/gentoo/environment.d/00-gentoo-envars.bash
Executable file → Normal file
0
elements/manifests/environment.d/14-manifests
Executable file → Normal file
0
elements/manifests/environment.d/14-manifests
Executable file → Normal file
0
elements/pip-cache/environment.d/10-pip-cache
Executable file → Normal file
0
elements/pip-cache/environment.d/10-pip-cache
Executable file → Normal file
0
elements/ramdisk-base/extra-data.d/scripts/d/init-func
Executable file → Normal file
0
elements/ramdisk-base/extra-data.d/scripts/d/init-func
Executable file → Normal file
0
elements/redhat-common/environment.d/50-redhat-common
Executable file → Normal file
0
elements/redhat-common/environment.d/50-redhat-common
Executable file → Normal file
Loading…
Reference in New Issue
Block a user