f314df12c3
As described in pep282 [1], the variable part of a log message should be passed in via parameter. In this case the parameters are evaluated only when they need to be. This patch fixes (unifies) this for DIB. A check using pylint was added that this kind of passing parameters to the logging subsystem is enforced in future. As a blueprint a similar (stripped-down) approach from cinder [2] was used. [1] https://www.python.org/dev/peps/pep-0282/ [2] https://github.com/openstack/cinder/blob/master/tox.ini Change-Id: I2d7bcc863e4e9583d82d204438b3c781ac99824e Signed-off-by: Andreas Florath <andreas@florath.net>
46 lines
1.2 KiB
INI
46 lines
1.2 KiB
INI
[tox]
|
|
envlist = py35,py27,pep8,pylint
|
|
minversion = 1.6
|
|
skipsdist = True
|
|
|
|
[testenv]
|
|
usedevelop = True
|
|
install_command = pip install -U {opts} {packages}
|
|
deps= -r{toxinidir}/requirements.txt
|
|
-r{toxinidir}/test-requirements.txt
|
|
commands=
|
|
python setup.py test --slowest --testr-args='{posargs}'
|
|
|
|
[testenv:pep8]
|
|
commands =
|
|
flake8 {posargs}
|
|
dib-lint
|
|
|
|
[testenv:pylint]
|
|
setenv = VIRTUAL_ENV={envdir}
|
|
deps = pylint
|
|
commands = pylint --rcfile pylint.cfg diskimage_builder
|
|
|
|
[testenv:venv]
|
|
commands = {posargs}
|
|
|
|
[testenv:func]
|
|
envdir = {toxworkdir}/venv
|
|
commands = {toxinidir}/tests/run_functests.sh {posargs}
|
|
|
|
[testenv:cover]
|
|
# NOTE: this is "setup.py test" (*not* testr) which is a pbr wrapper
|
|
# around testr. This understands --coverage-package-name which we
|
|
# need due to underscore issues.
|
|
commands = python setup.py test --coverage --coverage-package-name diskimage_builder --testr-args='{posargs}'
|
|
|
|
[testenv:docs]
|
|
commands = python setup.py build_sphinx
|
|
|
|
[testenv:releasenotes]
|
|
commands = sphinx-build -a -W -E -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html
|
|
|
|
[flake8]
|
|
ignore = E125,E126,E127,H202,H803
|
|
exclude = .venv,.git,.tox,dist,doc/build,doc/source,*lib/python*,*egg,build,conf.py
|