f314df12c3
As described in pep282 [1], the variable part of a log message should be passed in via parameter. In this case the parameters are evaluated only when they need to be. This patch fixes (unifies) this for DIB. A check using pylint was added that this kind of passing parameters to the logging subsystem is enforced in future. As a blueprint a similar (stripped-down) approach from cinder [2] was used. [1] https://www.python.org/dev/peps/pep-0282/ [2] https://github.com/openstack/cinder/blob/master/tox.ini Change-Id: I2d7bcc863e4e9583d82d204438b3c781ac99824e Signed-off-by: Andreas Florath <andreas@florath.net>
61 lines
1.8 KiB
Python
61 lines
1.8 KiB
Python
# Copyright 2017 Andreas Florath (andreas@florath.net)
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import logging
|
|
|
|
from diskimage_builder.block_device.plugin import NodeBase
|
|
from diskimage_builder.block_device.plugin import PluginBase
|
|
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
class FstabNode(NodeBase):
|
|
def __init__(self, config, params):
|
|
super(FstabNode, self).__init__(config['name'])
|
|
self.base = config['base']
|
|
self.options = config.get('options', 'defaults')
|
|
self.dump_freq = config.get('dump-freq', 0)
|
|
self.fsck_passno = config.get('fsck-passno', 2)
|
|
|
|
def get_edges(self):
|
|
edge_from = [self.base]
|
|
edge_to = []
|
|
return (edge_from, edge_to)
|
|
|
|
def create(self, result, rollback):
|
|
logger.debug("fstab create called [%s]", self.name)
|
|
logger.debug("result [%s]", result)
|
|
|
|
if 'fstab' not in result:
|
|
result['fstab'] = {}
|
|
|
|
result['fstab'][self.base] = {
|
|
'name': self.name,
|
|
'base': self.base,
|
|
'options': self.options,
|
|
'dump-freq': self.dump_freq,
|
|
'fsck-passno': self.fsck_passno
|
|
}
|
|
|
|
|
|
class Fstab(PluginBase):
|
|
def __init__(self, config, defaults):
|
|
super(Fstab, self).__init__()
|
|
|
|
self.node = FstabNode(config, defaults)
|
|
|
|
def get_nodes(self):
|
|
return [self.node]
|