dee69b1810
This commit refactors the python code in diskimage_builder slightly. This is in preparation for a larger review that adds more functionality to the python code, namely the ability to apply elements to the current system as opposed to a chroot. Further, the refactorings can stand on their own for better clarity. They include: - renaming elements.py to element_dependencies.py. Adds clarity about the purpose of this module. - updating other code for this rename. - move tests into a tests submodule. Change-Id: I5519cc52398e442b24e33802bae42070d64b0c1d
92 lines
3.5 KiB
Python
92 lines
3.5 KiB
Python
# Copyright 2013 Hewlett-Packard Development Company, L.P.
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import os
|
|
|
|
import fixtures
|
|
import testtools
|
|
|
|
from diskimage_builder import element_dependencies
|
|
|
|
data_dir = os.path.abspath(
|
|
os.path.join(os.path.dirname(__file__), 'test-elements'))
|
|
|
|
|
|
def _populate_element(element_dir, element_name, element_deps=[]):
|
|
element_home = os.path.join(element_dir, element_name)
|
|
os.mkdir(element_home)
|
|
deps_path = os.path.join(element_home, 'element-deps')
|
|
with open(deps_path, 'w') as deps_file:
|
|
deps_file.write("\n".join(element_deps))
|
|
|
|
|
|
class TestElementDeps(testtools.TestCase):
|
|
|
|
def setUp(self):
|
|
super(TestElementDeps, self).setUp()
|
|
self.element_dir = self.useFixture(fixtures.TempDir()).path
|
|
_populate_element(self.element_dir, 'requires-foo', ['foo'])
|
|
_populate_element(self.element_dir, 'foo')
|
|
_populate_element(self.element_dir,
|
|
'requires-requires-foo',
|
|
['requires-foo'])
|
|
_populate_element(self.element_dir, 'self', ['self'])
|
|
_populate_element(self.element_dir, 'circular1', ['circular2'])
|
|
_populate_element(self.element_dir, 'circular2', ['circular1'])
|
|
|
|
def test_non_transitive_deps(self):
|
|
result = element_dependencies.expand_dependencies(
|
|
['requires-foo'],
|
|
elements_dir=self.element_dir)
|
|
self.assertEqual(set(['requires-foo', 'foo']), result)
|
|
|
|
def test_missing_deps(self):
|
|
self.assertRaises(SystemExit,
|
|
element_dependencies.expand_dependencies, ['fake'],
|
|
self.element_dir)
|
|
|
|
def test_transitive_deps(self):
|
|
result = element_dependencies.expand_dependencies(
|
|
['requires-requires-foo'], elements_dir=self.element_dir)
|
|
self.assertEqual(set(['requires-requires-foo',
|
|
'requires-foo',
|
|
'foo']), result)
|
|
|
|
def test_no_deps(self):
|
|
result = element_dependencies.expand_dependencies(
|
|
['foo'], elements_dir=self.element_dir)
|
|
self.assertEqual(set(['foo']), result)
|
|
|
|
def test_self(self):
|
|
result = element_dependencies.expand_dependencies(
|
|
['self'], elements_dir=self.element_dir)
|
|
self.assertEqual(set(['self']), result)
|
|
|
|
def test_circular(self):
|
|
result = element_dependencies.expand_dependencies(
|
|
['circular1'], elements_dir=self.element_dir)
|
|
self.assertEqual(set(['circular1', 'circular2']), result)
|
|
|
|
|
|
class TestElements(testtools.TestCase):
|
|
def test_depends_on_env(self):
|
|
self.useFixture(
|
|
fixtures.EnvironmentVariable('ELEMENTS_PATH', '/foo/bar'))
|
|
self.assertEqual('/foo/bar', element_dependencies.get_elements_dir())
|
|
|
|
def test_env_not_set(self):
|
|
self.useFixture(fixtures.EnvironmentVariable('ELEMENTS_PATH', ''))
|
|
self.assertRaises(Exception, element_dependencies.get_elements_dir, ())
|