disable tests with comments

func/core/pkg_network/20-configure-bridge.sh

@@ -2,7 +2,7 @@
 r_log "network" "Test bridging functionality (non-network manager)"
 
 bridge=dummybr0
-# shellcheck disable=SC1091
+# shellcheck disable=SC1091,1090
 . "$(dirname "$0")"/imports.sh
 
 r_log "network" "Add a dummy bridge $bridge"

sync/minor-release-sync-to-staging.sh

@@ -2,7 +2,7 @@
 # Performs a full on sync of a minor release, directories and all. It calls the
 # other scripts in this directory to assist.
 # Source common variables
-# shellcheck disable=SC2046,1091
+# shellcheck disable=SC2046,1091,1090
 source $(dirname "$0")/common
 
 # sync all pieces of a release, including extras, nfv, etc

sync/prep-staging-8.sh

@@ -12,8 +12,8 @@
 # Compose dir example: /mnt/repos-staging/mirror/pub/rocky/8.4-RC2
 
 # Source common variables
-# shellcheck disable=SC2046,1091
-source $(dirname "$0")/common
+# shellcheck disable=SC2046,1091,1090
+source "$(dirname "$0")/common"
 
 echo "** Updating source repos"
 for y in "${ALL_REPOS[@]}"; do

sync/sync-to-prod.sh

@@ -2,8 +2,8 @@
 # Syncs everything from staging to production
 
 # Source common variables
-# shellcheck disable=SC2046,1091
-source $(dirname "$0")/common
+# shellcheck disable=SC2046,1091,1090
+source "$(dirname "$0")/common"
 
 REV=${1}
 
@@ -13,6 +13,9 @@ ret_val=$?
 if [ $ret_val -eq "0" ]; then
   TARGET="${PRODUCTION_ROOT}/${CATEGORY_STUB}/${REV:0:3}"
   mkdir -p "${TARGET}"
+  # disabling because none of our files should be starting with dashes. If they
+  # are something is *seriously* wrong here.
+  # shellcheck disable=SC2035
   sudo -l && find **/* -maxdepth 0 -type d | parallel --will-cite -j 18 sudo rsync -av --chown=10004:10005 --progress --relative --human-readable \
       {} "${TARGET}"
 fi

sync/sync-to-staging-sig.sh

@@ -1,8 +1,8 @@
 #!/bin/bash
 
 # Source common variables
-# shellcheck disable=SC2046,1091
-source $(dirname "$0")/common
+# shellcheck disable=SC2046,1091,1090
+source "$(dirname "$0")/common"
 
 # Major Version (eg, 8)
 MAJ=${1}
@@ -19,6 +19,9 @@ ret_val=$?
 if [ $ret_val -eq "0" ]; then
   TARGET=${STAGING_ROOT}/${CATEGORY_STUB}/${REV}/${SIG}
   mkdir -p "${TARGET}"
+  # disabling because none of our files should be starting with dashes. If they
+  # are something is *seriously* wrong here.
+  # shellcheck disable=SC2035
   sudo -l && find **/* -maxdepth 0 -type d | parallel --will-cite -j 18 sudo rsync -av --chown=10004:10005 --progress --relative --human-readable \
       {} "${TARGET}"
 fi

sync/sync-to-staging.sh

@@ -1,8 +1,8 @@
 #!/bin/bash
 
 # Source common variables
-# shellcheck disable=SC2046,1091
-source $(dirname "$0")/common
+# shellcheck disable=SC2046,1091,1090
+source "$(dirname "$0")/common"
 
 # Major Version (eg, 8)
 MAJ=${1}
@@ -17,6 +17,9 @@ ret_val=$?
 if [ $ret_val -eq "0" ]; then
   TARGET="${STAGING_ROOT}/${CATEGORY_STUB}/${REV}"
   mkdir -p "${TARGET}"
+  # disabling because none of our files should be starting with dashes. If they
+  # are something is *seriously* wrong here.
+  # shellcheck disable=SC2035
   sudo -l && find **/* -maxdepth 0 -type d | parallel --will-cite -j 18 sudo rsync -av --chown=10004:10005 --progress --relative --human-readable \
       {} "${TARGET}"
 fi