Neil Hanlon
7365ca6b06
* reorder imports * pass cli arguments directly into class for simplification and segregation * reorder class variables * Some error checking to ensure we're writing what we want to * Allow copy(upload?) step to be skipped * properly consume stdout and stderr from popen to avoid exception when FD is closed but trying to be read by the subprocess_log function |
||
|---|---|---|
| .. | ||
| empanadas | ||
| images | ||
| tests | ||
| .gitignore | ||
| build-container.sh | ||
| Containerfile | ||
| Containerfile.imagefactory | ||
| poetry.lock | ||
| pyproject.toml | ||
| README.md | ||
iso
Setup / Install
- Install Poetry
- Setup:
poetry install - Have fun
Updating dependencies
Dependencies can be manipulated via the pyproject.toml file or with the poetry add/remove commands.
Changes to the poetry.lock should be commited if dependencies are added or updated.
TODO
Verbose mode should exist to output everything that's being called or ran.
There should be additional logging regardless, not just to stdout, but also to a file.
scripts
* sync_from_peridot -> Syncs repositories from Peridot
* sync_sig -> Syncs SIG repositories from Peridot
* build-iso -> Builds initial ISO's using Lorax
* build-iso-extra -> Builds DVD's and other images based on Lorax data
* launch-builds -> Creates a kube config to run build-iso
* build-image -> Runs build-iso
wrappers
* common -> The starting point
* iso_utils -> Does work for ISO building and generation
* dnf_utils -> Does work for repo building and generation
* check -> Checks if the architecture/release combination are valid
* shared -> Shared utilities between all wrappers
rules
imports
When making a script, you must import common. This is insanely bad practice, but we would prefer if we started out this way:
import argparse
from empanadas.common import *
from empanadas.util import Checks
Whatever is imported in common will effectively be imported in your scripts as
well, but there is nothing stopping you from defining them again, even out of
habit. argparse is there because you better have a very, very good reason
to not be writing scripts that are major version specific.
If you are writing something that could be arch specific based on the major version (which is likely), make sure to import the util module and use it arch checker appropriately. Small (but weak) example.
from util import Checks
rlvars = rldict['9']
r = Checks(rlvars, arch)
r.check_valid_arch()
script names and permissions
- Callable scripts should always end in
.pyand live in the empanadas/scripts folder - Poetry will handle the installation of these executables with setuptools for distribution, and they can be invoked by name using
poetry run script-name, too.- Configure the script and function to be executed in pyproject.toml (TODO: dynamically load scripts from this directory as well as standardize on the script input/outputs)