This is related to enabling update tests for KDE. While testing
that it transpired that the KDE disk image is missing various
stuff that is on the live image and systems installed from the
live image; this is because the kde-desktop-environment env
group doesn't by default include several groups and individual
packages that the live kickstart *does* include. So our current
disk image closely matches what you get if you do a network
install and pick the KDE env group and don't pick any option
groups, but that's not a very common thing to do, and it causes
problems for the tests (e.g. okular and firefox not being
there). I think it's reasonable to make the image resemble a
live install more closely; this is more convenient but I think
it's *also* more useful, as there are probably far more KDE
installs out there *with* these things than without them. More
KDE installs are probably done with the live than via network
install, and even KDE installs done via netinst may well have
these bits added subsequently.
Obviously, we bump the image version with this change, so we'll
need to update the scheduler and templates also.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Summary:
We've kinda been having too much trouble with virt-builder
lately, mainly SELinux related issues due to how it does image
customization. It also produces images that differ in notable
ways from what a 'typical' install would give. virt-install
solves both these problems, and also gives us more flexibility
for storage configuration and post-install customization should
we need them in future.
The change isn't really too drastic, and the design is similar:
instead of virt-builder commands files, each image type now has
a kickstart file where all its customizations can be done.
There's also a single extra image dict key, 'variant', which
specifies which install tree variant to use for running the
install. It defaults to 'Everything' (for F24+) and 'Server'
(for <F24, as Everything wasn't installable until F24) but we
set it to 'Server' for the server images and 'Workstation' for
the desktop images, so those installs will use the correct
variant install class.
We run the installs in VNC. You can do it with a serial console
and log the output, but then anaconda gets clever and changes
several things in the installed system based on the fact that
you did the install over a serial console: it twiddles with
the kernel args and doesn't set graphical.target as the default.
We don't want any of that mess, so we do a VNC install.
The 'size' value is just a number of gigabytes for virt-install
images (as that's how the virt-install 'size' argument works).
This also drops some unused 32-bit images (we don't do 32-bit
KDE or Server upgrade tests, so there's no need to build those
images).
Test Plan:
Re-generate all affected images and re-run all tests
that use them, make sure they work. I am doing this on staging
at present. Note: this would render D911 unnecessary.
Reviewers: garretraziel
Reviewed By: garretraziel
Subscribers: tflink
Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D917
