Try and clean up desktop update needles a bit

The 'desktop_pacakge_tool_update-kde-detected' needles and
'desktop_update_notification_systray-kde' needles are actually
matching on exactly the same thing, so drop the redundancy. We
need to have the desktop_package_tool_update tag on the older
(F33) version of this needle because on F33 we click on it to
launch the update tool in the desktop_update_graphical test; from
F34 onwards this is *not* what we want to do so the needle should
not have that tag to avoid throwing the test off. When F33 goes
EOL we can drop that tag from the needle and simplify the
destop_update_graphical test. Also add a needle for the Discover
app's 'update' icon when no updates are found.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
This commit is contained in:
Adam Williamson 2021-06-14 12:27:20 -07:00
parent c28785afec
commit 0b45cd4adc
11 changed files with 7 additions and 53 deletions

View File

@ -1,17 +0,0 @@
{
"area": [
{
"xpos": 753,
"width": 19,
"type": "match",
"ypos": 741,
"height": 18,
"match": 90
}
],
"properties": [],
"tags": [
"DESKTOP-kde",
"desktop_package_tool_update"
]
}

Binary file not shown.

Before

Width:  |  Height:  |  Size: 579 KiB

View File

@ -1,17 +0,0 @@
{
"area": [
{
"width": 19,
"type": "match",
"height": 18,
"ypos": 741,
"xpos": 779,
"match": 90
}
],
"properties": [],
"tags": [
"DESKTOP-kde",
"desktop_package_tool_update"
]
}

Binary file not shown.

Before

Width:  |  Height:  |  Size: 666 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 765 KiB

View File

@ -1,16 +0,0 @@
{
"area": [
{
"height": 18,
"ypos": 738,
"xpos": 745,
"width": 19,
"type": "match"
}
],
"properties": [],
"tags": [
"DESKTOP-kde",
"desktop_package_tool_update"
]
}

Binary file not shown.

Before

Width:  |  Height:  |  Size: 853 KiB

View File

@ -1,9 +1,9 @@
{
"area": [
{
"xpos": 756,
"ypos": 738,
"height": 18,
"xpos": 9,
"ypos": 545,
"type": "match",
"width": 19
}

Binary file not shown.

After

Width:  |  Height:  |  Size: 416 KiB

View File

@ -11,6 +11,7 @@
],
"properties": [],
"tags": [
"desktop_update_notification_systray"
"desktop_update_notification_systray",
"desktop_package_tool_update"
]
}

View File

@ -16,6 +16,9 @@ sub run {
desktop_vt;
# run the updater
# FIXME: when F33 goes EOL, remove all the KDE < F34 stuff below
# and drop 'desktop_package_tool_update' tag from
# desktop_update_notification_systray-kde-20200929.json
if ($desktop eq 'kde') {
# KDE team tells me until F34 the 'preferred' update method
# was the systray applet...