cockpit: update needles for 198, rejig Services page handling

Cockpit 198 comes with a UI overhaul, so almost all needles
need an update.

The 'auditd' service is no longer on the first page. To make
this less fragile (at the cost of not testing that clicking on
a service actually opens the detail page *for that service*,
tweak the needles to just look for *any* running service, click
on it, and check we got to a 'details' page. We also redo the
existing needles for this design.

Signed-off-by: Adam Williamson <awilliam@redhat.com>

needles/cockpit/cockpit_main-cockpit198.json

@@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "ypos": 173,
+      "height": 15,
+      "width": 59,
+      "xpos": 425,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "cockpit_main"
+  ]
+}

needles/cockpit/join_button-cockpit198.json

@@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "type": "match",
+      "xpos": 921,
+      "height": 18,
+      "width": 31,
+      "ypos": 477
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "cockpit_join_button"
+  ]
+}

needles/cockpit/join_complete-cockpit198.json

@@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "type": "match",
+      "xpos": 437,
+      "height": 17,
+      "ypos": 436,
+      "width": 164
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "cockpit_join_complete"
+  ]
+}

needles/cockpit/join_domain-cockpit198.json

@@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "width": 160,
+      "height": 27,
+      "ypos": 188,
+      "xpos": 381,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "cockpit_join_domain"
+  ]
+}

needles/cockpit/join_domain_button-link-cockpit198.json

@@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 508,
+      "ypos": 438,
+      "height": 15,
+      "width": 94,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "cockpit_join_domain_button"
+  ]
+}

needles/cockpit/join_progress-cockpit198.json

@@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 424,
+      "ypos": 477,
+      "height": 14,
+      "width": 152,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "cockpit_join_progress"
+  ]
+}

needles/cockpit/logs-cockpit198.json

@@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 122,
+      "ypos": 266,
+      "height": 18,
+      "width": 39,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "cockpit_logs"
+  ]
+}

needles/cockpit/logs_entry-cockpit198.json

@@ -1,15 +1,15 @@
 {
-  "properties": [],
-  "tags": [
-    "cockpit_services_auditd_detail"
-  ],
   "area": [
     {
-      "xpos": 215,
+      "width": 43,
-      "ypos": 325,
-      "width": 319,
       "height": 13,
+      "ypos": 266,
+      "xpos": 859,
       "type": "match"
     }
+  ],
+  "properties": [],
+  "tags": [
+    "cockpit_logs_entry"
   ]
 }

needles/cockpit/logs_entry_detail-cockpit198.json

@@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "type": "match",
+      "xpos": 473,
+      "height": 14,
+      "ypos": 384,
+      "width": 163
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "cockpit_logs_detail"
+  ]
+}

needles/cockpit/logs_severity-cockpit198.json

@@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "type": "match",
+      "height": 16,
+      "width": 62,
+      "ypos": 160,
+      "xpos": 529
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "cockpit_logs_severity"
+  ]
+}

needles/cockpit/services-cockpit198.json

@@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 121,
+      "height": 13,
+      "ypos": 424,
+      "width": 65,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "cockpit_services"
+  ]
+}

needles/cockpit/services_auditd.json

@@ -1,15 +0,0 @@
-{
-  "area": [
-    {
-      "xpos": 580,
-      "ypos": 482,
-      "width": 81,
-      "height": 14,
-      "type": "match"
-    }
-  ],
-  "tags": [
-    "cockpit_services_auditd"
-  ],
-  "properties": []
-}

needles/cockpit/services_auditd_detail-cockpit186-20190126.json

@@ -1,15 +0,0 @@
-{
-  "area": [
-    {
-      "ypos": 339,
-      "xpos": 401,
-      "type": "match",
-      "width": 219,
-      "height": 13
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "cockpit_services_auditd_detail"
-  ]
-}

needles/cockpit/services_detail-20190126.json

@@ -0,0 +1,15 @@
+{
+    "area": [
+        {
+            "height": 13,
+            "type": "match",
+            "width": 74,
+            "xpos": 276,
+            "ypos": 564
+        }
+    ],
+    "properties": [],
+    "tags": [
+        "cockpit_services_detail"
+    ]
+}

needles/cockpit/services_detail-cockpit198.json

@@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "type": "match",
+      "height": 16,
+      "width": 94,
+      "ypos": 650,
+      "xpos": 375
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "cockpit_services_detail"
+  ]
+}

needles/cockpit/services_entry-cockpit198.json

@@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "ypos": 478,
+      "height": 14,
+      "width": 101,
+      "xpos": 745,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "cockpit_services_entry"
+  ]
+}

needles/cockpit/services_entry.json

@@ -0,0 +1,15 @@
+{
+    "area": [
+        {
+            "height": 14,
+            "type": "match",
+            "width": 91,
+            "xpos": 780,
+            "ypos": 482
+        }
+    ],
+    "properties": [],
+    "tags": [
+        "cockpit_services_entry"
+    ]
+}

tests/server_cockpit_basic.pm

@@ -21,10 +21,10 @@ sub run {
     # go to the services screen
     assert_and_click "cockpit_services";
     wait_still_screen 2;
-    # assume auditd is there, click it
+    # click on an entry
-    assert_and_click "cockpit_services_auditd";
+    assert_and_click "cockpit_services_entry";
-    # check we get to the appropriate detail screen
+    # check we get to a detail screen
-    assert_screen "cockpit_services_auditd_detail";
+    assert_screen "cockpit_services_detail";
 }
 
 sub test_flags {