cockpit_updates: break out of loop if we see success

Behaviour changed a bit in Cockpit 238, we may now just hit
success during this loop, so handle that. Also use 'break' for
the other two cases, not a big run counter bump.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
This commit is contained in:
Adam Williamson 2021-02-18 14:30:50 -08:00
parent 45ecd40834
commit 9226ccabe3

View File

@ -46,18 +46,19 @@ sub run {
# and relog for further interaction. We will check if reconnection is # and relog for further interaction. We will check if reconnection is
# needed and if so, we will restart Firefox and login again. # needed and if so, we will restart Firefox and login again.
# #
break if (check_screen("cockpit_updates_updated"));
if (check_screen("cockpit_updates_reconnect", 1)) { if (check_screen("cockpit_updates_reconnect", 1)) {
quit_firefox; quit_firefox;
sleep 5; sleep 5;
start_cockpit(1); start_cockpit(1);
select_cockpit_update(); select_cockpit_update();
$run = 50; break;
} }
# Ignore rebooting the system because we want to finish the test instead. # Ignore rebooting the system because we want to finish the test instead.
elsif (check_screen('cockpit_updates_restart_ignore', 1)) { elsif (check_screen('cockpit_updates_restart_ignore', 1)) {
assert_and_click 'cockpit_updates_restart_ignore'; assert_and_click 'cockpit_updates_restart_ignore';
$run = 50; break;
} }
else { else {
sleep 10; sleep 10;