From bd7d3cd66398ca295ed063e6da8969bbc0dc4cb2 Mon Sep 17 00:00:00 2001
From: Adam Williamson <awilliam@redhat.com>
Date: Thu, 15 Oct 2020 16:25:26 -0700
Subject: [PATCH] Fix desktop_terminal command check (thanks defolos)

This check wasn't working, the test passed whatever wait_serial
found. This version suggested by defolos works, I checked.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
---
 tests/desktop_terminal.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/desktop_terminal.pm b/tests/desktop_terminal.pm
index 20f3a0ba..d495080c 100644
--- a/tests/desktop_terminal.pm
+++ b/tests/desktop_terminal.pm
@@ -20,7 +20,7 @@ sub run {
     # we're reinventing assert_script_run instead of using it so
     # we can type safely
     type_very_safely "ls && echo 'ls OK' > /dev/ttyS0\n";
-    wait_serial "ls OK" || die "terminal command failed";
+    die "terminal command failed" unless defined wait_serial "ls OK";
 }
 
 sub test_flags {