Needles for _graphical_wait_login allowing English language Gnome environments to Getting Started (#49)

* add needles for _graphical_wait_login
* remove install_package_set_kde
* add new test suites and job group to simplify package_set testing
* modify _software_selection for pre-selected graphical-server case
* restore non-Gnome installs to package-set test suite

needles/anaconda/install_process/rocky_user_created-20210919.json

@@ -0,0 +1,16 @@
+{
+  "area": [
+    {
+      "xpos": 286,
+      "ypos": 592,
+      "width": 105,
+      "height": 13,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "ENV-DISTRI-rocky",
+    "anaconda_install_user_created"
+  ]
+}

needles/gnome/rocky-apps_menu_button-20210919.json

@@ -0,0 +1,17 @@
+{
+  "area": [
+    {
+      "height": 15,
+      "xpos": 30,
+      "type": "match",
+      "ypos": 6,
+      "width": 67
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "ENV-DISTRI-rocky",
+    "apps_menu_button",
+    "apps_menu_button_inactive"
+  ]
+}

needles/gnome/rocky-gdm_initial_setup_licence_accept-20210919.json

@@ -0,0 +1,27 @@
+{
+  "area": [
+    {
+      "xpos": 90,
+      "ypos": 143,
+      "width": 113,
+      "height": 23,
+      "type": "match"
+    },
+    {
+      "xpos": 84,
+      "ypos": 629,
+      "width": 205,
+      "height": 21,
+      "type": "match",
+      "click_point": {
+        "xpos": 10.5,
+        "ypos": 10.5
+      }
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "ENV-DISTRI-rocky",
+    "gdm_initial_setup_licence_accept"
+  ]
+}

needles/gnome/rocky-gdm_initial_setup_license-20210918.json

@@ -0,0 +1,24 @@
+{
+  "area": [
+    {
+      "xpos": 164,
+      "ypos": 11,
+      "width": 120,
+      "height": 25,
+      "type": "match"
+    },
+    {
+      "xpos": 487,
+      "ypos": 381,
+      "width": 204,
+      "height": 54,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "DESKTOP-gnome",
+    "ENV-DISTRI-rocky",
+    "gdm_initial_setup_license"
+  ]
+}

needles/gnome/rocky-gdm_initial_setup_license_accepted-20210919.json

@@ -0,0 +1,16 @@
+{
+  "area": [
+    {
+      "xpos": 484,
+      "ypos": 394,
+      "width": 213,
+      "height": 73,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "ENV-DISTRI-rocky",
+    "gdm_initial_setup_license_accepted"
+  ]
+}

needles/gnome/rocky-gdm_initial_setup_spoke_forward-20210919.json

@@ -0,0 +1,20 @@
+{
+  "area": [
+    {
+      "xpos": 846,
+      "ypos": 728,
+      "width": 162,
+      "height": 21,
+      "type": "match",
+      "click_point": {
+        "xpos": 81,
+        "ypos": 10.5
+      }
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "ENV-DISTRI-rocky",
+    "gdm_initial_setup_spoke_forward"
+  ]
+}

needles/gnome/rocky-gdm_spoke_done-20210919.json

@@ -0,0 +1,16 @@
+{
+  "area": [
+    {
+      "xpos": 12,
+      "ypos": 32,
+      "width": 52,
+      "height": 24,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "ENV-DISTRI-rocky",
+    "gdm_spoke_done"
+  ]
+}

needles/gnome/rocky-getting_started-20210919.json

@@ -0,0 +1,16 @@
+{
+  "area": [
+    {
+      "xpos": 452,
+      "ypos": 33,
+      "width": 117,
+      "height": 21,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "ENV-DISTRI-rocky",
+    "getting_started"
+  ]
+}

needles/gnome/rocky-login_gdm_input-20210919.json

@@ -0,0 +1,18 @@
+{
+  "area": [
+    {
+      "xpos": 340,
+      "height": 68,
+      "type": "match",
+      "width": 343,
+      "ypos": 343
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "DESKTOP-gnome",
+    "ENV-DISTRI-rocky",
+    "LANGUAGE-english",
+    "graphical_login_input"
+  ]
+}

needles/gnome/rocky-next_button-20210919.json

@@ -0,0 +1,20 @@
+{
+  "area": [
+    {
+      "xpos": 959,
+      "ypos": 37,
+      "width": 54,
+      "height": 25,
+      "type": "match",
+      "click_point": {
+        "xpos": 27,
+        "ypos": 12.5
+      }
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "ENV-DISTRI-rocky",
+    "next_button"
+  ]
+}

needles/gnome/rocky-skip_button-20210919.json

@@ -0,0 +1,20 @@
+{
+  "area": [
+    {
+      "xpos": 963,
+      "ypos": 37,
+      "width": 51,
+      "height": 26,
+      "type": "match",
+      "click_point": {
+        "xpos": 25.5,
+        "ypos": 13
+      }
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "ENV-DISTRI-rocky",
+    "skip_button"
+  ]
+}

templates.fif.json

@@ -62,6 +62,15 @@
             },
             "version": "*"
         },
+        "rocky-package-set-x86_64-*": {
+            "arch": "x86_64",
+            "distri": "rocky",
+            "flavor": "package-set",
+            "settings": {
+                "TEST_TARGET": "ISO"
+            },
+            "version": "*"
+        },
         "rocky-universal-x86_64-*": {
             "arch": "x86_64",
             "distri": "rocky",
@@ -93,6 +102,14 @@
             "machine": "uefi",
             "product": "rocky-dvd-iso-x86_64-*"
         },
+        "rocky-package-set-x86_64-*-64bit": {
+            "machine": "64bit",
+            "product": "rocky-package-set-x86_64-*"
+        },
+        "rocky-package-set-x86_64-*-uefi": {
+            "machine": "64bit",
+            "product": "rocky-package-set-x86_64-*"
+        },
         "rocky-universal-x86_64-*-64bit": {
             "machine": "64bit",
             "product": "rocky-universal-x86_64-*"
@@ -509,25 +526,66 @@
                 "ROOT_PASSWORD": "weakpassword"
             }
         },
-        "install_package_set_kde": {
-            "profiles": {
-                "rocky-universal-x86_64-*-64bit": 50
-            },
-            "settings": {
-                "DESKTOP": "kde",
-                "HDDSIZEGB": "15",
-                "PACKAGE_SET": "kde",
-                "POSTINSTALL": "_collect_data",
-                "REPOSITORY_VARIATION": "%LOCATION%"
-            }
-        },
         "install_package_set_minimal": {
             "profiles": {
                 "rocky-universal-x86_64-*-64bit": 30
             },
             "settings": {
                 "PACKAGE_SET": "minimal",
-                "POSTINSTALL": "_collect_data"
+                "POSTINSTALL": "_console_login"
+            }
+        },
+        "install_package_set_minimal": {
+            "profiles": {
+                "rocky-package-set-x86_64-*-64bit": 30
+            },
+            "settings": {
+                "PACKAGE_SET": "minimal",
+                "POSTINSTALL": "_console_login"
+            }
+        },
+        "install_package_set_server": {
+            "profiles": {
+                "rocky-package-set-x86_64-*-64bit": 30
+            },
+            "settings": {
+                "PACKAGE_SET": "server",
+                "POSTINSTALL": "_console_login"
+            }
+        },
+        "install_package_set_graphical-server": {
+            "profiles": {
+                "rocky-package-set-x86_64-*-64bit": 30
+            },
+            "settings": {
+                "DESKTOP": "gnome",
+                "ENCRYPT_PASSWORD": "weakpassword",
+                "PACKAGE_SET": "graphical-server",
+                "POSTINSTALL": "_console_login",
+                "ROOT_PASSWORD": "weakpassword",
+                "USER_LOGIN": "qwerty"
+            }
+        },
+        "install_package_set_workstation": {
+            "profiles": {
+                "rocky-package-set-x86_64-*-64bit": 30
+            },
+            "settings": {
+                "DESKTOP": "gnome",
+                "ENCRYPT_PASSWORD": "weakpassword",
+                "PACKAGE_SET": "workstation",
+                "POSTINSTALL": "_console_login",
+                "ROOT_PASSWORD": "weakpassword",
+                "USER_LOGIN": "qwerty"
+            }
+        },
+        "install_package_set_virtualization-host": {
+            "profiles": {
+                "rocky-package-set-x86_64-*-64bit": 30
+            },
+            "settings": {
+                "PACKAGE_SET": "virtualization-host",
+                "POSTINSTALL": "_console_login"
             }
         },
         "install_pxeboot": {

tests/_software_selection.pm

@@ -39,13 +39,17 @@ sub run {
     send_key "tab";
     wait_still_screen 1;
 
-    # select desired environment
-    # go through the list 20 times at max (to prevent infinite loop when it's missing)
-    for (my $i = 0; !check_screen("anaconda_".$packageset."_highlighted", 1) && $i < 20; $i++) {
-	       send_key "down";
-    }
+    # In Rocky, graphical-server starts out selected in the DVD ISO so if that's
+    # what we're looking for we're done
+    if (!check_screen("anaconda_".$packageset."_selected", 1)) {
+      # select desired environment
+      # go through the list 20 times at max (to prevent infinite loop when it's missing)
+      for (my $i = 0; !check_screen("anaconda_".$packageset."_highlighted", 1) && $i < 20; $i++) {
+        send_key "down";
+      }
 
-    send_key "spc";
+      send_key "spc";
+    }
 
     # check that desired environment is selected
     assert_screen "anaconda_".$packageset."_selected";