Handle 'authentication required' appearing on Boxes startup

In the last few weeks Boxes is showing an auth dialog on start.
I've filed a bug on this; let's have the test handle it as a
soft failure, since this isn't a fatal problem. Do this by
making an existing needle for this dialog a bit more generic
in name and using it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>

needles/gnome/auth_required-20190212.json

@@ -11,6 +11,6 @@
   "properties": [],
   "tags": [
     "DESKTOP-gnome",
-    "desktop_update_auth_required"
+    "auth_required"
   ]
 }

needles/gnome/auth_required.json

@@ -11,6 +11,6 @@
   "properties": [],
   "tags": [
     "DESKTOP-gnome",
-    "desktop_update_auth_required"
+    "auth_required"
   ]
 }

tests/apps_startstop/gnome/boxes.pm

@@ -10,8 +10,17 @@ sub run {
     
     # Start the application
     start_with_launcher('apps_menu_boxes');
-    # Check that is started
-    assert_screen 'apps_run_boxes';
+    # handling 'auth required' screen appearing as a soft fail,
+    # check that is started
+    # https://bugzilla.redhat.com/show_bug.cgi?id=1692972
+    assert_screen ['apps_run_boxes', 'auth_required'];
+    if (match_has_tag 'auth_required') {
+        record_soft_failure "Firewall authentication screen appeared - RHBZ #1692972";
+        my $user_password = get_var("USER_PASSWORD") || "weakpassword";
+        type_very_safely $user_password;
+        send_key 'ret';
+        assert_screen 'apps_run_boxes';
+    }
     # Close the application
     quit_with_shortcut();
     

tests/desktop_update_graphical.pm

@@ -27,7 +27,7 @@ sub run {
     else {
         # work around https://gitlab.gnome.org/GNOME/gnome-software/issues/582
         # if it happens
-        if (check_screen "desktop_update_auth_required", 10) {
+        if (check_screen "auth_required", 10) {
             record_soft_failure "spurious 'auth required' - https://gitlab.gnome.org/GNOME/gnome-software/issues/582";
             # bit sloppy but correct for both...
             type_safely "weakpassword\n";