Commit Graph

64 Commits

Author SHA1 Message Date
Adam Williamson
2a7787c1da Update lots of needles for os-autoinst behaviour change
Recent git os-autoinst no longer downsamples screenshots as far
as it did before comparison. This makes a lot of needles where
colors have changed slightly no longer match, so they all needed
updating.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-07-19 13:03:11 -07:00
Lukáš Růžička
6d1d549941 Introduce a resize check and a postinstall test for custom and blivet
tests.

This PR fixes #228.
2021-06-30 11:01:50 +02:00
Adam Williamson
fcf96f73b7 Tweak Blivet LVM device type needles
There's some cheating/sloppiness going on here, with the same tag
and sometimes same needle being used to match "LVM2 Volume Group"
and "LVM2 Logical Volume". Today this caused us to pick the thin
pool entry instead in a test, so let's just clean this up and do
it right, with separate needles for matching each thing.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-06-07 18:16:46 -07:00
Adam Williamson
784962c96e Fix btrfs_preserve_home for UEFI
When running this test on UEFI, we need to preserve /boot/efi.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-02-19 14:48:47 -08:00
Lukáš Růžička
866a8efa72 Add a new testcase to test creation of LVM with ext4 using Blivet.
This PR adds a test that uses the Blivet interface to create an LVM
layout with ext4 filesystem as well as a postinstall test that checks
that the LVM layout has been created correctly.
2021-02-19 13:42:20 -08:00
Lukáš Růžička
ecca7d3c01 Create testcase to recreate Btrfs layout using Blivet and preserve home.
This PR uses the Anaconda Blivet partitioning to recreate a partition
layout while preserving the content of the /home subvolume.

It also adds the postinstall test to check that the home has been
preserved.
2021-01-28 09:51:32 +01:00
Lukáš Růžička
ba90c70c8a Add several tests to test QA:Testcase_partitioning_custom_btrfs_preserve_home.
This PR adds the `install_btrfs_upload` to install the btrfs based
image, the `btrfs_preserve_home_extras` to prepare and test the data
on the home partition, as well as the `custom_btrfs_preserve_home` that
uses the preinstalled btrfs image and uses its current partitioning to
preserve the home partition and the data on it.
2021-01-20 16:50:39 +00:00
Michel Normand
e9c15a502a ppc64le changes in disk_custom_blivet_resize_lvm.pm
Required because ppc64le has a PReP partition
before boot partition.
PReP partition must not be changed by this script.

Signed-off-by: Michel Normand <normand@linux.vnet.ibm.com>
2021-01-12 11:14:17 +01:00
Lukáš Růžička
5718c7f1d4 Add an installation test using LVM partitioning as asset for resize tests.
When Fedora went to BTRFS as a default, we lost the LVM based image to
run LVM resize tests with.

This PR introduces the `install_lvm.pm` installation test that creates
an LVM based qcow2 image to be used by follow-up tests.
2020-11-26 09:55:19 +01:00
Adam Williamson
a2bbd5ecfb Add some needles for universal tests with btrfs default
The 'universal' tests have quite a few failures if you run them
on an image where btrfs is the default (currently they usually
run on the Server DVD, where xfs-on-LVM is still the default).
This fixes some of them, the others would need code fixes.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-09-11 16:20:12 -07:00
Adam Williamson
2e21161785 Update various needles for a GNOME symbol change
The little triangle that's used on drop-down menus and stuff got
bigger. That breaks all these needles.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-06-05 14:27:34 -07:00
Lukáš Růžička
b5169e602b Use existing needles for fs selection. 2020-05-27 15:54:10 -07:00
Lukáš Růžička
d8171958ed Rename needle to correct typo. 2020-05-27 15:54:10 -07:00
Lukáš Růžička
c9bc7f0570 Rename needles to match the tag. 2020-05-27 15:54:10 -07:00
Lukáš Růžička
2a3e67991b Whitelist not recognized needles in check-needles.py 2020-05-27 15:54:09 -07:00
Lukáš Růžička
5f1db40ebe Add to templates. 2020-05-27 15:54:09 -07:00
Lukáš Růžička
c42f62da14 Create a test for resizing using custom partitioning 2020-05-27 15:54:09 -07:00
Lukáš Růžička
9efb0e10e6 Create a test to resize LVM partitions using Blivet. 2020-05-27 15:54:09 -07:00
Adam Williamson
9bad775aae Update a blivet needle for a change to check mark design
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-29 12:19:39 -07:00
Adam Williamson
21eea18562 Add a needle check script, remove some unused needles
I call this...The @lruzicka Catcher!

It's a script that checks for needles that aren't actually used
anywhere. It also checks for cases where we have a needle JSON
file but no image, or an image file but no JSON file (and wipes
one case of the latter). It also adds a run of the script to tox
so we get it in CI.

You could make this script a lot more elaborate if you like, by
being fancier about parsing the test code and templates, but I
don't think it's really warranted, I think it just needs to be
'good enough'. It's not the end of the world if it misses the
odd thing or the whitelisting goes stale.

Quite a lot of the removed needles are remnants of different
approaches to app start/stop testing which weren't caught in the
initial PR review. The short-name partitioning ones are odd; they
were introduced in the commit that moved needles into subdirs,
but at least some of them don't actually appear to be moves. They
may have been non-tracked files Josef had lying around that got
into the commit by mistake, or they may just be old needles we
really used at some point but aren't using any more.
reclaim_space_second_partition was introduced as part of the
shrink test (along with reclaim_space_first_partition) but was
never actually used by that test - I guess, again, the test got
re-written during review but we forgot to remove the needle. We
rejigged user creation to use tab presses not a needle match a
while back, which made user_creation_password_input unnecessary.
The various cockpit_updates_* needles are I think remnants of
rewrites of the cockpit update tests that again were missed in
PR review, the tests as merged never used them.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-08 16:55:46 -07:00
Adam Williamson
dc7b7a7241 Great Needle Cleanup 2020
Remove a bunch of needles that have not been used for some time,
plus a few workarounds that are similarly stale.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-20 14:02:10 -07:00
Adam Williamson
e5feab11f7 Update iSCSI-related needles for font changes
This test has been failing forever, now the bug is fixed, we need
to update the needles for font changes...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-04 09:15:00 -08:00
Adam Williamson
95e6ddc896 Update blivet vdb selected needle yet again
I do not know why this needle seems so troublesome...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-25 23:02:29 -08:00
Adam Williamson
deab03a80d Update another partitioning needle for GTK+ widget changes
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-20 08:12:16 -08:00
Adam Williamson
12b0fb04dc Update a ppc64le-only blivet needle for Cantarell 0.201
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-24 15:20:54 +01:00
Adam Williamson
21febe3592 First batch of updates for new version of cantarell
Still need to do the non-English languages. I'll do those
tomorrow.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-17 01:18:52 +00:00
Adam Williamson
acf27fcd4a Update the blivet 'bluebox-alt' needle used on alt arches
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-06 10:56:44 -08:00
Adam Williamson
7fbaa426e8 Update a bunch of needles for font rendering change in Rawhide
Not sure what changed; it seems like mostly browser needles got
broken, but there's a few installer needles too.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-11-29 13:00:54 -08:00
Adam Williamson
0f9fd1a76a Add alternative vdb selected needle for new blue checkboxes
This checkbox sometimes renders slightly differently, especially
on non-x86_64. We're not really sure why, but we just add more
needles to handle it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-16 11:23:47 -07:00
Adam Williamson
a3c207a045 Add a few more 'blue button' needle variants
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-05 18:09:14 -07:00
Adam Williamson
26308a6b47 Update rarely-used installer ext4/xfs partitioning needles
These only get used when we run universal tests on a non-Server
image, which is pretty rare (these days, as Server DVD is a
critical image and composes fail if it fails, it only really
happens when we do it manually for some reason, like I did
today). So they get stale and aren't updated for font rendering
changes and stuff. As I said I had to do a run like that today,
so I had to update all these needles...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-28 14:04:13 -07:00
Adam Williamson
77a6c0ed4d Add yet another variant 'vdb selected' needle
This screen often seems to show slight variances in color,
really not sure why.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-26 16:28:44 -07:00
Adam Williamson
ca0f772120 Add some new variant needles for anaconda text changes
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-16 12:35:52 -07:00
Guy Menanteau
9475fec56f New needle anaconda_blivet_vdb_selected-20190416
as previous needle only matched 96%
https://openqa.stg.fedoraproject.org/tests/520670#step/disk_custom_blivet_software_raid/36

Signed-off-by: Michel Normand <normand@linux.vnet.ibm.com>
2019-04-16 17:01:13 +01:00
Adam Williamson
bd4edb0da7 GTK+ 3.24.5 needle retake
New GTK+ changed something so the background of many interface
elements is a slightly lighter grey, this broke a bunch of
needles. Here are the retakes. Includes one not-strictly-related
SDDM update and a rename of the one @lruzicka did to match the
others.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-02-06 13:27:30 -08:00
Adam Williamson
ad29a8fcde Great Stale Needle Cleanup 2018: anaconda
It's my second least favorite day of the year again: Stale
Needle Cleanup Day!

This should get rid of all anaconda needles that definitely are
not being used any more. A few borderline cases (where I'm not
100% sure if they may still be useful in odd corner cases, like
running universal tests on non-server images, and runs outside
of the US, and stuff) are kept around.

Cleanup of all non-anaconda needles will be in the next commit.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-12-17 16:30:57 -08:00
Adam Williamson
5d501433e8 Add another cantarell111 needles (for non-x86_64 arches)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-09-26 23:15:11 -07:00
Adam Williamson
e9785f5e5a Add a few more Cantarell 0.111 needles
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-09-16 08:44:38 -07:00
Adam Williamson
1034104526 Add a large chunk of needles for Cantarell 0.111
This should cover nearly everything, I hope.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-09-10 02:44:50 -07:00
Adam Williamson
b1140dafde Same workaround as last commit, for device type
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-06-15 14:34:56 -07:00
Adam Williamson
9b7a9c9cd8 Work around a partition scheme selection bug on aarch64
Sometimes on aarch64 clicking the partition scheme drop-down
just doesn't seem to make the menu appear, instead the button
goes active but that's all. It's very unlikely we'll be able
to track down why as this doesn't happen in manual testing on
aarch64 (according to @pwhalen), so instead let's just work
around it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-06-15 13:40:13 -07:00
Adam Williamson
22dc620fa7 Add a couple more cantarell 101 needles (ppc64)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-04-25 15:16:08 -07:00
Adam Williamson
669d0e739b Another cantarell101 needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-03-16 13:12:24 -07:00
Adam Williamson
7643357397 Another cantarell101 needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-03-16 13:10:06 -07:00
Adam Williamson
fa73d2b8be Initial dump of Cantarell 100 / 101 needles
There will be more to come, but I want to push these out and go
to sleep.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-03-16 04:44:17 -07:00
Adam Williamson
2e4a447432 Narrow device_type needle area to fix match
In the most recent Rawhide compose, anaconda has changed how it
names volume groups (again), and now the VGs in openQA installs
have rather longer names. This winds up causing a problem for
this needle: the column where the 'Device Type' dropdown is
placed actually gets narrower (because the column to the right,
which has the volume group name in it, is wider), and so the
dropdown box is narrower, and the arrow protrudes into the area
which the needle expects not to have an arrow in it. So, let's
make the match area slightly narrower.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-01-15 13:21:40 -08:00
Adam Williamson
b50c4932db Add variant device_sda_selected needle for #1530410
Rawhide has a bit of a problem where its 'description' of an
iSCSI disk is so long that the other columns that should appear
in the CONFIGURE MOUNT POINT dialog don't. This means our
device_sda_selected needle doesn't match, because the column
where 'sda' should appear isn't visible.

So add a soft-fail needle to cover this case; we know what the
description for the disk that's 'sda' in this case looks like,
so match on that.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-01-03 18:34:56 -08:00
Adam Williamson
672d60a840 Clean up a whole bunch of unused needles
Time for an annual spring clean. Based on the admin UI's list
of needles that haven't been matched for a long time, but with
some manual tweaking (some are actually still needed).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2018-01-02 16:13:47 -08:00
Michel Normand
2fceef0eb3 Add "PPC PReP Boot" filesystem for PowerPC blivet tests
This is required because anaconda is still checking for it
even if not mandatory. Already tracked by bug
https://bugzilla.redhat.com/show_bug.cgi?id=1172791

Signed-off-by: Michel Normand <normand@linux.vnet.ibm.com>
2017-09-06 08:43:04 +02:00
Jan Sedlák
888f94746f fix changed blivet add button 2017-06-26 13:23:02 +02:00