Commit Graph

480 Commits

Author SHA1 Message Date
Adam Williamson
b455e04188 Add new cockpit needles for 205
The cockpit UI went all GRIMDARK so we need a couple of new
needles.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-16 17:10:28 -07:00
Adam Williamson
5f38971a78 Add some new variant layout indicator needles
Once again, the text is at a slightly different height to the
needles we already have. I do not know why this sometimes
happens. It's a mystery.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-16 16:34:55 -07:00
Adam Williamson
b55782358d Don't check version or pre-release note on banners
This reduces the coverage of the identification test a bit but
also *substantially* simplifies it. We run into a ton of problems
when we try to check the version and prerelease text on screens
where it appears on banners:

* The banners differ between variants
* The pre-release text is translated
* The banners have gradients so for RTL languages, even if some
  text is untranslated (e.g. 'Fedora 31') it appears on a
  different background color than on LTR languages
* The prerelease text is dark red; if it appears on a dark blue
  area of the banner this can trigger an os-autoinst needle
  comparison bug: https://progress.opensuse.org/issues/56822

All of this together means we wind up continually fighting these
checks and we have a whole forest of needles just for them, and
it doesn't seem worthwhile. So let's drop all the places where
we were checking version and prerelease on banners, and only
check them in two places where they appear on a grey background,
which avoids most of the problems (we just need one version
needle per release, and one prerelease needle per language).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-16 11:08:24 -07:00
Adam Williamson
205c0c3d97 Add new variant ABRT needle for KDE app test
Font rendering changed.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-10 12:09:41 -07:00
Adam Williamson
6636122f62 New needle for *partly* translated 'install done' Japanese
Now one of the strings we check for is translated, but the other
is not...handle this, again with a workaround needle so the
missing translation triggers a soft fail.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-10-07 11:26:54 -07:00
Lukas Ruzicka
d82f4ecd7f Develop a new test for system updates via Cockpit.
* server-cockpit-updates tests that Cockpit can be used to update the system.
* server-cockpit-autoupdate tests that users can use dnf-automatic for system
updates.
* cockpit functions were removed from utils.pm and put into an extra library
for cockpit - cockpit.pm which all cockpit tests are now using.

Review cockpit.pm

Review autoupdate test.

Review the update test.

Fix typo in cockpit.pm

Add sleep.

Add missing command.

Delete an unused needle.
2019-10-01 16:04:01 +02:00
Adam Williamson
0782f4faf2 Add new akonadi migration agent needle for F31 background
Light blue throwing us off again.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-26 10:24:37 -07:00
Adam Williamson
61f8adefdf Add some new update-related needles for KDE
The new background seems to be throwing us off here. I think
the menu is *very slightly* transparent so the needles usually
work for most Fedora backgrounds as they tend to have a similar
base color, but the 31 one is unusually light.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-19 10:23:21 -07:00
Adam Williamson
6e9a7a57c5 Add several more variant keyboard layout needles for new icon
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-16 12:26:26 -07:00
Adam Williamson
96cf14d555 Add new variant us_rtl layout needle
For RTL languages the keyboard icon and language indicator are
the other way around, so we have different needles even for the
US layout indicator which is otherwise the same in all langs.
This is a variant needle for the new keyboard icon that showed
up in Rawhide recently.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-16 11:32:58 -07:00
Adam Williamson
0f9fd1a76a Add alternative vdb selected needle for new blue checkboxes
This checkbox sometimes renders slightly differently, especially
on non-x86_64. We're not really sure why, but we just add more
needles to handle it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-16 11:23:47 -07:00
Adam Williamson
ea11c8344f Shrink KDE Firefox launcher icon to avoid background issues
Existing one doesn't match if the background is too different,
shrink it to just the center of the icon.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-11 15:12:03 -07:00
Adam Williamson
a1d9b14383 Some more prerelease needle updates 2019-09-11 15:01:44 -07:00
Adam Williamson
dc8ed1c9ba Yet more pre-release check fixes
We need another needle for French installs, and we need to use
ISO_URL for checking the ISO file name if ISO isn't set.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-11 14:31:54 -07:00
Adam Williamson
29a5e0bda7 Add variant 'permission denied' needle
For some reason, occasionally the 'm' character looks slightly
different. I have no idea why.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-11 10:47:13 -07:00
Adam Williamson
be1baa90e5 Update main hub needles for changed keyboard icon
Someone is pretty OCD about this damn keyboard icon, it just
keeps getting changed...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-09 11:44:28 -07:00
Adam Williamson
a3c207a045 Add a few more 'blue button' needle variants
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-05 18:09:14 -07:00
Adam Williamson
23ad087ed3 Add blue button variants for workstation_selected needle too
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-05 17:28:41 -07:00
Adam Williamson
cf6f8db3e7 Add new variant 'minimal selected' needle for radio button change
Radio buttons look different with recent GTK, it seems.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-05 16:14:59 -07:00
Lukas Ruzicka
1d6e2aaa19 Add changed needle that failed for cyrillic test. 2019-09-05 17:10:50 +02:00
Adam Williamson
df88196357 Add F31 background needle
Now we have the backgrounds!

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-09-04 12:44:55 -07:00
Adam Williamson
6d68b2c6fa Add yet another prerelease note needle
Seriously starting to think about separating out this ident
stuff into a separate test case :/

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-29 17:49:27 -07:00
Adam Williamson
53778fe494 Add language tags to the new language prerelease note needles
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-28 14:46:23 -07:00
Adam Williamson
b19e6bbda7 Add some needles for pre-release note translations
These showed up because I did a manual universal flavor run on
an ISO today, but we'll need them as soon as we do a candidate
compose too.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-28 14:14:57 -07:00
Adam Williamson
2cb224a184 Make generic topbar needle narrower
We did this for the orange (Server) one already, but not the
blue generic one.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-28 14:07:33 -07:00
Adam Williamson
26308a6b47 Update rarely-used installer ext4/xfs partitioning needles
These only get used when we run universal tests on a non-Server
image, which is pretty rare (these days, as Server DVD is a
critical image and composes fail if it fails, it only really
happens when we do it manually for some reason, like I did
today). So they get stale and aren't updated for font rendering
changes and stuff. As I said I had to do a run like that today,
so I had to update all these needles...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-28 14:04:13 -07:00
Adam Williamson
4bb89046d3 Add one more updated GNOME app test needle
'Simple Scan' renamed itself.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-26 17:51:20 -07:00
Adam Williamson
28443abf04 Add new variants for GNOME app start/stop tests
Several apps changed icon.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-26 16:29:37 -07:00
Adam Williamson
77a6c0ed4d Add yet another variant 'vdb selected' needle
This screen often seems to show slight variances in color,
really not sure why.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-26 16:28:44 -07:00
Lukas Ruzicka
022865ab9f KDE app start/stop: launch apps with commands not menus
This is doing slightly less to exercise the launcher menus and see
whether icons appear or disappear, but it's much faster and more
reliable. We do still use menu launch for one app, just to check
the mechanism works in general.
2019-08-23 12:41:49 -07:00
Adam Williamson
06e26e9721 Narrow topbar and add new version needle to cover languages
The top bar differs in non-English languages - for RTL the
version ident is on the left (so background is different), and
the width of the area with no text differs depending on the
length of the translations.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-21 14:36:53 -07:00
Adam Williamson
23552c777d Add a new KDE desktop update needle variant
Little black bits on the icon are in a different place now. Why,
I do not know.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-21 11:55:07 -07:00
Adam Williamson
ecfc9a5234 Add new variant abrt_runs needle for KDE app tests
Text rendering changed.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-21 10:44:25 -07:00
Adam Williamson
2f51f3ef20 Add PXE boot test
This adds a whole wodge of stuff to support_server to make it
act as a PXE server, then adds a new test which boots from PXE
and so should hit the PXE server. We use the NFS install repo as
that can be relied on to work for a support_server install.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-20 18:17:57 -07:00
Adam Williamson
0d66b4bbcd Add various new non-English language needle variants
Seems like there's been a change to freetype or something, text
rendering changed in all of these. Note there's one workaround
needle for an untranslated message in Japanese.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-19 19:03:57 -07:00
Adam Williamson
bc26017d84 Add needles for new anaconda icon
It's new!

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-19 17:36:41 -07:00
Adam Williamson
ca0f772120 Add some new variant needles for anaconda text changes
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-16 12:35:52 -07:00
Adam Williamson
469a1395d0 Revise desktop background checks
Split this out of install_default, because it really is not a
part of that test and we do not want that test to fail because
the desktop background is wrong. Make it its own test module
and test suite instead. Don't do it on Rawhide, because we
really can't assert anything worthwhile about Rawhide at the
moment at least (this means the test runs but is a no-op and
will always pass on Rawhide, unfortunately). Move the needles
to a more appropriate location (this has nothing to do with
anaconda) and use 'background' not 'wallpaper' naming (that's
the name we use elsewhere in the project, e.g. package names).
Also, run the test on updates, and add an F29 needle for this
purpose.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-14 14:30:25 -07:00
Adam Williamson
d9c45454b2 Clean up wallpaper needles a bit
The backgrounds we have are F30 backgrounds, not F31: there are
no F31 backgrounds yet, F31 images are using F30 backgrounds
(which is a bug we should file). Also we really only need one
F30 background needle to match both KDE and GNOME if we pick a
sensible area of the screen to use, and let's use one that has
a bit more contrast for safer matching.

Note: F30 background is *meant* to be animated, but in fact
neither GNOME nor KDE seems to use the animated version by
default. Which makes our lives easier! Sucks for whoever put in
the work to animate it, though.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-08-14 13:17:35 -07:00
Lukas Ruzicka
d06b30e8dc Add new testcases and methods for release identification. 2019-07-30 15:45:02 -07:00
Adam Williamson
b31422d188 Add some new KDE app test needle variants
Underlines on button text seem to have moved.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-07-30 15:43:42 -07:00
Adam Williamson
c1393ec2de Add missing akonadi_migration_agent needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-07-30 15:43:04 -07:00
Adam Williamson
3fe3fc453c Add new Cockpit log detail variant needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-07-25 14:11:12 -07:00
Adam Williamson
be12f07900 GNOME apps: dismiss new LibreOffice 'tip of the day' if it shows
Also add a new needle for Impress startup.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-07-23 20:15:24 -07:00
Adam Williamson
17438386c1 Add new 'install done' needle
Text on the button was changed in Rawhide.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-07-23 13:16:04 -07:00
Adam Williamson
9078bca871 cockpit: update needles for 198, rejig Services page handling
Cockpit 198 comes with a UI overhaul, so almost all needles
need an update.

The 'auditd' service is no longer on the first page. To make
this less fragile (at the cost of not testing that clicking on
a service actually opens the detail page *for that service*,
tweak the needles to just look for *any* running service, click
on it, and check we got to a 'details' page. We also redo the
existing needles for this design.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-07-10 11:43:03 -07:00
Adam Williamson
0c650ce424 Add new anaconda warning bar needle (color changed)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-07-09 22:32:26 -07:00
Adam Williamson
0160b4dd4c Add yet another keyboard layout needle variant
Different distance between the text and the arrow. I dunno why.
GNOME is a mystery sometimes.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-07-09 22:31:30 -07:00
Adam Williamson
de4a58438b Use existing needle for dismissing KDE update notification
@lruzicka added this to the KDE app tests in 71c4e273, but there
was no need for a new needle as I'd already done the same thing
in the desktop updates tests; let's just use the same needle.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-07-03 08:39:01 -07:00
Lukas Ruzicka
71c4e273ef Click off updates notification if it appears. 2019-07-03 10:52:47 +02:00