Commit Graph

84 Commits

Author SHA1 Message Date
Adam Williamson
2a7787c1da Update lots of needles for os-autoinst behaviour change
Recent git os-autoinst no longer downsamples screenshots as far
as it did before comparison. This makes a lot of needles where
colors have changed slightly no longer match, so they all needed
updating.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-07-19 13:03:11 -07:00
Adam Williamson
1cf779fa20 Update Cockpit login needle for "Fedora Linux" change
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-07-14 14:11:52 -07:00
Adam Williamson
2961a06dbd Update cockpit auto-updates needle
Radio button style change.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-06-08 16:36:20 -07:00
Adam Williamson
b1e28d4e77 Update Cockpit log entry detail needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-05-03 15:04:02 -07:00
Adam Williamson
1a613fc8c2 Restore the cockput updated "Reboot" needle
OK, so sometimes we have a Reboot button, sometimes a Restart
button, sometimes both, but never *always* one or the other. So
we need both needles. Sigh.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-04-30 14:37:35 -07:00
Adam Williamson
efe793a465 Update some Cockpit needles for cockpit 243
There's a spurious warning on the Updates page, but we don't
want to fail tests for non-related updates on that, and I've
already reported it so it should get fixed.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-04-29 15:32:37 -07:00
Adam Williamson
533264900f Replace cockput updated 'reboot' needle with 'restart' needle
The 'reboot' button isn't always there in this case, it seems,
but the 'restart services' one is more likely to be. So let's
switch.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-04-22 14:52:52 -07:00
Adam Williamson
d6ac2126e2 Add another Cockpit log entry detail needle
Stupid Firefox survey means the thing we usually check isn't
always on the screen. This one checks for PRIORITY.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-04-22 14:51:53 -07:00
Adam Williamson
805d303511 Add alternative cockpit "updated" needle
When we have to restart Cockpit during the update, we don't get
the usual "successful" screen after logging back in, we'll have
to match on something indicating an update did happen. I wanted
to use the little icon next to the package count but it seems to
have some kind of problem with anti-aliasing or something, I've
created two needles for it and neither matched on the next run
of the test. So let's match on this "reboot needed" text instead,
I hope it'll always be there when we hit this case.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-23 16:35:24 -07:00
Adam Williamson
1b6181b4af Update Cockpit log entry details needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-03-12 18:36:33 -08:00
Adam Williamson
548e350e47 Update cockpit updates updated needle again
Update update update. Update. Update!

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-02-22 13:54:16 -08:00
Adam Williamson
1cd0529785 cockpit: set log priority to 'info' before looking for entry
We finally saw a test where there were *no* errors logged by the
time Cockpit reached the log screen, so there were no entries to
click. Let's just make the test set log level to info before
looking for entries - I prefer this to 'click entry if found,
otherwise change log level' as that's twice as many branches to
look after. Of course, it means the warning triangle entry needle
is useless now :(

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-02-19 10:24:50 -08:00
Adam Williamson
619f64b353 Update cockpit update needles for Cockpit 238
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-02-18 15:26:22 -08:00
Adam Williamson
da653dfd22 Yet another Cockpit log entry needle
Let's just match on the warning triangle. Hopefully that stays
consistent.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-02-17 17:23:43 -08:00
Adam Williamson
3a3a6ecd2d Add a workaround needle for a cockpit radio button alignment bug
Cockpit 237 has misaligned radio buttons here. We know about the
issue and want the test to not fail on unrelated updates, so let's
make it a soft fail.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-02-10 16:29:16 -08:00
Adam Williamson
670fc8c306 Add another cockpit login screen variant
More space between "Fedora" and the text below it...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-02-05 15:01:02 -08:00
Adam Williamson
845cfca12d Add more cockpit log needle variants
We're getting different log messages these days.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-02-04 14:52:21 -08:00
Adam Williamson
adac5323f0 Update Cockpit log entry needle
We don't always get a smartd error any more, so add one for a
different error that's more consistent ATM.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-01-19 16:07:56 -08:00
Adam Williamson
fdc4a51e2a Add new Cockpit login needle using the text box area
The background seems to be different in different tests, even
the reduced area I tried most recently seems to be different in
some runs. So let's just match in the text area instead. This
captures some "Fedora" text so it should still notice if branding
is broken.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-01-15 16:52:40 -08:00
Adam Williamson
d0a53abda0 Update cockpit log entry details screen for Cockpit 235
The font of the identifier text got a bit smaller. I think it
looks kinda bad now, but it's not an outright bug, so just
living with it. I did file an upstream issue:
https://github.com/cockpit-project/cockpit/issues/15111

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2021-01-07 11:16:13 -08:00
Adam Williamson
1f757325a6 Reduce login_cockpit needle match area
There seem to be some weird shenanigans going on with the pipe
bit here (it looks different on different test runs? what?) so
let's just match on the plain grey area. Should still be enough.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-12-15 16:52:35 -08:00
Adam Williamson
dc86780a13 Update Cockpit FreeIPA "join complete" needle for new domain
Left this out of previous commit, oops.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-12-15 14:45:02 -08:00
Adam Williamson
0de57180ee Update cockpit needles and autoupdate test for 234
Auto-update time is shown as '6:00' not '06:00' now, so trim the
needle to match both.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-12-15 11:20:43 -08:00
Adam Williamson
649fcc51f1 Cockpit 232 fixes
Update a needle with slightly different text rendering, and add
a workaround to hit tab three times rather than once on entering
the "Join a domain" screen, see
https://github.com/cockpit-project/cockpit/issues/14895 .

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-11-11 12:55:42 -08:00
Adam Williamson
5e5dbac636 Add updated cockpit_updates_reconnect needle
We only use this one rarely. Font rendering on it changed at
some point.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-10-07 14:42:26 -07:00
Adam Williamson
f69e627dc3 Update some cockpit needles for version 228
They dropped Title Case from various things, some of which we
have needles for.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-09-16 12:27:54 -07:00
Adam Williamson
8e794a6c30 Update a Cockpit needle that changed in the latest release
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-09-03 15:13:54 -07:00
Adam Williamson
0220334a57 Drop stray match area from cockpit_leftbar_scroll
That's not supposed to be there...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-08-25 16:08:51 -07:00
Adam Williamson
078e3f212e Update Cockpit domain needles for Cockpit 224
Some font changes or something.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-07-22 18:32:05 -07:00
Adam Williamson
a58ca4676d Update one more needle for new cockpit
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-05-30 14:18:12 -07:00
Adam Williamson
2e21cfac15 Update cockpit needles and select_cockpit_update for 220
In Cockpit 220, the Updates entry is off the bottom of the screen
so we need to scroll the left bar down before we can click it.
Also update some other needles.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-05-30 10:27:20 -07:00
Adam Williamson
c7031448ec Update Cockpit 'main screen' needle
It seems like sometimes the machine ID is off the bottom of the
screen now, so let's just match on the section title instead.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-05-04 17:24:31 -07:00
Adam Williamson
664d5d559f Update cockpit 'services entry' needle for new release
Unfortunately only the entry name is clickable now so we can't
have a 'generic' needle that'll work for any service.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-29 12:16:26 -07:00
Adam Williamson
49c8d46744 Update some Cockpit button needles for 217
Seems like text rendering on buttons changed a bit.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-15 11:40:45 -07:00
Adam Williamson
21eea18562 Add a needle check script, remove some unused needles
I call this...The @lruzicka Catcher!

It's a script that checks for needles that aren't actually used
anywhere. It also checks for cases where we have a needle JSON
file but no image, or an image file but no JSON file (and wipes
one case of the latter). It also adds a run of the script to tox
so we get it in CI.

You could make this script a lot more elaborate if you like, by
being fancier about parsing the test code and templates, but I
don't think it's really warranted, I think it just needs to be
'good enough'. It's not the end of the world if it misses the
odd thing or the whitelisting goes stale.

Quite a lot of the removed needles are remnants of different
approaches to app start/stop testing which weren't caught in the
initial PR review. The short-name partitioning ones are odd; they
were introduced in the commit that moved needles into subdirs,
but at least some of them don't actually appear to be moves. They
may have been non-tracked files Josef had lying around that got
into the commit by mistake, or they may just be old needles we
really used at some point but aren't using any more.
reclaim_space_second_partition was introduced as part of the
shrink test (along with reclaim_space_first_partition) but was
never actually used by that test - I guess, again, the test got
re-written during review but we forgot to remove the needle. We
rejigged user creation to use tab presses not a needle match a
while back, which made user_creation_password_input unnecessary.
The various cockpit_updates_* needles are I think remnants of
rewrites of the cockpit update tests that again were missed in
PR review, the tests as merged never used them.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-08 16:55:46 -07:00
Adam Williamson
dc7b7a7241 Great Needle Cleanup 2020
Remove a bunch of needles that have not been used for some time,
plus a few workarounds that are similarly stale.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-20 14:02:10 -07:00
Adam Williamson
e2df109539 Update cockpit_updates_check needle
Button changed a bit (likely Patternfly 4 changes).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-18 12:21:18 -07:00
Adam Williamson
c18a0d5008 Update cockpit 'updated' needle (check mark got thinner)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-18 11:57:33 -07:00
Adam Williamson
80c54d5491 Add cockpit_updates and remote_logging tests to updates
Again, no reason not to run these on updates. Includes adding
oldcantarell versions of several needles for current cockpit,
as they're needed for the tests to pass. Also tweak a couple of
needles to avoid false matches (add more empty space).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-24 21:03:41 +01:00
Adam Williamson
776d31bd5b Update various Cockpit needles for 211
Note we need two variants of most of these, one for Rawhide with
Cantarell 0.201, one for F30/F31 with Cantarell 0.111.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-24 15:18:27 +01:00
Adam Williamson
f11a57f01a Drop match level on cockpit main needle
New cockpit hits 95%, let's just drop the required %age rather
than make a new needle.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-24 12:53:14 +01:00
Adam Williamson
c922226d7c Add a variant Cockpit join_complete needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-20 13:36:58 +01:00
Adam Williamson
13da4f2d26 Add another new Cockpit join complete needle
This one from ppc64le test. The difference between all the
recent needles here is the amount of white space between the
'Domain' and 'domain.local'. I don't want to change it to two
match areas as there's a chance we may get a false positive
match when the join actually failed (it may match on 'Domain'
in the right place, and 'domain.local' somewhere else just as
part of the system's hostname). I suppose if this keeps happening
we could try two match areas but include some white space to the
left of 'domain.local' to avoid matching on it as part of the
hostname...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-15 15:22:34 +00:00
Adam Williamson
1e025c0b27 Tweak cockpit main needle to work on ppc64 too
We don't get a CPU model on ppc64, we get a machine ID everywhere
(I hope).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-15 12:16:33 +00:00
Adam Williamson
aa0edd263b Update Cockpit 'realm join complete' needle for new cockpit
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-08 17:28:49 -08:00
Adam Williamson
3998e9c86c Drop the 'cockpit join progress' needle match
The text we used to get has been replaced with a spinner, which
is difficult and unreliable to match on. This match was only
here to make the test fail a bit faster if it was broken, so
let's just live without it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-08 15:32:29 -08:00
Adam Williamson
7234729949 Drop use of logs_severity needle from Cockpit test entirely
This match keeps giving us problems, and now I look at the test
again, there is actually no need for it at all. Clicking it
doesn't do anything, and we already confirm that we're on the
right page at the next step, where we look for a log entry and
click on that - that will fail if we aren't actually on the
Logs page.

I don't remember what Cockpit used to look like when we first
put this line and needle in, presumably there's a reason we had
them, but they're clearly unnecessary now.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-03 09:27:48 -08:00
Adam Williamson
5be282c744 Drop cockpit_logs_severity match requirement again
I am so freaking pissed off with these bizarre 'not quite'
matches, what the hell is Firefox doing

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-12-20 09:04:52 -08:00
Adam Williamson
a88d7b701e Add another Cockpit realm join complete button
Whitespace changed, sigh...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-12-18 23:21:15 -08:00
Adam Williamson
f9f2d08263 Add new cockpit autoupdate on needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2019-12-18 12:36:57 -08:00