Commit Graph

582 Commits

Author SHA1 Message Date
Lukáš Růžička
f3d6a9574c Add desktop login test, revise and rename check_desktop
This adds a new test that implementsQA:Testcase_desktop_login
on both GNOME and KDE.

While working on this, we realized that the "desktop_clean"
needles were really "app menu" needles, and for KDE, this was
a duplication with the new "system menu" needles, because on KDE
the app menu and the system menu are the same. So I (Adam)
started to de-duplicate that, but also realized that "app menu
button" is a much more accurate name for these needles, so I was
renaming the old desktop_clean needles to app_menu_button. That
led me to the realization that "check_desktop_clean" is itself a
dumb name, because we don't (at least, any more, way back in the
mists of time we may have done) do anything to check that the
desktop is "clean" - we're really just asserting that we're at a
desktop *at all*. While thinking *that* through, I *also* realized
that the whole "open the overview and look for the app grid icon"
workaround it did is no longer necessary, because GNOME doesn't
use a translucent top bar any more. That went away in GNOME 3.32,
which is in Fedora 30, our oldest supported release.

So I threw that away, renamed the function "check_desktop",
cleaned up all the needle naming and tagging, and also added an
app menu needle for GNOME in Japanese because we were missing
one (the Japanese tests have been using the "app grid icon"
workaround the whole time).
2020-04-17 17:27:04 -07:00
Adam Williamson
49c8d46744 Update some Cockpit button needles for 217
Seems like text rendering on buttons changed a bit.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-15 11:40:45 -07:00
Adam Williamson
c914b1ad88 Update F32 background needles
This adds a needle for the 'day' background from 32.1.1, which
is the non-animated default, and renames the needle for the
background from 32.0.0 to 'old' as it's no longer present at all
in the new build. Depending on whether animation actually works
after the update we may later need to add needles for the other
images plus possibly some transition needles too. Sigh.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-15 11:39:04 -07:00
Adam Williamson
417b876ead Add F31 variant Terminal app run needle
Needed for F31 respin tests.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-14 12:12:57 -07:00
Adam Williamson
19677de20a Add variant anaconda keyboard layout needles
There's this weird thing where the vertical alignment of the
language name in the keyboard layout indicator is sometimes
different. I never can figure out why. It may be to do with
presence or absence of the pre-release indicator.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-14 12:07:06 -07:00
Adam Williamson
610572f8a0 Add new variant SDDM input needle
Looks like a kerning difference or something.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-14 12:05:33 -07:00
Adam Williamson
21eea18562 Add a needle check script, remove some unused needles
I call this...The @lruzicka Catcher!

It's a script that checks for needles that aren't actually used
anywhere. It also checks for cases where we have a needle JSON
file but no image, or an image file but no JSON file (and wipes
one case of the latter). It also adds a run of the script to tox
so we get it in CI.

You could make this script a lot more elaborate if you like, by
being fancier about parsing the test code and templates, but I
don't think it's really warranted, I think it just needs to be
'good enough'. It's not the end of the world if it misses the
odd thing or the whitelisting goes stale.

Quite a lot of the removed needles are remnants of different
approaches to app start/stop testing which weren't caught in the
initial PR review. The short-name partitioning ones are odd; they
were introduced in the commit that moved needles into subdirs,
but at least some of them don't actually appear to be moves. They
may have been non-tracked files Josef had lying around that got
into the commit by mistake, or they may just be old needles we
really used at some point but aren't using any more.
reclaim_space_second_partition was introduced as part of the
shrink test (along with reclaim_space_first_partition) but was
never actually used by that test - I guess, again, the test got
re-written during review but we forgot to remove the needle. We
rejigged user creation to use tab presses not a needle match a
while back, which made user_creation_password_input unnecessary.
The various cockpit_updates_* needles are I think remnants of
rewrites of the cockpit update tests that again were missed in
PR review, the tests as merged never used them.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-08 16:55:46 -07:00
Adam Williamson
8b5be61971 Update a few GNOME app needles that seem to have changed
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-02 20:27:01 -07:00
Adam Williamson
ea397783d5 Update French 'accept fate' needle
Verb changed.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-02 20:17:42 -07:00
Adam Williamson
6b5e933ff4 Update error_report needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-04-02 20:16:02 -07:00
Lukáš Růžička
a54f020118 Revert "Fix the Konqueror test - handle Locations dialogue."
This reverts commit d784bf54ca.

It turned out that Locations are not connected to Konqueror
at all. The reason why the test is failing is that the
application has been removed to limit the number of
web browsers.
2020-03-31 09:23:13 +02:00
Lukáš Růžička
d784bf54ca Fix the Konqueror test - handle Locations dialogue. 2020-03-26 10:57:00 +01:00
Adam Williamson
dc7b7a7241 Great Needle Cleanup 2020
Remove a bunch of needles that have not been used for some time,
plus a few workarounds that are similarly stale.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-20 14:02:10 -07:00
Adam Williamson
e2df109539 Update cockpit_updates_check needle
Button changed a bit (likely Patternfly 4 changes).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-18 12:21:18 -07:00
Adam Williamson
c18a0d5008 Update cockpit 'updated' needle (check mark got thinner)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-18 11:57:33 -07:00
Lukáš Růžička
d19cf9553e Reneedle the Gnome Application StartStop tests. 2020-03-18 18:06:34 +01:00
Adam Williamson
608209499d Add Fedora 33 IoT ident needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-16 14:17:31 -07:00
Adam Williamson
30f5eae3ac Add another kernelorg_patch needle
I think what happens here is the kerning and/or subpixel hinting
changes depending on the column position, and the column position
keeps changing as upstream releases new versions on different
dates and stuff. Hopefully eventually we'll have enough needles
to cover all possibilities...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-13 14:08:05 -07:00
Adam Williamson
ff1d75050e Update French pre-release note needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-12 09:19:04 -07:00
Adam Williamson
948e5f23ae Add missing tags to Russian prerelease note needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-12 08:50:05 -07:00
Lukáš Růžička
0557af9a2d Add needle to cover a changed prerelease note for Russian. 2020-03-12 16:17:28 +01:00
Adam Williamson
00f1241318 Update French 'install done' needle
Translation was updated.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-10 16:04:45 -07:00
Adam Williamson
513f0a23f4 Add F32 background needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-06 15:33:15 -08:00
Adam Williamson
e5feab11f7 Update iSCSI-related needles for font changes
This test has been failing forever, now the bug is fixed, we need
to update the needles for font changes...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-03-04 09:15:00 -08:00
Adam Williamson
884f71bb81 Revert "Workaround #1805553 (single disk not selected as install target)"
This reverts commit adf3f91818.
The bug has been fixed in anaconda, so we can drop this, which
is good as it has timing issues producing false positives on
Rawhide...
2020-02-26 14:30:08 -08:00
Adam Williamson
2c236ef16a Update GNOME Software 'Download' needle for changed kerning
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-26 11:34:21 -08:00
Adam Williamson
95e6ddc896 Update blivet vdb selected needle yet again
I do not know why this needle seems so troublesome...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-25 23:02:29 -08:00
Adam Williamson
da28938572 Update prerelease note needle for font rendering change
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-25 22:59:14 -08:00
Adam Williamson
adf3f91818 Workaround #1805553 (single disk not selected as install target)
Rawhide seems to have developed a bug where a single disk is no
longer automatically selected as the install target when you
enter the INSTALLATION DESTINATION spoke. We need to work around
this (but register it as a soft failure).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-20 17:41:34 -08:00
Adam Williamson
54afe23572 Update an iSCSI needle for font changes
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-20 12:14:35 -08:00
Adam Williamson
18c818da7d Update overview app grid needle (more GNOME icon changes)
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-20 09:57:04 -08:00
Adam Williamson
5300c35106 Update desktop update notification only needle
More GNOME icon changes.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-20 09:53:30 -08:00
Adam Williamson
deab03a80d Update another partitioning needle for GTK+ widget changes
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-20 08:12:16 -08:00
Adam Williamson
2c33325595 Add IoT 32 identification needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-20 08:11:52 -08:00
Adam Williamson
7fd23dacea Update GDM input needles for non-English languages
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-19 10:37:51 -08:00
Adam Williamson
8d14addd18 Update two more anaconda needles for smaller radio buttons
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-19 10:36:59 -08:00
Adam Williamson
9f331dbbe3 Update authentication required GNOME needle
They took away the icon, so now we can only match on text :(

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-19 10:35:47 -08:00
Adam Williamson
2466cf53bd Update Firefox launcher needle
Looks like GNOME is rendering it a bit smaller now.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-19 10:35:06 -08:00
Adam Williamson
dde0113fb1 Update KDE 'no notifications' needle
Probably a transparency thing.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-19 09:47:36 -08:00
Adam Williamson
f7a9625b55 Update GDM input needle
GNOME reworked this widget a bit.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-19 09:47:13 -08:00
Adam Williamson
2fda57482b Update anaconda needles for icon/widget changes
Seems some changes to symbolic icons and widgets have happened
in GTK+ or something, this updates anaconda needles for them.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-19 09:46:35 -08:00
Adam Williamson
0f8f6082eb Enable IoT testing with install and base tests
IoT is becoming a release-blocking edition for F32, so we should
be testing it for sure. We may add specific tests, but for now
let's run the install and base tests on it.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-17 08:36:55 -08:00
Adam Williamson
b09936ba0a Update 'select_disk_1' needle
Some kinda font rendering change or something.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-17 08:33:57 -08:00
Adam Williamson
e5728beada Add version 32 identification needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-14 16:53:31 -08:00
Adam Williamson
80ddb89f91 Fix firefox addon_success needle
I updated this last month without looking closely enough; one of
the matches was bogus. We now don't seem to get the 'added to
Firefox' popup any more, so we can't match on it, but I guess we
can match on the 'remove' button as an indicator that the add
worked.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-02-07 12:10:21 -08:00
Adam Williamson
80c54d5491 Add cockpit_updates and remote_logging tests to updates
Again, no reason not to run these on updates. Includes adding
oldcantarell versions of several needles for current cockpit,
as they're needed for the tests to pass. Also tweak a couple of
needles to avoid false matches (add more empty space).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-24 21:03:41 +01:00
Adam Williamson
12b0fb04dc Update a ppc64le-only blivet needle for Cantarell 0.201
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-24 15:20:54 +01:00
Adam Williamson
776d31bd5b Update various Cockpit needles for 211
Note we need two variants of most of these, one for Rawhide with
Cantarell 0.201, one for F30/F31 with Cantarell 0.111.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-24 15:18:27 +01:00
Adam Williamson
f11a57f01a Drop match level on cockpit main needle
New cockpit hits 95%, let's just drop the required %age rather
than make a new needle.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-24 12:53:14 +01:00
Adam Williamson
c922226d7c Add a variant Cockpit join_complete needle
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2020-01-20 13:36:58 +01:00