testing/os-autoinst-distri-rocky-migrated
10
0
Fork 0
Code Issues 12 Pull Requests 1 Packages Projects Releases Wiki Activity

[9.0 Release Issues] Update package_set needles for 9.0 styling #110

Merged
akatch merged 2 commits from package_installer_sources into 9.0_release_fixes 2022-06-19 01:26:14 +00:00
Conversation 2 Commits 2 Files Changed 17 +144
akatch commented 2022-06-17 19:39:11 +00:00 (Migrated from github.com)
Copy Link

Description

This PR updates needles for all of the package groups listed in the Package Selection spoke. These updates reflect the new GUI styling in 9.0.

Related to #103 .

How Has This Been Tested?

This PR includes updates to templates.fif.json so please be sure to run fifloader.py:

./fifloader.py --clean --load templates.fif.json
 openqa-cli api -X POST isos ISO=Rocky-9.0-RC1-x86_64-boot.iso ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=9.0 BUILD=-boot-iso-$(date +%Y%m%d.%H%M%S).0 GRUB="inst.repo=https://dl.rockylinux.org/stg/rocky/9/BaseOS/x86_64/os/ inst.addrepo=AppStream,https://dl.rockylinux.org/stg/rocky/9/AppStream/x86_64/os/ ip=dhcp" TEST=install_package_set_server
 openqa-cli api -X POST isos ISO=Rocky-9.0-RC1-x86_64-boot.iso ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=9.0 BUILD=-boot-iso-$(date +%Y%m%d.%H%M%S).0 GRUB="inst.repo=https://dl.rockylinux.org/stg/rocky/9/BaseOS/x86_64/os/ inst.addrepo=AppStream,https://dl.rockylinux.org/stg/rocky/9/AppStream/x86_64/os/ ip=dhcp" TEST=install_package_set_graphical-server
 openqa-cli api -X POST isos ISO=Rocky-9.0-RC1-x86_64-boot.iso ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=9.0 BUILD=-boot-iso-$(date +%Y%m%d.%H%M%S).0 GRUB="inst.repo=https://dl.rockylinux.org/stg/rocky/9/BaseOS/x86_64/os/ inst.addrepo=AppStream,https://dl.rockylinux.org/stg/rocky/9/AppStream/x86_64/os/ ip=dhcp" TEST=install_package_set_workstation
 openqa-cli api -X POST isos ISO=Rocky-9.0-RC1-x86_64-boot.iso ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=9.0 BUILD=-boot-iso-$(date +%Y%m%d.%H%M%S).0 GRUB="inst.repo=https://dl.rockylinux.org/stg/rocky/9/BaseOS/x86_64/os/ inst.addrepo=AppStream,https://dl.rockylinux.org/stg/rocky/9/AppStream/x86_64/os/ ip=dhcp" TEST=install_package_set_virtualization-host
 openqa-cli api -X POST isos ISO=Rocky-9.0-RC1-x86_64-boot.iso ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=9.0 BUILD=-boot-iso-$(date +%Y%m%d.%H%M%S).0 GRUB="inst.repo=https://dl.rockylinux.org/stg/rocky/9/BaseOS/x86_64/os/ inst.addrepo=AppStream,https://dl.rockylinux.org/stg/rocky/9/AppStream/x86_64/os/ ip=dhcp" TEST=install_package_set_minimal

These needles should pass the _software_selection module at a minimum. It is expected that workstation and graphical-server will fail at the login screen until #109 is merged.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
# Description This PR updates needles for all of the package groups listed in the Package Selection spoke. These updates reflect the new GUI styling in 9.0. Related to #103 . # How Has This Been Tested? This PR includes updates to `templates.fif.json` so please be sure to run `fifloader.py`: ``` ./fifloader.py --clean --load templates.fif.json openqa-cli api -X POST isos ISO=Rocky-9.0-RC1-x86_64-boot.iso ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=9.0 BUILD=-boot-iso-$(date +%Y%m%d.%H%M%S).0 GRUB="inst.repo=https://dl.rockylinux.org/stg/rocky/9/BaseOS/x86_64/os/ inst.addrepo=AppStream,https://dl.rockylinux.org/stg/rocky/9/AppStream/x86_64/os/ ip=dhcp" TEST=install_package_set_server openqa-cli api -X POST isos ISO=Rocky-9.0-RC1-x86_64-boot.iso ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=9.0 BUILD=-boot-iso-$(date +%Y%m%d.%H%M%S).0 GRUB="inst.repo=https://dl.rockylinux.org/stg/rocky/9/BaseOS/x86_64/os/ inst.addrepo=AppStream,https://dl.rockylinux.org/stg/rocky/9/AppStream/x86_64/os/ ip=dhcp" TEST=install_package_set_graphical-server openqa-cli api -X POST isos ISO=Rocky-9.0-RC1-x86_64-boot.iso ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=9.0 BUILD=-boot-iso-$(date +%Y%m%d.%H%M%S).0 GRUB="inst.repo=https://dl.rockylinux.org/stg/rocky/9/BaseOS/x86_64/os/ inst.addrepo=AppStream,https://dl.rockylinux.org/stg/rocky/9/AppStream/x86_64/os/ ip=dhcp" TEST=install_package_set_workstation openqa-cli api -X POST isos ISO=Rocky-9.0-RC1-x86_64-boot.iso ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=9.0 BUILD=-boot-iso-$(date +%Y%m%d.%H%M%S).0 GRUB="inst.repo=https://dl.rockylinux.org/stg/rocky/9/BaseOS/x86_64/os/ inst.addrepo=AppStream,https://dl.rockylinux.org/stg/rocky/9/AppStream/x86_64/os/ ip=dhcp" TEST=install_package_set_virtualization-host openqa-cli api -X POST isos ISO=Rocky-9.0-RC1-x86_64-boot.iso ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=9.0 BUILD=-boot-iso-$(date +%Y%m%d.%H%M%S).0 GRUB="inst.repo=https://dl.rockylinux.org/stg/rocky/9/BaseOS/x86_64/os/ inst.addrepo=AppStream,https://dl.rockylinux.org/stg/rocky/9/AppStream/x86_64/os/ ip=dhcp" TEST=install_package_set_minimal ``` <!-- Indicate what you have done to test this PR, with screenshots if appropriate --> <!-- At a minimum, please include the following: --> <!-- * The command you used to trigger a passing test --> <!-- * Criteria for a successful test (eg: suite install_minimal@uefi passes) --> These needles should pass the `_software_selection` module at a minimum. It is expected that `workstation` and `graphical-server` will fail at the login screen until #109 is merged. # Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] Any dependent changes have been merged and published in downstream modules
lumarel (Migrated from github.com) requested changes 2022-06-17 21:00:34 +00:00
lumarel (Migrated from github.com) left a comment
Copy Link

Looks like you have to rebase, at least it wants to revert the changes from #108

Looks like you have to rebase, at least it wants to revert the changes from #108
akatch commented 2022-06-17 21:41:45 +00:00 (Migrated from github.com)
Copy Link

Looks like you have to rebase, at least it wants to revert the changes from #108

how about now

> Looks like you have to rebase, at least it wants to revert the changes from #108 how about now
lumarel (Migrated from github.com) approved these changes 2022-06-18 19:12:07 +00:00
lumarel (Migrated from github.com) left a comment
Copy Link

Changes look good to me, only to not that the package sets, graphical server and workstation fail for me in _graphical_wait_login because the username is querty and it searches for test.
(but that might be out of scope here, so non-blocker)

Changes look good to me, only to not that the package sets, graphical server and workstation fail for me in `_graphical_wait_login` because the username is querty and it searches for test. (but that might be out of scope here, so non-blocker)
akatch commented 2022-06-19 01:26:06 +00:00 (Migrated from github.com)
Copy Link

I'm gonna go ahead and say the user is out of scope of this particular issue, we'll surely need to resolve it Eventually™️ though.

I'm gonna go ahead and say the user is out of scope of this particular issue, we'll surely need to resolve it Eventually:tm: though.
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
lumarel
Labels
Clear labels   
priority: critical

This issue or pull request is of utmost priority

  
priority: high

This issue or pull request is of high priority

  
priority: low

This issue or pull request is of low priority

  
priority: medium

This issue or pull request is of medium priority

  
status: abandoned

This issue or pull request has been abandoned or is stale

  
status: duplicate

This issue or pull request already exists

  
status: invalid

This doesn't seem right

  
status: peer review needed

Requires at least one review in order to be merged

  
status: wontfix

This will not be worked on

  
tag: content

Additions to (or modifications of) content in the repository

  
tag: good first issue

Good for newcomers

  
tag: help wanted

Extra attention is needed

  
test suite

This issue or pull request is for test suite changes

  
type: bug

Something isn't working

  
type: documentation

Improvements or additions to documentation

  
type: enhancement

New feature or request

  
type: maintenance

To improve or continue maintenance for something

  
type: question

Further information is requested

No Label
priority: critical
priority: high
priority: low
priority: medium
status: abandoned
status: duplicate
status: invalid
status: peer review needed
status: wontfix
tag: content
tag: good first issue
tag: help wanted
test suite
type: bug
type: documentation
type: enhancement
type: maintenance
type: question
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: testing/os-autoinst-distri-rocky-migrated#110
No description provided.
Delete Branch "package_installer_sources"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?