FEATURE: Add DNF_CONTENTDIR override support #119

Merged
tcooper merged 14 commits from issue_118 into 9.0_release_fixes 2022-07-10 21:05:04 +00:00
tcooper commented 2022-07-06 17:24:10 +00:00 (Migrated from github.com)

Description

This pull request adds support for specifying alternate repository location via DNF_CONTENTDIR variable for post-install tests, resolves incorrect selection of _console* vs. _graphical* login for a handful of tests and provides initial support for proper select of a Rocky major release and use of that to select alternate Getting Started UI based on GNOME version differences in Rocky 8 and Rocky 9+.

A small number of needles are added to support paging through the Gnome 4 Welcome Tour (no code yet to implement/use those needles).

This PR resolves #118

How Has This Been Tested?

openqa-cli api -X POST isos ISO=Rocky-9.0-RC1.1-x86_64-dvd.iso   ARCH=x86_64 DISTRI=rocky FLAVOR=package-set VERSION=9.0 BUILD=-9.0-$(git branch --show-current)-$(date +%Y%m%d.%H%M%S).0 DNF_CONTENTDIR=true

openqa-cli api -X POST isos ISO=Rocky-9.0-RC1.1-x86_64-boot.iso  ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=9.0 BUILD=-9.0-$(git branch --show-current)-$(date +%Y%m%d.%H%M%S).0 GRUB="inst.repo=https://dl.rockylinux.org/stg/rocky/9/BaseOS/x86_64/os/ inst.addrepo=AppStream,https://dl.rockylinux.org/stg/rocky/9/AppStream/x86_64/os/" DNF_CONTENTDIR=true

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
# Description This pull request adds support for specifying alternate repository location via `DNF_CONTENTDIR` variable for post-install tests, resolves incorrect selection of `_console*` vs. `_graphical*` login for a handful of tests and provides initial support for proper select of a Rocky major release and use of that to select alternate Getting Started UI based on GNOME version differences in Rocky 8 and Rocky 9+. A small number of needles are added to support paging through the Gnome 4 Welcome Tour (no code yet to implement/use those needles). This PR resolves #118 # How Has This Been Tested? ```bash openqa-cli api -X POST isos ISO=Rocky-9.0-RC1.1-x86_64-dvd.iso ARCH=x86_64 DISTRI=rocky FLAVOR=package-set VERSION=9.0 BUILD=-9.0-$(git branch --show-current)-$(date +%Y%m%d.%H%M%S).0 DNF_CONTENTDIR=true openqa-cli api -X POST isos ISO=Rocky-9.0-RC1.1-x86_64-boot.iso ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=9.0 BUILD=-9.0-$(git branch --show-current)-$(date +%Y%m%d.%H%M%S).0 GRUB="inst.repo=https://dl.rockylinux.org/stg/rocky/9/BaseOS/x86_64/os/ inst.addrepo=AppStream,https://dl.rockylinux.org/stg/rocky/9/AppStream/x86_64/os/" DNF_CONTENTDIR=true ``` # Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] Any dependent changes have been merged and published in downstream modules
tcooper commented 2022-07-06 17:25:19 +00:00 (Migrated from github.com)

Dang it... don't know where my GPG signing config went. I'll force push signed commits to my branch later today.

Dang it... don't know where my GPG signing config went. I'll force push signed commits to my branch later today.
akatch commented 2022-07-07 05:07:32 +00:00 (Migrated from github.com)

Works to this point. I get failures on _graphical_wait_login with the Welcome Tour as previously.

Works to this point. I get failures on `_graphical_wait_login` with the Welcome Tour as previously.
lumarel (Migrated from github.com) approved these changes 2022-07-09 18:19:32 +00:00
lumarel (Migrated from github.com) left a comment

Beside the one question, this PR fixes so many tests, looks good to me! (and all mentioned tests also run completely without error now!)

Beside the one question, this PR fixes so many tests, looks good to me! (and all mentioned tests also run completely without error now!)
@ -652,2 +639,3 @@
"POSTINSTALL": "_console_login"
"DESKTOP": "false",
"PACKAGE_SET": "server"
}
lumarel (Migrated from github.com) commented 2022-07-09 18:17:56 +00:00

This removes a lot of the tests which Al recently added, is this on purpose?

This removes a lot of the tests which Al recently added, is this on purpose?
akatch (Migrated from github.com) approved these changes 2022-07-10 01:40:44 +00:00
akatch (Migrated from github.com) left a comment

it gives me great pleasure to approve this beautiful PR

it gives me great pleasure to approve this beautiful PR
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: testing/os-autoinst-distri-rocky-migrated#119
No description provided.