Fix `_graphical_wait_login` Test died: Settings key '_welcome_done' is invalid error. #140

Merged

tcooper merged 1 commit from fix/graphical_wait_login into develop

2023-01-07 20:04:08 +00:00

tcooper commented

2022-12-20 18:53:23 +00:00

(Migrated from github.com)

Description

This PR includes a fix for _graphical_wait_login which is broken with recent updates of os-autoinst. Tests with _graphical_wait_login are failing with...

# Test died: Settings key '_welcome_done' is invalid (check your test settings) at /usr/lib/os-autoinst/testapi.pm line 723.

01_install_default_upload_failure_in_graphical_wait_login

This is a cherry pick of 7675e99 Make internal state marker variables upper-case from Fedora openQA resolving this issue. Commit message for brief summary...

Make internal state marker variables upper-case.

We use variables to track test state across modules, sometimes.
As this is all internal to the test logic I didn't bother always
making these variables upper-case, but os-autoinst now treats
lower-case variables as a fatal error, so we have to change.

Signed-off-by: Adam Williamson <awilliam@redhat.com>

How Has This Been Tested?

openqa-cli api -X POST isos ISO=Rocky-9.1-20221214.1-x86_64-dvd.iso ARCH=x86_64 DISTRI=rocky FLAVOR=dvd-iso VERSION=9.1 BUILD=-9.1-dvd-iso-$(date +%Y%m%d.%H%M%S).0

Tests with _graphical_wait_login (eg. install_default_upload@64bit) should pass.

02_install_default_upload_passed_in_graphical_wait_login

In this particular example, passing install_default_upload@64bit opens up the dependency tree for FLAVOR=dvd-iso and exposes the rest of the test tree.

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

# Description This PR includes a fix for `_graphical_wait_login` which is broken with recent updates of os-autoinst. Tests with `_graphical_wait_login` are failing with... ``` # Test died: Settings key '_welcome_done' is invalid (check your test settings) at /usr/lib/os-autoinst/testapi.pm line 723. ``` <img width="1200" alt="01_install_default_upload_failure_in_graphical_wait_login" src="https://user-images.githubusercontent.com/542846/208743927-e31c11e6-582c-4ff0-956e-697f2601bb25.png"> This is a cherry pick of [**7675e99** Make internal state marker variables upper-case](https://pagure.io/fedora-qa/os-autoinst-distri-fedora/c/7675e99fccecbcad0360c0bf1e33e3662b24180d?branch=main) from Fedora openQA resolving this issue. Commit message for brief summary... ``` Make internal state marker variables upper-case. We use variables to track test state across modules, sometimes. As this is all internal to the test logic I didn't bother always making these variables upper-case, but os-autoinst now treats lower-case variables as a fatal error, so we have to change. Signed-off-by: Adam Williamson <awilliam@redhat.com> ``` # How Has This Been Tested? ``` openqa-cli api -X POST isos ISO=Rocky-9.1-20221214.1-x86_64-dvd.iso ARCH=x86_64 DISTRI=rocky FLAVOR=dvd-iso VERSION=9.1 BUILD=-9.1-dvd-iso-$(date +%Y%m%d.%H%M%S).0 ``` Tests with `_graphical_wait_login` (eg. `install_default_upload@64bit`) should pass. <img width="1200" alt="02_install_default_upload_passed_in_graphical_wait_login" src="https://user-images.githubusercontent.com/542846/208743983-b6d3ed5b-54fb-435e-ae73-f86849b3bf6b.png"> In this particular example, passing `install_default_upload@64bit` opens up the dependency tree for `FLAVOR=dvd-iso` and exposes the rest of the test tree. # Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] Any dependent changes have been merged and published in downstream modules

lumarel (Migrated from github.com) reviewed 2022-12-20 18:53:23 +00:00

AlanMarshall (Migrated from github.com) approved these changes 2022-12-23 00:10:58 +00:00

AlanMarshall (Migrated from github.com) left a comment

I tested this change using ISO=Rocky-9.1-20221214.1-x86_64-dvd.iso FLAVOR=dvd-iso on f36 before the patch, f36 after the patch and f37 after the patch, with identical results in each case. This proves that the fix does not affect f36 and fixes f37.

tcooper commented

2022-12-23 18:32:45 +00:00

(Migrated from github.com)

Thank you @AlanMarshall for thorough review (3 different environments)! One more review and we can merge and deploy to openQA-prod system. I'll check-in a few more time over the holiday but cannot promise anything more.

akatch (Migrated from github.com) approved these changes 2023-01-07 09:34:45 +00:00

akatch (Migrated from github.com) left a comment

I have confirmed Alan's result - F36 pre-patch, F36 post-patch, and F37 post-patch all have the same result for ROCKY_FLAVOR=dvd-iso.

I have confirmed Alan's result - F36 pre-patch, F36 post-patch, and F37 post-patch all have the same result for `ROCKY_FLAVOR=dvd-iso`.