Fix custom_standard_partition_ext4_postinstall failures #143

2023-01-18T06:21:39Z

akatch commented

2023-01-18 06:21:39 +00:00

(Migrated from github.com)

Description

This PR fixes the custom_standard_partition_ext4_postinstall failures on checking for mounted disks. The volume indices have changed and were causing openQA to incorrectly report those volumes as missing.

How Has This Been Tested?

# openqa-cli api -X POST isos ISO=Rocky-9.1-20221214.1-x86_64-dvd.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=9.1 BUILD=-custom_standard_partition_ext4_postinstall_fails-universal-9.1
# openqa-cli api -X POST isos ISO=Rocky-9.1-20221214.1-x86_64-dvd.iso ARCH=x86_64 DISTRI=rocky FLAVOR=dvd-iso
VERSION=9.1 BUILD=-custom_standard_partition_ext4_postinstall_fails-dvd-iso-9.1
# openqa-cli api -X POST isos ISO=Rocky-8.7-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=
8.7 BUILD=-custom_standard_partition_ext4_postinstall_fails-universal-8.7 
# openqa-cli api -X POST isos ISO=Rocky-8.7-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=dvd-iso VERSION=8.7 BUILD=-custom_standard_partition_ext4_postinstall_fails-dvd-iso-8.7

Expected failures:

# FLAVOR=dvd-iso, VERSION=8.7 or VERSION=9.1
modularity_tests@modularity_module_list
# these two failures are addressed by PR#!42
server_cockpit_default@_setup_browser
server_filesystem_default@server_filesystem_default

# FLAVOR=universal, VERSION=8.7 or VERSION=9.1
install_anaconda_text@install_text
install_mirrorlist_graphical@_do_install_and_reboot
install_serial_console@_boot_to_anaconda

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

# Description This PR fixes the `custom_standard_partition_ext4_postinstall` failures on checking for mounted disks. The volume indices have changed and were causing openQA to incorrectly report those volumes as missing. # How Has This Been Tested? ``` # openqa-cli api -X POST isos ISO=Rocky-9.1-20221214.1-x86_64-dvd.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=9.1 BUILD=-custom_standard_partition_ext4_postinstall_fails-universal-9.1 # openqa-cli api -X POST isos ISO=Rocky-9.1-20221214.1-x86_64-dvd.iso ARCH=x86_64 DISTRI=rocky FLAVOR=dvd-iso VERSION=9.1 BUILD=-custom_standard_partition_ext4_postinstall_fails-dvd-iso-9.1 # openqa-cli api -X POST isos ISO=Rocky-8.7-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION= 8.7 BUILD=-custom_standard_partition_ext4_postinstall_fails-universal-8.7 # openqa-cli api -X POST isos ISO=Rocky-8.7-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=dvd-iso VERSION=8.7 BUILD=-custom_standard_partition_ext4_postinstall_fails-dvd-iso-8.7 ``` Expected failures: ``` # FLAVOR=dvd-iso, VERSION=8.7 or VERSION=9.1 modularity_tests@modularity_module_list # these two failures are addressed by PR#!42 server_cockpit_default@_setup_browser server_filesystem_default@server_filesystem_default # FLAVOR=universal, VERSION=8.7 or VERSION=9.1 install_anaconda_text@install_text install_mirrorlist_graphical@_do_install_and_reboot install_serial_console@_boot_to_anaconda ``` # Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] Any dependent changes have been merged and published in downstream modules

AlanMarshall commented

2023-01-18 23:17:24 +00:00

(Migrated from github.com)

I have verified these fixes in combination with #142 for 9.1 & 8.7 FLAVOR=dvd-iso with the result that only the modularity_tests fail remains.
This proves the fixes in both PRs and that there is no conflict between them.

I have verified these fixes in combination with #142 for 9.1 & 8.7 FLAVOR=dvd-iso with the result that only the modularity_tests fail remains. This proves the fixes in both PRs and that there is no conflict between them.

🎉 1

AlanMarshall (Migrated from github.com) approved these changes 2023-01-19 23:47:57 +00:00

AlanMarshall (Migrated from github.com) left a comment

I have verified Al's results showing expected failures as described.