testing/os-autoinst-distri-rocky-migrated
10
0
Fork 0
Code Issues 12 Pull Requests 1 Packages Projects Releases Wiki Activity

Adding inter server tests #148

Merged
tcooper merged 18 commits from develop into main 2023-02-09 17:24:58 +00:00
Conversation 1 Commits 18 Files Changed 26 +593 -24
tcooper commented 2023-02-08 04:41:09 +00:00 (Migrated from github.com)
Copy Link
No description provided.
AlanMarshall (Migrated from github.com) approved these changes 2023-02-08 17:36:52 +00:00
AlanMarshall (Migrated from github.com) left a comment
Copy Link

The commits in this PR#148 are the same as those merged to branch develop by PR#74 and comments therein apply.
I repeated the tests from PR#74 here using branch develop with identical results.

The commits in this PR#148 are the same as those merged to branch develop by PR#74 and comments therein apply. I repeated the tests from PR#74 here using branch develop with identical results.
lumarel (Migrated from github.com) approved these changes 2023-02-09 15:50:55 +00:00
lumarel (Migrated from github.com) left a comment
Copy Link

Still LGTM 👌🏻
Only signing 🙄

Still LGTM 👌🏻 Only signing 🙄
tcooper commented 2023-02-09 17:22:55 +00:00 (Migrated from github.com)
Copy Link

I see all commits signed in the original PR so the apparent signature removal must come from the way the merge to develop was done. I'll have to read up on how to not do that in the future. I'm going to remove the all-commit-signed branch protection flag, merge this PR and restore the flag.

I see all commits signed in the [original PR](https://github.com/rocky-linux/os-autoinst-distri-rocky/pull/74/commits) so the apparent signature removal must come from the way the merge to `develop` was done. I'll have to read up on how to not do that in the future. I'm going to remove the all-commit-signed branch protection flag, merge this PR and restore the flag.
Sign in to join this conversation.
Reviewers
No reviewers
AlanMarshall
lumarel
Labels
Clear labels   
priority: critical

This issue or pull request is of utmost priority

  
priority: high

This issue or pull request is of high priority

  
priority: low

This issue or pull request is of low priority

  
priority: medium

This issue or pull request is of medium priority

  
status: abandoned

This issue or pull request has been abandoned or is stale

  
status: duplicate

This issue or pull request already exists

  
status: invalid

This doesn't seem right

  
status: peer review needed

Requires at least one review in order to be merged

  
status: wontfix

This will not be worked on

  
tag: content

Additions to (or modifications of) content in the repository

  
tag: good first issue

Good for newcomers

  
tag: help wanted

Extra attention is needed

  
test suite

This issue or pull request is for test suite changes

  
type: bug

Something isn't working

  
type: documentation

Improvements or additions to documentation

  
type: enhancement

New feature or request

  
type: maintenance

To improve or continue maintenance for something

  
type: question

Further information is requested

No Label
priority: critical
priority: high
priority: low
priority: medium
status: abandoned
status: duplicate
status: invalid
status: peer review needed
status: wontfix
tag: content
tag: good first issue
tag: help wanted
test suite
type: bug
type: documentation
type: enhancement
type: maintenance
type: question
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: testing/os-autoinst-distri-rocky-migrated#148
No description provided.
Delete Branch "develop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?