Add perltidy support and apply it to the entire codebase #150

2023-02-13T05:16:22Z

tcooper commented

2023-02-13 05:16:22 +00:00

(Migrated from github.com)

Description

This PR provides no additional test functionality but attempts to bring this repository into agreement with upstream Fedora repository in terms of Perl code quality and consistency with an ultimate goal of making direct comparisons with upstream easier and to improve our code quality.

See the README_perltidy.md file for more details and examples.

How Has This Been Tested?

Per the provided documentation as well as the code in this PR which was run through pre-commit the principle of application of perltidy and/or tidyall (via tidy) has been tested.

Ideally all test developers will enable and use pre-commit on their local clones though it is possible to use tidy judiciously either while developing or later to fix commits from naive contributors.

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

# Description This PR provides no additional test functionality but attempts to bring this repository into agreement with [upstream Fedora repository](https://pagure.io/fedora-qa/os-autoinst-distri-fedora) in terms of Perl code quality and consistency with an ultimate goal of making direct comparisons with upstream easier and to improve our code quality. See the [README_perltidy.md](https://github.com/tcooper/os-autoinst-distri-rocky/blob/add_perltidy_support/README_perltidy.md) file for more details and examples. # How Has This Been Tested? Per the provided documentation as well as the code in this PR which was run through `pre-commit` the principle of application of `perltidy` and/or `tidyall` (via `tidy`) has been tested. Ideally all test developers will enable and use `pre-commit` on their local clones though it is possible to use `tidy` judiciously either while developing or later to fix commits from naive contributors. # Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] Any dependent changes have been merged and published in downstream modules

StackKorora (Migrated from github.com) reviewed 2023-02-13 05:16:22 +00:00

lumarel (Migrated from github.com) reviewed 2023-02-13 05:16:22 +00:00

AlanMarshall (Migrated from github.com) approved these changes 2023-02-14 12:15:53 +00:00

AlanMarshall (Migrated from github.com) left a comment

On f37 development system checked this PR using perltidy, ./tidy script & tidyall with results as specified in README_perltidy.md
Also ran all tests for package-set, dvd-iso and universal for both 9.1 and 8.7 before the PR#150 changes and all again after the changes with identical results. This indicates that the changes introduced by this PR did not affect the syntactical interpretation of the modified code for these tests and changes were in layout only.

On f37 development system checked this PR using perltidy, ./tidy script & tidyall with results as specified in README_perltidy.md Also ran all tests for package-set, dvd-iso and universal for both 9.1 and 8.7 before the PR#150 changes and all again after the changes with identical results. This indicates that the changes introduced by this PR did not affect the syntactical interpretation of the modified code for these tests and changes were in layout only.

akatch (Migrated from github.com) approved these changes 2023-02-20 14:31:42 +00:00

akatch (Migrated from github.com) left a comment

Ran all the flavors for both 8.7 and 9.1 to check for regressions, both against develop and this branch. Looks good to me, :shipit:

Ran all the flavors for both 8.7 and 9.1 to check for regressions, both against `develop` and this branch. Looks good to me, :shipit:

Sign in to join this conversation.

No reviewers

lumarel

StackKorora

AlanMarshall

akatch