testing/os-autoinst-distri-rocky-migrated
10
0
Fork 0
Code Issues 12 Pull Requests 1 Packages Projects Releases Wiki Activity

Modularity tests fix for 9.1 8.8 & 8.7 #156

Merged
AlanMarshall merged 5 commits from modularity into develop 2023-03-17 16:24:18 +00:00
Conversation 2 Commits 5 Files Changed 13 +116 -30
AlanMarshall commented 2023-03-02 16:52:18 +00:00 (Migrated from github.com)
Copy Link

This PR fixes the consistent failure in the modularity_tests of the FLAVOR=dvd-iso test suite thereby resolving Issue #147
This branch is merged with PR#152 allowing in addition to 9.1 & 8.7 a successful test using version 8.8-lookahead:
Tested by:

openqa-cli api -X POST isos ISO=Rocky-9.1-20221214.1-x86_64-dvd.iso ARCH=x86_64 DISTRI=rocky FLAVOR=dvd-iso VERSION=9.1 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-9.1-20221214.1-dvd-iso TEST=modularity_tests
openqa-cli api -X POST isos ISO=Rocky-8.7-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=dvd-iso VERSION=8.7 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-8.7-20221110-dvd-iso TEST=modularity_tests
openqa-cli api -X POST isos ISO=Rocky-8.8-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=dvd-iso VERSION=8.8 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-8.8-dvd-iso TEST=modularity_tests

If merged first, this PR will supercede PR#152
fixes #147

This PR fixes the consistent failure in the modularity_tests of the FLAVOR=dvd-iso test suite thereby resolving Issue #147 This branch is merged with PR#152 allowing in addition to 9.1 & 8.7 a successful test using version 8.8-lookahead: Tested by: ``` openqa-cli api -X POST isos ISO=Rocky-9.1-20221214.1-x86_64-dvd.iso ARCH=x86_64 DISTRI=rocky FLAVOR=dvd-iso VERSION=9.1 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-9.1-20221214.1-dvd-iso TEST=modularity_tests openqa-cli api -X POST isos ISO=Rocky-8.7-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=dvd-iso VERSION=8.7 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-8.7-20221110-dvd-iso TEST=modularity_tests openqa-cli api -X POST isos ISO=Rocky-8.8-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=dvd-iso VERSION=8.8 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-8.8-dvd-iso TEST=modularity_tests ``` If merged first, this PR will supercede PR#152 fixes #147
lumarel (Migrated from github.com) reviewed 2023-03-02 16:52:18 +00:00
tcooper (Migrated from github.com) requested changes 2023-03-02 20:30:21 +00:00
tcooper (Migrated from github.com) left a comment
Copy Link

The file needles/rocky_do_install_and_reboot-prerelease_note-20230220.json is missing the ENV-DISTRI-rocky tag.

Otherwise this appears OK.

PR was run through openQA with...

Rocky 8.7

$ openqa-clone-custom-git-refspec --dry-run --verbose  https://github.com/rocky-linux/os-autoinst-distri-rocky/pull/156 https://openqa.rockylinux.org/tests/8299

NOTE: The openqa-clone-job command provided by above was modified to remove the --skip-chained-deps option allowing the parent test default_upload to produce new HDD for the modularity_tests.

$ /usr/bin/openqa-clone-job --parental-inheritance --within-instance https://openqa.rockylinux.org 8299 _GROUP=0 TEST+=@AlanMarshall/os-autoinst-distri-rocky#modularity BUILD=AlanMarshall/os-autoinst-distri-rocky#156 CASEDIR=https://github.com/AlanMarshall/os-autoinst-distri-rocky.git#modularity PRODUCTDIR=os-autoinst-distri-rocky NEEDLES_DIR=rocky/needles
Cloning parents of rocky-8.7-dvd-iso-x86_64-Build20230302-Rocky-8.7-x86_64.0-modularity_tests@64bit
Cloning children of rocky-8.7-dvd-iso-x86_64-Build20230302-Rocky-8.7-x86_64.0-install_default_upload@64bit
Created job #8398: rocky-8.7-dvd-iso-x86_64-Build20230302-Rocky-8.7-x86_64.0-modularity_tests@64bit -> https://openqa.rockylinux.org/t8398
Created job #8397: rocky-8.7-dvd-iso-x86_64-Build20230302-Rocky-8.7-x86_64.0-install_default_upload@64bit -> https://openqa.rockylinux.org/t8397

openQA: https://openqa.rockylinux.org/tests/8398

Rocky 9.1

$ openqa-clone-custom-git-refspec --dry-run --verbose  https://github.com/rocky-linux/os-autoinst-distri-rocky/pull/156 https://openqa.rockylinux.org/tests/8166

NOTE: The openqa-clone-job command provided by above was modified to remove the --skip-chained-deps option allowing the parent test default_upload to produce new HDD for the modularity_tests.

$ /usr/bin/openqa-clone-job --parental-inheritance --within-instance https://openqa.rockylinux.org 8166 _GROUP=0 TEST+=@AlanMarshall/os-autoinst-distri-rocky#modularity BUILD=AlanMarshall/os-autoinst-distri-rocky#156 CASEDIR=https://github.com/AlanMarshall/os-autoinst-distri-rocky.git#modularity PRODUCTDIR=os-autoinst-distri-rocky NEEDLES_DIR=rocky/needles
Cloning parents of rocky-9.1-dvd-iso-x86_64-Build20230302-Rocky-9.1-x86_64.0-modularity_tests@64bit
Cloning children of rocky-9.1-dvd-iso-x86_64-Build20230302-Rocky-9.1-x86_64.0-install_default_upload@64bit
Created job #8399: rocky-9.1-dvd-iso-x86_64-Build20230302-Rocky-9.1-x86_64.0-install_default_upload@64bit -> https://openqa.rockylinux.org/t8399
Created job #8400: rocky-9.1-dvd-iso-x86_64-Build20230302-Rocky-9.1-x86_64.0-modularity_tests@64bit -> https://openqa.rockylinux.org/t8400

openQA: https://openqa.rockylinux.org/tests/8400

The file `needles/rocky_do_install_and_reboot-prerelease_note-20230220.json` is missing the `ENV-DISTRI-rocky` tag. Otherwise this appears OK. PR was run through openQA with... ### Rocky 8.7 ``` $ openqa-clone-custom-git-refspec --dry-run --verbose https://github.com/rocky-linux/os-autoinst-distri-rocky/pull/156 https://openqa.rockylinux.org/tests/8299 ``` NOTE: The `openqa-clone-job` command provided by above was modified to remove the `--skip-chained-deps` option allowing the parent test `default_upload` to produce new HDD for the `modularity_tests`. ``` $ /usr/bin/openqa-clone-job --parental-inheritance --within-instance https://openqa.rockylinux.org 8299 _GROUP=0 TEST+=@AlanMarshall/os-autoinst-distri-rocky#modularity BUILD=AlanMarshall/os-autoinst-distri-rocky#156 CASEDIR=https://github.com/AlanMarshall/os-autoinst-distri-rocky.git#modularity PRODUCTDIR=os-autoinst-distri-rocky NEEDLES_DIR=rocky/needles Cloning parents of rocky-8.7-dvd-iso-x86_64-Build20230302-Rocky-8.7-x86_64.0-modularity_tests@64bit Cloning children of rocky-8.7-dvd-iso-x86_64-Build20230302-Rocky-8.7-x86_64.0-install_default_upload@64bit Created job #8398: rocky-8.7-dvd-iso-x86_64-Build20230302-Rocky-8.7-x86_64.0-modularity_tests@64bit -> https://openqa.rockylinux.org/t8398 Created job #8397: rocky-8.7-dvd-iso-x86_64-Build20230302-Rocky-8.7-x86_64.0-install_default_upload@64bit -> https://openqa.rockylinux.org/t8397 ``` openQA: https://openqa.rockylinux.org/tests/8398 ### Rocky 9.1 ``` $ openqa-clone-custom-git-refspec --dry-run --verbose https://github.com/rocky-linux/os-autoinst-distri-rocky/pull/156 https://openqa.rockylinux.org/tests/8166 ``` NOTE: The `openqa-clone-job` command provided by above was modified to remove the `--skip-chained-deps` option allowing the parent test `default_upload` to produce new HDD for the `modularity_tests`. ``` $ /usr/bin/openqa-clone-job --parental-inheritance --within-instance https://openqa.rockylinux.org 8166 _GROUP=0 TEST+=@AlanMarshall/os-autoinst-distri-rocky#modularity BUILD=AlanMarshall/os-autoinst-distri-rocky#156 CASEDIR=https://github.com/AlanMarshall/os-autoinst-distri-rocky.git#modularity PRODUCTDIR=os-autoinst-distri-rocky NEEDLES_DIR=rocky/needles Cloning parents of rocky-9.1-dvd-iso-x86_64-Build20230302-Rocky-9.1-x86_64.0-modularity_tests@64bit Cloning children of rocky-9.1-dvd-iso-x86_64-Build20230302-Rocky-9.1-x86_64.0-install_default_upload@64bit Created job #8399: rocky-9.1-dvd-iso-x86_64-Build20230302-Rocky-9.1-x86_64.0-install_default_upload@64bit -> https://openqa.rockylinux.org/t8399 Created job #8400: rocky-9.1-dvd-iso-x86_64-Build20230302-Rocky-9.1-x86_64.0-modularity_tests@64bit -> https://openqa.rockylinux.org/t8400 ``` openQA: https://openqa.rockylinux.org/tests/8400
AlanMarshall commented 2023-03-02 23:35:25 +00:00 (Migrated from github.com)
Copy Link

ENV-DISTRI-rocky tag now added to rocky_do_install_and_reboot-prerelease_note-20230220.json
This should resolve the request for changes.
Thanks for pointing this out Trevor.

ENV-DISTRI-rocky tag now added to rocky_do_install_and_reboot-prerelease_note-20230220.json This should resolve the request for changes. Thanks for pointing this out Trevor.
tcooper (Migrated from github.com) reviewed 2023-03-03 00:03:09 +00:00
AlanMarshall commented 2023-03-06 14:14:42 +00:00 (Migrated from github.com)
Copy Link

@tcooper I moved the new needles to more appropriate directories as a tidy up. No other changes.

@tcooper I moved the new needles to more appropriate directories as a tidy up. No other changes.
tcooper (Migrated from github.com) approved these changes 2023-03-09 17:14:01 +00:00
akatch (Migrated from github.com) approved these changes 2023-03-17 05:30:47 +00:00
akatch (Migrated from github.com) left a comment
Copy Link

All tests pass, approved!

All tests pass, approved!
Sign in to join this conversation.
Reviewers
No reviewers
lumarel
tcooper
akatch
Labels
Clear labels   
priority: critical

This issue or pull request is of utmost priority

  
priority: high

This issue or pull request is of high priority

  
priority: low

This issue or pull request is of low priority

  
priority: medium

This issue or pull request is of medium priority

  
status: abandoned

This issue or pull request has been abandoned or is stale

  
status: duplicate

This issue or pull request already exists

  
status: invalid

This doesn't seem right

  
status: peer review needed

Requires at least one review in order to be merged

  
status: wontfix

This will not be worked on

  
tag: content

Additions to (or modifications of) content in the repository

  
tag: good first issue

Good for newcomers

  
tag: help wanted

Extra attention is needed

  
test suite

This issue or pull request is for test suite changes

  
type: bug

Something isn't working

  
type: documentation

Improvements or additions to documentation

  
type: enhancement

New feature or request

  
type: maintenance

To improve or continue maintenance for something

  
type: question

Further information is requested

No Label
priority: critical
priority: high
priority: low
priority: medium
status: abandoned
status: duplicate
status: invalid
status: peer review needed
status: wontfix
tag: content
tag: good first issue
tag: help wanted
test suite
type: bug
type: documentation
type: enhancement
type: maintenance
type: question
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: testing/os-autoinst-distri-rocky-migrated#156
No description provided.
Delete Branch "modularity"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?