[BUG] update hostnames for all multi-worker tests to use rockylinux.org domain #159

New Issue

2023-03-16T04:09:16Z

tcooper commented

2023-03-16 04:09:16 +00:00

(Migrated from github.com)

Describe the bug
Multi-worker tests use tap interfaces and fixed IPs/hostnames for various purposes.

These are defined both in templates.fif.json...

$ grep STATIC /var/lib/openqa/tests/rocky/templates.fif.json
                "ANACONDA_STATIC": "172.16.2.111",
                "POST_STATIC": "172.16.2.102 client002.test.openqa.fedoraproject.org",
                "POST_STATIC": "172.16.2.103 client003.test.openqa.fedoraproject.org",
                "POST_STATIC": "172.16.2.105 dbclient.test.openqa.fedoraproject.org",
                "POST_STATIC": "172.16.2.108 client005.test.openqa.fedoraproject.org",
                "POST_STATIC": "172.16.2.106 ipa002.test.openqa.fedoraproject.org",
                "POST_STATIC": "172.16.2.107 ipa003.test.openqa.fedoraproject.org",
                "POST_STATIC": "172.16.2.113 rsyslogclient.test.openqa.fedoraproject.org",
                "POST_STATIC": "172.16.2.112 rsyslogserver.test.openqa.fedoraproject.org",
                "POST_STATIC": "172.16.2.104 db.test.openqa.fedoraproject.org",
                "POST_STATIC": "172.16.2.100 ipa001.test.openqa.fedoraproject.org",
                "POST_STATIC": "172.16.2.110 support.test.openqa.rockylinux.org",

...as well as in code...

$ find ./tests -name "*.pm" -exec grep -H "openqa.fedoraproject.org" '{}' \;
./tests/_vnc_client_connect_pre.pm:    setup_tap_static('172.16.2.115', 'vnc002.test.openqa.fedoraproject.org');
./tests/_iot_zezere_server.pm:    assert_script_run 'zezere-manage createsuperuser --username admin --email zezere@test.openqa.fedoraproject.org --no-input';
./tests/_vncconnect_client_setup_pre.pm:    setup_tap_static('172.16.2.117', 'vnc004.test.openqa.fedoraproject.org');

and possibly other patterns/locations.

Additionally, any test that makes use of an ip and hostname defined in templates.fif.json should not hardcode ip or hostname if this value is supplied as a test variable but should extract those values from the POST_STATIC test variable. For example...

$ find ./tests -name "*.pm" -exec grep -H "POST_STATIC" '{}' \;
./tests/realmd_join_sssd.pm:        my ($ip, $hostname) = split(/ /, get_var("POST_STATIC"));
./tests/_post_network_static.pm:    my ($ip, $hostname) = split(/ /, get_var("POST_STATIC"));

Expected behavior
Rocky Linux openQA tests should use rockylinux.org as the domain for all multi-worker test instances and, where provided, should prefer to use ip and hostname as defined in the POST_STATIC test variable.

**Describe the bug** Multi-worker tests use tap interfaces and fixed IPs/hostnames for various purposes. These are defined both in `templates.fif.json`... ```bash $ grep STATIC /var/lib/openqa/tests/rocky/templates.fif.json "ANACONDA_STATIC": "172.16.2.111", "POST_STATIC": "172.16.2.102 client002.test.openqa.fedoraproject.org", "POST_STATIC": "172.16.2.103 client003.test.openqa.fedoraproject.org", "POST_STATIC": "172.16.2.105 dbclient.test.openqa.fedoraproject.org", "POST_STATIC": "172.16.2.108 client005.test.openqa.fedoraproject.org", "POST_STATIC": "172.16.2.106 ipa002.test.openqa.fedoraproject.org", "POST_STATIC": "172.16.2.107 ipa003.test.openqa.fedoraproject.org", "POST_STATIC": "172.16.2.113 rsyslogclient.test.openqa.fedoraproject.org", "POST_STATIC": "172.16.2.112 rsyslogserver.test.openqa.fedoraproject.org", "POST_STATIC": "172.16.2.104 db.test.openqa.fedoraproject.org", "POST_STATIC": "172.16.2.100 ipa001.test.openqa.fedoraproject.org", "POST_STATIC": "172.16.2.110 support.test.openqa.rockylinux.org", ``` ...as well as in code... ```bash $ find ./tests -name "*.pm" -exec grep -H "openqa.fedoraproject.org" '{}' \; ./tests/_vnc_client_connect_pre.pm: setup_tap_static('172.16.2.115', 'vnc002.test.openqa.fedoraproject.org'); ./tests/_iot_zezere_server.pm: assert_script_run 'zezere-manage createsuperuser --username admin --email zezere@test.openqa.fedoraproject.org --no-input'; ./tests/_vncconnect_client_setup_pre.pm: setup_tap_static('172.16.2.117', 'vnc004.test.openqa.fedoraproject.org'); ``` and possibly other patterns/locations. Additionally, any test that makes use of an `ip` and `hostname` defined in `templates.fif.json` should **not** hardcode `ip` or `hostname` if this value is supplied as a test variable but should extract those values from the `POST_STATIC` test variable. For example... ```bash $ find ./tests -name "*.pm" -exec grep -H "POST_STATIC" '{}' \; ./tests/realmd_join_sssd.pm: my ($ip, $hostname) = split(/ /, get_var("POST_STATIC")); ./tests/_post_network_static.pm: my ($ip, $hostname) = split(/ /, get_var("POST_STATIC")); ``` **Expected behavior** Rocky Linux openQA tests should use rockylinux.org as the domain for all multi-worker test instances and, where provided, should prefer to use `ip` and `hostname` as defined in the `POST_STATIC` test variable.

Sign in to join this conversation.