Anaconda text install (alternate) #163

Merged
tcooper merged 3 commits from anaconda-text-install into develop 2023-03-23 05:18:04 +00:00
tcooper commented 2023-03-20 02:15:52 +00:00 (Migrated from github.com)

This PR is an alternate solution to that provided in #162 that doesn't supply a new needle but modifies the code of _boot_to_anaconda to properly handle the difference between Rocky Linux 8 and 9 with respect to boot with network up.

The existence of active network in Rocky Linux 9 Anaconda Installer produces a menu to select VNC or Text Install before the Network Spoke can be entered to activate the network (the Rocky Linux 8 path) in the install flow.

Additionally, this PR fixes password entry behavior for Rocky Linux 9 where Use Password is enabled by default (it is not enabled in Rocky Linux 8). Using non-versioned code turns off Use Password in the Rocky Linux 9 instance breaking the test during install_text.

Testing:

Test with...

$ openqa-cli api -X POST isos ISO=Rocky-9.1-20221214.1-x86_64-dvd.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=9.1 BUILD=$(date +%Y%m%d)-Rocky-9.1-x86_64.0 TEST=install_anaconda_text

Where test passed both the _boot_to_anaconda and install_text testing in Rocky Linux 9.1 fully completing the installation of the system via Anaconda Text Install method.

rocky9u1_install_text_complete

After submission and before acceptance this test should be run to completion as an openqa-clone-custom-git-refspec run referencing this PR for both Rocky Linux 8.7 and 9.1.

If accepted and merged this PR fixes #145.

This PR is an alternate solution to that provided in #162 that doesn't supply a new needle but modifies the code of `_boot_to_anaconda` to properly handle the difference between Rocky Linux 8 and 9 with respect to boot with network up. The existence of active network in Rocky Linux 9 Anaconda Installer produces a menu to select VNC or Text Install before the Network Spoke can be entered to activate the network (the Rocky Linux 8 path) in the install flow. Additionally, this PR fixes password entry behavior for Rocky Linux 9 where `Use Password` is enabled by default (it is not enabled in Rocky Linux 8). Using non-versioned code turns off `Use Password` in the Rocky Linux 9 instance breaking the test during `install_text`. Testing: Test with... ```bash $ openqa-cli api -X POST isos ISO=Rocky-9.1-20221214.1-x86_64-dvd.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=9.1 BUILD=$(date +%Y%m%d)-Rocky-9.1-x86_64.0 TEST=install_anaconda_text ``` Where test passed both the `_boot_to_anaconda` and `install_text` testing in Rocky Linux 9.1 fully completing the installation of the system via Anaconda Text Install method. ![rocky9u1_install_text_complete](https://user-images.githubusercontent.com/542846/226231012-e8dee5bf-6eb9-4938-a3a5-8c78ef442ab2.png) After submission and before acceptance this test should be run to completion as an `openqa-clone-custom-git-refspec` run referencing this PR for both Rocky Linux 8.7 and 9.1. If accepted and merged this PR fixes #145.
tcooper commented 2023-03-20 16:45:58 +00:00 (Migrated from github.com)

After a couple of minor fixes this PR now completes successfully for both...

Rocky Linux 8.7 - https://openqa.rockylinux.org/tests/13690#
Rocky Linux 9.1 - https://openqa.rockylinux.org/tests/13691#

...and should be considered an alternate solution to #162.

After a couple of minor fixes this PR now completes successfully for both... Rocky Linux 8.7 - https://openqa.rockylinux.org/tests/13690# Rocky Linux 9.1 - https://openqa.rockylinux.org/tests/13691# ...and should be considered an alternate solution to #162.
akatch (Migrated from github.com) approved these changes 2023-03-20 23:39:53 +00:00
akatch (Migrated from github.com) left a comment

This fix also works. I don't have strong opinions about whether we merge this one or #162 , although given that this is a text-based install test, changing the code seems more sensible than adding a needle.

This fix also works. I don't have strong opinions about whether we merge this one or #162 , although given that this is a text-based install test, changing the code seems more sensible than adding a needle.
AlanMarshall (Migrated from github.com) approved these changes 2023-03-22 12:58:27 +00:00
AlanMarshall (Migrated from github.com) left a comment

Tested for 9.1, 8.7 & 8.8 and all passed.
I stand corrected, well done again Trevor.
This means what it says, it is not sarcasm.

Tested for 9.1, 8.7 & 8.8 and all passed. I stand corrected, well done again Trevor. *This means what it says, it is not sarcasm.*
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: testing/os-autoinst-distri-rocky-migrated#163
No description provided.