Fix Network Install selection Needle #27

2021-08-21T17:09:11Z

lumarel commented

2021-08-21 17:09:11 +00:00

(Migrated from github.com)

Description

Updates the on_the_network needle to fix the broken install_source_graphical.pm

How Has This Been Tested?

Rerun of the whole test with the fixed needle rocky-on_the_network

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

This PR fixes #22 and will automatically close when this is resolved.

Little note:
It sometimes happens that the mirrorlist does not get accepted because the internet connection is not fully setup until this point, depends on the speed of the internet connection, we might want to check that if it makes more problems.

## Description Updates the `on_the_network` needle to fix the broken `install_source_graphical.pm` ## How Has This Been Tested? - [x] Rerun of the whole test with the fixed needle `rocky-on_the_network` ## Checklist - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] Any dependent changes have been merged and published in downstream modules This PR fixes #22 and will automatically close when this is resolved. Little note: It sometimes happens that the mirrorlist does not get accepted because the internet connection is not fully setup until this point, depends on the speed of the internet connection, we might want to check that if it makes more problems.

tcooper commented

2021-08-22 19:35:07 +00:00

(Migrated from github.com)

@lumarel I'm not sure how you POST'ed this test. Can you add a comment with your POST command-line? Also, check to see if these changes also help a POST with the boot iso get running past the anaconda_main screen?

@lumarel I'm not sure how you `POST`'ed this test. Can you add a comment with your `POST` command-line? Also, check to see if these changes also help a `POST` with the boot iso get running past the `anaconda_main` screen?

lumarel commented

2021-08-22 21:19:51 +00:00

(Migrated from github.com)

@tcooper Oh yeah sure, this is from the universal suite:
openqa-cli api -X POST isos ISO=Rocky-8.4-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.4
This is unfortunately a really big testsuite, if somehow possible you might want to only run the install_mirrorlist_graphical@64bit test, it should be possible to run it individually somehow as it uses the ISO as starting point.

Sorry I really should have added that... we might have that in our template, to always post the api post..

@tcooper Oh yeah sure, this is from the universal suite: `openqa-cli api -X POST isos ISO=Rocky-8.4-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.4` This is unfortunately a really big testsuite, if somehow possible you might want to only run the `install_mirrorlist_graphical@64bit` test, it should be possible to run it individually somehow as it uses the ISO as starting point. Sorry I really should have added that... we might have that in our template, to always post the api post..

lumarel commented

2021-08-22 21:48:15 +00:00

(Migrated from github.com)

And about the boot-iso is that the network is not already connected during the bootup, which then marks the installation source with a warning, which breaks the needle there.
I didn't have the time to look into how this should be fixed the best (not with an extra needle for sure, there needs to be a logic for that, like.. if boot-iso is used, use another needle), but it is definitely something for a new issue

And about the `boot-iso` is that the network is not already connected during the bootup, which then marks the installation source with a warning, which breaks the needle there. I didn't have the time to look into how this should be fixed the best (not with an extra needle for sure, there needs to be a logic for that, like.. if `boot-iso` is used, use another needle), but it is definitely something for a new issue

akatch commented

2021-08-23 06:23:10 +00:00

(Migrated from github.com)

Ran the provided test command and confirmed that the rocky-on_the_network needle matches in the install_source_graphical module. I did run into the mirrorlist failure, but this PR does seem to work as advertised.

Ran the provided test command and confirmed that the `rocky-on_the_network` needle matches in the `install_source_graphical` module. I did run into the mirrorlist failure, but this PR does seem to work as advertised.

StackKorora commented

2021-08-24 13:41:33 +00:00

(Migrated from github.com)

Confirmed.

Sign in to join this conversation.

No reviewers