Connect network interface and allow DHCP #3

2021-08-18T01:42:28Z

tcooper commented

2021-08-18 01:42:28 +00:00

(Migrated from github.com)

Description

Connects network interface by toggling the ON state of the network interface and allowing it to use (default) DHCP to obtain an IP address.

Fixes #2

How Has This Been Tested?

POST'ed build for minimal-iso with 100% completion.

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

NOTE: Commits from Aug 14 are in the develop branch and could be merged first. If they are not that PR will be closed (automatically?) by the merge of this one.

# Description Connects network interface by toggling the ON state of the network interface and allowing it to use (default) DHCP to obtain an IP address. Fixes #2 # How Has This Been Tested? - [x] POST'ed build for minimal-iso with 100% completion. # Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] Any dependent changes have been merged and published in downstream modules _**NOTE**: Commits from Aug 14 are in the develop branch and could be merged first. If they are not that PR will be closed (automatically?) by the merge of this one._

StackKorora commented

2021-08-19 16:04:29 +00:00

(Migrated from github.com)

This is running but I've got one error so far on install_btrfs_preserve_home@64bit
[error] HDD_1 handling Cannot find HDD_1 asset hdd/disk_f_desktop_4_x86_64.img!

Do I need to set this up first?

This is running but I've got one error so far on ` install_btrfs_preserve_home@64bit` `[error] HDD_1 handling Cannot find HDD_1 asset hdd/disk_f_desktop_4_x86_64.img!` Do I need to set this up first?

StackKorora commented

2021-08-19 17:13:03 +00:00

(Migrated from github.com)

I got a soft fail for avcs but the error isn't very clear as to what failed.

tcooper commented

2021-08-19 17:52:09 +00:00

(Migrated from github.com)

This is running but I've got one error so far on install_btrfs_preserve_home@64bit
[error] HDD_1 handling Cannot find HDD_1 asset hdd/disk_f_desktop_4_x86_64.img!

Do I need to set this up first?

All btrfs will fail. Rocky doesn't have btrfs. This should be pruned from the templates.fif.json and I think that may be in another commit/PR.

> This is running but I've got one error so far on ` install_btrfs_preserve_home@64bit` > `[error] HDD_1 handling Cannot find HDD_1 asset hdd/disk_f_desktop_4_x86_64.img!` > > Do I need to set this up first? All `btrfs` will fail. Rocky doesn't have `btrfs`. This should be pruned from the `templates.fif.json` and I think that may be in another commit/PR.

tcooper commented

2021-08-19 17:53:04 +00:00

(Migrated from github.com)

I got a soft fail for avcs but the error isn't very clear as to what failed.

Soft fails should not be blockers. I have similar example to discuss in meeting today.

> I got a soft fail for avcs but the error isn't very clear as to what failed. Soft fails should not be blockers. I have similar example to discuss in meeting today.

Sign in to join this conversation.

No reviewers