Fixes install_anaconda_text@64bit on rocky-8.4-universal-x86_64 #56

2021-10-27T16:19:33Z

tcooper commented

2021-10-27 16:19:33 +00:00

(Migrated from github.com)

Description

This PR adds support for install_anaconda_text and fixes #36

How Has This Been Tested?

$ openqa-cli api -X POST isos ISO=Rocky-8.4-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.4 BUILD=-issue_36-$(date +%Y%m%d.%H%M%S).0 PACKAGE_SET=server ANACONDA_TEXT=1 TEST=install_anaconda_text
{"count":1,"failed":[],"ids":[592],"scheduled_product_id":61}

$ openqa-cli api jobs/592 | jq '.["job"]|.["id","name","result","state","t_started","t_finished"]'592
"rocky-8.4-universal-x86_64-Buildissue_36-20211027.073905.0-install_anaconda_text@64bit"
"softfailed"
"done"
"2021-10-27T14:39:08"
"2021-10-27T15:30:17"

Other notes

Needle json was reformatted with jq before commit as follows...

➜  console git:(issue_36) ✗ for f in $(git status -s | awk '/^\?\? rocky/ {print $2}' | grep -E "\.json$"); do jq -S '.' < $f >
 foo && mv foo $f; done

Anaconda text mode install currently defaults to / expects PACKAGE_SET=server and that behavior wasn't changed.
A feature request to modify install_text.pm further to also support text mode installs for other PACKAGE_SETs could be added if deemed necessary.

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

## Description This PR adds support for `install_anaconda_text` and fixes #36 ## How Has This Been Tested? ``` $ openqa-cli api -X POST isos ISO=Rocky-8.4-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.4 BUILD=-issue_36-$(date +%Y%m%d.%H%M%S).0 PACKAGE_SET=server ANACONDA_TEXT=1 TEST=install_anaconda_text {"count":1,"failed":[],"ids":[592],"scheduled_product_id":61} $ openqa-cli api jobs/592 | jq '.["job"]|.["id","name","result","state","t_started","t_finished"]'592 "rocky-8.4-universal-x86_64-Buildissue_36-20211027.073905.0-install_anaconda_text@64bit" "softfailed" "done" "2021-10-27T14:39:08" "2021-10-27T15:30:17" ``` ## Other notes - Needle json was reformatted with `jq` before commit as follows... ``` ➜ console git:(issue_36) ✗ for f in $(git status -s | awk '/^\?\? rocky/ {print $2}' | grep -E "\.json$"); do jq -S '.' < $f > foo && mv foo $f; done ``` - Anaconda text mode install currently defaults to / expects `PACKAGE_SET=server` and that behavior wasn't changed. - A feature request to modify `install_text.pm` further to also support text mode installs for other `PACKAGE_SET`s could be added if deemed necessary. ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] Any dependent changes have been merged and published in downstream modules

akatch commented

2021-10-28 02:23:29 +00:00

(Migrated from github.com)

Looks good to me. Here's my results:

> openqa-cli api jobs/993 | jq '.["job"]|.["id","name","result","state","t_started","t_finished"]'
993
"rocky-8.4-universal-x86_64-Build-issue_36-20211027.120246.0-install_anaconda_text@64bit"
"softfailed"
"done"
"2021-10-27T17:02:47"
"2021-10-27T17:21:06"

Looks good to me. Here's my results: ``` > openqa-cli api jobs/993 | jq '.["job"]|.["id","name","result","state","t_started","t_finished"]' 993 "rocky-8.4-universal-x86_64-Build-issue_36-20211027.120246.0-install_anaconda_text@64bit" "softfailed" "done" "2021-10-27T17:02:47" "2021-10-27T17:21:06" ```

akatch (Migrated from github.com) approved these changes 2021-10-28 02:23:58 +00:00

lumarel (Migrated from github.com) requested changes 2021-10-28 20:31:49 +00:00

lumarel (Migrated from github.com) left a comment

I had an extensive testing session of the last 2 days again, it mostly walks through without problems.
Only the removal of the console_password_required needles makes problems on my end because the now only provided needle sometimes fails with 82% because the font is slightly off.

Here is the working needle:

I had an extensive testing session of the last 2 days again, it mostly walks through without problems. Only the removal of the `console_password_required` needles makes problems on my end because the now only provided needle sometimes fails with 82% because the font is slightly off. ![image](https://user-images.githubusercontent.com/42647570/139331052-fd215b14-cf7a-4a34-928c-fd0aa08fe1d6.png) ![image](https://user-images.githubusercontent.com/42647570/139331089-59361c35-8082-4428-bfbd-67b31190c952.png) Here is the working needle: ![image](https://user-images.githubusercontent.com/42647570/139349485-9a527916-a4ef-4a84-9c72-3276b88e3543.png)

tcooper commented

2021-11-02 07:30:43 +00:00

(Migrated from github.com)

@lumarel needles for console_password_required should be fixed.

@lumarel needles for `console_password_required` should be fixed.

lumarel commented

2021-11-02 19:44:08 +00:00

(Migrated from github.com)

I will give it another run and will report back later 👍🏻