Changes to support 8.5 #64

2021-11-14T23:37:20Z

lumarel commented

2021-11-14 23:37:20 +00:00

(Migrated from github.com)

Description

This PR fixes multiple needles which got changed from 8.4 to 8.5.
This will also change the behavior for version identification to only match major versions instead of the full version text.

How Has This Been Tested?

openqa-cli api -X POST isos ISO=Rocky-8.5-x86_64-boot.iso ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=8.5 BUILD=-boot-iso-$(date +%Y%m%d.%H%M%S).0
openqa-cli api -X POST isos ISO=Rocky-8.5-x86_64-minimal.iso ARCH=x86_64 DISTRI=rocky FLAVOR=minimal-iso VERSION=8.5 BUILD=-minimal-iso-$(date +%Y%m%d.%H%M%S).0
openqa-cli api -X POST isos ISO=Rocky-8.5-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=dvd-iso PACKAGE_SET=minimal VERSION=8.5 BUILD=-minimal-$(date +%Y%m%d.%H%M%S).0
openqa-cli api -X POST isos ISO=Rocky-8.5-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=dvd-iso PACKAGE_SET=server VERSION=8.5 BUILD=-server-$(date +%Y%m%d.%H%M%S).0
openqa-cli api -X POST isos ISO=Rocky-8.5-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=dvd-iso PACKAGE_SET=graphical-server VERSION=8.5 BUILD=-graphical-server-$(date +%Y%m%d.%H%M%S).0 DESKTOP=gnome
openqa-cli api -X POST isos ISO=Rocky-8.5-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=dvd-iso PACKAGE_SET=workstation VERSION=8.5 BUILD=-workstation-$(date +%Y%m%d.%H%M%S).0 DESKTOP=gnome
openqa-cli api -X POST isos ISO=Rocky-8.5-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.5 BUILD=-universal-$(date +%Y%m%d.%H%M%S).0

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

The following tests got fixed:

server_cockpit_basic
install_asian_language
install_european_language
all tests which use the check_version utility module

## Description This PR fixes multiple needles which got changed from 8.4 to 8.5. This will also change the behavior for version identification to only match major versions instead of the full version text. ## How Has This Been Tested? ```sh openqa-cli api -X POST isos ISO=Rocky-8.5-x86_64-boot.iso ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=8.5 BUILD=-boot-iso-$(date +%Y%m%d.%H%M%S).0 openqa-cli api -X POST isos ISO=Rocky-8.5-x86_64-minimal.iso ARCH=x86_64 DISTRI=rocky FLAVOR=minimal-iso VERSION=8.5 BUILD=-minimal-iso-$(date +%Y%m%d.%H%M%S).0 openqa-cli api -X POST isos ISO=Rocky-8.5-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=dvd-iso PACKAGE_SET=minimal VERSION=8.5 BUILD=-minimal-$(date +%Y%m%d.%H%M%S).0 openqa-cli api -X POST isos ISO=Rocky-8.5-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=dvd-iso PACKAGE_SET=server VERSION=8.5 BUILD=-server-$(date +%Y%m%d.%H%M%S).0 openqa-cli api -X POST isos ISO=Rocky-8.5-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=dvd-iso PACKAGE_SET=graphical-server VERSION=8.5 BUILD=-graphical-server-$(date +%Y%m%d.%H%M%S).0 DESKTOP=gnome openqa-cli api -X POST isos ISO=Rocky-8.5-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=dvd-iso PACKAGE_SET=workstation VERSION=8.5 BUILD=-workstation-$(date +%Y%m%d.%H%M%S).0 DESKTOP=gnome openqa-cli api -X POST isos ISO=Rocky-8.5-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.5 BUILD=-universal-$(date +%Y%m%d.%H%M%S).0 ``` ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] Any dependent changes have been merged and published in downstream modules ## The following tests got fixed: - server_cockpit_basic - install_asian_language - install_european_language - all tests which use the `check_version` utility module

akatch commented

2021-11-15 15:42:40 +00:00

(Migrated from github.com)

Currently seeing the following results:

server_cockpit_basic is either skipped or passed (skipped in graphical-server and workstation)
install_asian_language failed but it looks like the test just needed more time to complete. I am rerunning this one.
install_european_language passed

UPDATE install_asian_language passed on a rerun.

Currently seeing the following results: - server_cockpit_basic is either skipped or passed (skipped in graphical-server and workstation) - install_asian_language **failed** but it looks like the test just needed more time to complete. I am rerunning this one. - install_european_language passed **UPDATE** install_asian_language passed on a rerun.

akatch (Migrated from github.com) approved these changes 2021-11-15 22:59:47 +00:00

akatch (Migrated from github.com) left a comment

Works as advertised. Saw a few failures but was able to get them to pass on a rerun. Might need to upgrade my test system soon.....

tcooper (Migrated from github.com) reviewed 2021-11-16 06:53:56 +00:00

lib/utils.pm

tcooper (Migrated from github.com) commented

2021-11-16 06:53:56 +00:00

I think a more complete test here is to drop to the root console and detect the release outside the GUI. This will get us past this hurdle but we want to ensure the installer we run is actually for the VERSION we are testing as our openQA needs to work for all supported versions at the same time.