Fixes _boot_to_anaconda doesn't handle closest mirror gracefully in 8.5 #66

2021-11-21T17:25:05Z

tcooper commented

2021-11-21 17:25:05 +00:00

(Migrated from github.com)

Description

This PR fixes #65 by providing a new needle, code and medium type modifications to connect the network interface automatically at boot.

How Has This Been Tested?

openqa-cli api -X POST isos ISO=Rocky-8.5-x86_64-boot.iso ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=8.5 BUILD=8.5_boot-iso_20211120.223231.0 PACKAGE_SET=minimal IDENTIFICATION=false
openqa-cli api -X POST isos ISO=Rocky-8.5-x86_64-boot.iso ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=8.5 BUILD=8.5_boot-iso_20211120.223231.0 PACKAGE_SET=minimal IDENTIFICATION=false QEMUCPU=host GRUB="ip=dhcp mitigations=off"

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

## Description This PR fixes #65 by providing a new needle, code and medium type modifications to connect the network interface automatically at boot. ## How Has This Been Tested? ```sh openqa-cli api -X POST isos ISO=Rocky-8.5-x86_64-boot.iso ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=8.5 BUILD=8.5_boot-iso_20211120.223231.0 PACKAGE_SET=minimal IDENTIFICATION=false openqa-cli api -X POST isos ISO=Rocky-8.5-x86_64-boot.iso ARCH=x86_64 DISTRI=rocky FLAVOR=boot-iso VERSION=8.5 BUILD=8.5_boot-iso_20211120.223231.0 PACKAGE_SET=minimal IDENTIFICATION=false QEMUCPU=host GRUB="ip=dhcp mitigations=off" ``` ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] Any dependent changes have been merged and published in downstream modules

StackKorora (Migrated from github.com) reviewed 2021-11-21 17:25:05 +00:00

lumarel (Migrated from github.com) reviewed 2021-11-21 17:25:05 +00:00

akatch commented

2021-11-21 18:46:40 +00:00

(Migrated from github.com)

Before running these tests, make sure to reload your fifloader templates:

./fifloader.py --clean --load templates.fif.json

The specified test suites all connect to the network successfully. However, I am seeing a failure in install_default@uefi at the uefi_postinstall step. The failure message is # Test died: no candidate needle with tag(s) 'root_console' matched:

Test report:

Build8.5_boot-iso_20211121.121813.0

Test	Result	Failure Reason	Effort to Fix	Notes
install_default@64bit	passed
install_default@uefi	failed	`# Test died: no candidate needle with tag(s) 'root_console' matched`

Build8.5_boot-iso_20211121.121818.0

Test	Result	Failure Reason	Effort to Fix	Notes
install_default@64bit	passed
install_default@uefi	passed

Before running these tests, make sure to reload your fifloader templates: `./fifloader.py --clean --load templates.fif.json` The specified test suites all connect to the network successfully. However, I am seeing a failure in `install_default@uefi` at the `uefi_postinstall` step. The failure message is `# Test died: no candidate needle with tag(s) 'root_console' matched`: ![](https://imgur.com/6xkpLaq.png) Test report: ### Build8.5_boot-iso_20211121.121813.0 | Test | Result | Failure Reason | Effort to Fix | Notes | | ---- | ------ | -------------- | ------------ | ----- | | install_default@64bit | passed | | | | | install_default@uefi | failed | `# Test died: no candidate needle with tag(s) 'root_console' matched` | | | ### Build8.5_boot-iso_20211121.121818.0 | Test | Result | Failure Reason | Effort to Fix | Notes | | ---- | ------ | -------------- | ------------ | ----- | | install_default@64bit | passed | | | | | install_default@uefi | passed | | | |

akatch (Migrated from github.com) reviewed 2021-11-21 19:03:59 +00:00

akatch (Migrated from github.com) left a comment

Will change this review to an approval on confirmation that the failure I'm seeing is unrelated to the fix for this test.

tcooper commented

2021-11-21 21:40:18 +00:00

(Migrated from github.com)

Will change this review to an approval on confirmation that the failure I'm seeing is unrelated to the fix for this test.

Interesting. Did you run the same POSTs I provided after running ./fifloader.py? It was on oversight for me to include the QEMUCPU=host parameter POST as it should not be required. I'll rerun after rolling back my vm.

This is the case where also summarizing the test parameters used via build_report.sh might prove useful and / or it might be a good idea to always use the archive functionality when the job(s) were used to support a PR submission.

> Will change this review to an approval on confirmation that the failure I'm seeing is unrelated to the fix for this test. Interesting. Did you run the same POSTs I provided after running `./fifloader.py`? It was on oversight for me to include the `QEMUCPU=host` parameter POST as it should not be required. I'll rerun after rolling back my vm. This is the case where also summarizing the test parameters used via `build_report.sh` might prove useful and / or it might be a good idea to always use the `archive` functionality when the job(s) were used to support a PR submission.

akatch commented

2021-11-22 00:05:37 +00:00

(Migrated from github.com)

I did run the exact same POSTs as outlined in the description for this PR. However, I just reran that suite again, twice, and both times it passed. Race condition?