[8.6 Release Issues] Test Suite: install_mirrorlist_graphical on rocky-8.6-universal #91

2022-05-14T15:21:02Z

akatch commented

2022-05-14 15:21:02 +00:00

(Migrated from github.com)

Description

This PR adds a needle with the new Security Policy spoke icon. Fixes #89 when merged.

How Has This Been Tested?

openqa-cli api -X POST isos ISO=Rocky-8.6-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.6 BUILD=8.6_universal_$(date +%Y%m%d.%H%M%S).0 TEST=install_mirrorlist_graphical

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

# Description This PR adds a needle with the new Security Policy spoke icon. Fixes #89 when merged. # How Has This Been Tested? ``` openqa-cli api -X POST isos ISO=Rocky-8.6-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.6 BUILD=8.6_universal_$(date +%Y%m%d.%H%M%S).0 TEST=install_mirrorlist_graphical ``` # Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] Any dependent changes have been merged and published in downstream modules

StackKorora (Migrated from github.com) reviewed 2022-05-14 15:21:02 +00:00

lumarel (Migrated from github.com) reviewed 2022-05-14 15:21:02 +00:00

tcooper (Migrated from github.com) approved these changes 2022-05-14 16:11:13 +00:00

tcooper (Migrated from github.com) left a comment

This looks good. Thanks for the detail in the issue which clearly spelled out what was wrong and what this change should do. We will want to be aware of the possible need to update / add as the Security spoke can now be transited. We don't have test(s) yet for SCAP / CIS stuff and that was manually tested by @atomicturtle but we should add that to openQA so it can be done automatically. This has been discussed in MM a bit while it was being developed.

akatch commented

2022-05-14 16:21:37 +00:00

(Migrated from github.com)

This looks good. Thanks for the detail in the issue which clearly spelled out what was wrong and what this change should do. We will want to be aware of the possible need to update / add as the Security spoke can now be transited. We don't have test(s) yet for SCAP / CIS stuff and that was manually tested by @atomicturtle but we should add that to openQA so it can be done automatically. This has been discussed in MM a bit while it was being developed.

Thanks Trevor. As outlined in the timeline for this PR, I have created a stub feature request for those tests here. We should definitely make that issue description more robust, but at least now we can't forget about it.

> This looks good. Thanks for the detail in the issue which clearly spelled out what was wrong and what this change should do. We will want to be aware of the possible need to update / add as the Security spoke can now be transited. We don't have test(s) yet for SCAP / CIS stuff and that was manually tested by @atomicturtle but we should add that to openQA so it can be done automatically. This has been discussed in MM a bit while it was being developed. Thanks Trevor. As outlined in the timeline for this PR, I have created a stub feature request for those tests [here](https://github.com/rocky-linux/os-autoinst-distri-rocky/issues/93). We should definitely make that issue description more robust, but at least now we can't forget about it.

Sign in to join this conversation.

No reviewers

lumarel

StackKorora

tcooper