New topbar and leftbar needles #120

Merged
akatch merged 2 commits from 9.0rc2_needles into 9.0_release_fixes 2022-07-06 22:56:29 +00:00
Showing only changes of commit 4e68f85ab8 - Show all commits

View File

@ -1,17 +1,16 @@
lumarel commented 2022-07-06 19:52:29 +00:00 (Migrated from github.com)
Review

If you have the time, could you change that to the same values as rocky-topbar_generic-20220612.json to also make the other language tests work 🙂

{
  "area": [
    {
      "width": 531,
      "height": 32,
      "xpos": 237,
      "ypos": 31,
      "type": "match"
    }
  ],
  "properties": [],
  "tags": [
    "ENV-DISTRI-rocky",
    "topbar_generic"
  ]
}
If you have the time, could you change that to the same values as `rocky-topbar_generic-20220612.json` to also make the other language tests work 🙂 ```json { "area": [ { "width": 531, "height": 32, "xpos": 237, "ypos": 31, "type": "match" } ], "properties": [], "tags": [ "ENV-DISTRI-rocky", "topbar_generic" ] } ```
lumarel commented 2022-07-06 19:52:29 +00:00 (Migrated from github.com)
Review

If you have the time, could you change that to the same values as rocky-topbar_generic-20220612.json to also make the other language tests work 🙂

{
  "area": [
    {
      "width": 531,
      "height": 32,
      "xpos": 237,
      "ypos": 31,
      "type": "match"
    }
  ],
  "properties": [],
  "tags": [
    "ENV-DISTRI-rocky",
    "topbar_generic"
  ]
}
If you have the time, could you change that to the same values as `rocky-topbar_generic-20220612.json` to also make the other language tests work 🙂 ```json { "area": [ { "width": 531, "height": 32, "xpos": 237, "ypos": 31, "type": "match" } ], "properties": [], "tags": [ "ENV-DISTRI-rocky", "topbar_generic" ] } ```
{
"area": [
{
"type": "match",
lumarel commented 2022-07-06 19:52:29 +00:00 (Migrated from github.com)
Review

If you have the time, could you change that to the same values as rocky-topbar_generic-20220612.json to also make the other language tests work 🙂

{
  "area": [
    {
      "width": 531,
      "height": 32,
      "xpos": 237,
      "ypos": 31,
      "type": "match"
    }
  ],
  "properties": [],
  "tags": [
    "ENV-DISTRI-rocky",
    "topbar_generic"
  ]
}
If you have the time, could you change that to the same values as `rocky-topbar_generic-20220612.json` to also make the other language tests work 🙂 ```json { "area": [ { "width": 531, "height": 32, "xpos": 237, "ypos": 31, "type": "match" } ], "properties": [], "tags": [ "ENV-DISTRI-rocky", "topbar_generic" ] } ```
"xpos": 493,
lumarel commented 2022-07-06 19:52:29 +00:00 (Migrated from github.com)
Review

If you have the time, could you change that to the same values as rocky-topbar_generic-20220612.json to also make the other language tests work 🙂

{
  "area": [
    {
      "width": 531,
      "height": 32,
      "xpos": 237,
      "ypos": 31,
      "type": "match"
    }
  ],
  "properties": [],
  "tags": [
    "ENV-DISTRI-rocky",
    "topbar_generic"
  ]
}
If you have the time, could you change that to the same values as `rocky-topbar_generic-20220612.json` to also make the other language tests work 🙂 ```json { "area": [ { "width": 531, "height": 32, "xpos": 237, "ypos": 31, "type": "match" } ], "properties": [], "tags": [ "ENV-DISTRI-rocky", "topbar_generic" ] } ```
"width": 531,
"height": 32,
"ypos": 0
lumarel commented 2022-07-06 19:52:29 +00:00 (Migrated from github.com)
Review

If you have the time, could you change that to the same values as rocky-topbar_generic-20220612.json to also make the other language tests work 🙂

{
  "area": [
    {
      "width": 531,
      "height": 32,
      "xpos": 237,
      "ypos": 31,
      "type": "match"
    }
  ],
  "properties": [],
  "tags": [
    "ENV-DISTRI-rocky",
    "topbar_generic"
  ]
}
If you have the time, could you change that to the same values as `rocky-topbar_generic-20220612.json` to also make the other language tests work 🙂 ```json { "area": [ { "width": 531, "height": 32, "xpos": 237, "ypos": 31, "type": "match" } ], "properties": [], "tags": [ "ENV-DISTRI-rocky", "topbar_generic" ] } ```
"xpos": 237,
lumarel commented 2022-07-06 19:52:29 +00:00 (Migrated from github.com)
Review

If you have the time, could you change that to the same values as rocky-topbar_generic-20220612.json to also make the other language tests work 🙂

{
  "area": [
    {
      "width": 531,
      "height": 32,
      "xpos": 237,
      "ypos": 31,
      "type": "match"
    }
  ],
  "properties": [],
  "tags": [
    "ENV-DISTRI-rocky",
    "topbar_generic"
  ]
}
If you have the time, could you change that to the same values as `rocky-topbar_generic-20220612.json` to also make the other language tests work 🙂 ```json { "area": [ { "width": 531, "height": 32, "xpos": 237, "ypos": 31, "type": "match" } ], "properties": [], "tags": [ "ENV-DISTRI-rocky", "topbar_generic" ] } ```
"ypos": 31,
lumarel commented 2022-07-06 19:52:29 +00:00 (Migrated from github.com)
Review

If you have the time, could you change that to the same values as rocky-topbar_generic-20220612.json to also make the other language tests work 🙂

{
  "area": [
    {
      "width": 531,
      "height": 32,
      "xpos": 237,
      "ypos": 31,
      "type": "match"
    }
  ],
  "properties": [],
  "tags": [
    "ENV-DISTRI-rocky",
    "topbar_generic"
  ]
}
If you have the time, could you change that to the same values as `rocky-topbar_generic-20220612.json` to also make the other language tests work 🙂 ```json { "area": [ { "width": 531, "height": 32, "xpos": 237, "ypos": 31, "type": "match" } ], "properties": [], "tags": [ "ENV-DISTRI-rocky", "topbar_generic" ] } ```
"type": "match"
lumarel commented 2022-07-06 19:52:29 +00:00 (Migrated from github.com)
Review

If you have the time, could you change that to the same values as rocky-topbar_generic-20220612.json to also make the other language tests work 🙂

{
  "area": [
    {
      "width": 531,
      "height": 32,
      "xpos": 237,
      "ypos": 31,
      "type": "match"
    }
  ],
  "properties": [],
  "tags": [
    "ENV-DISTRI-rocky",
    "topbar_generic"
  ]
}
If you have the time, could you change that to the same values as `rocky-topbar_generic-20220612.json` to also make the other language tests work 🙂 ```json { "area": [ { "width": 531, "height": 32, "xpos": 237, "ypos": 31, "type": "match" } ], "properties": [], "tags": [ "ENV-DISTRI-rocky", "topbar_generic" ] } ```
}
],
"properties": [],
"tags": [
"ENV-DISTRI-rocky",
"LANGUAGE-english",
lumarel commented 2022-07-06 19:52:29 +00:00 (Migrated from github.com)
Review

If you have the time, could you change that to the same values as rocky-topbar_generic-20220612.json to also make the other language tests work 🙂

{
  "area": [
    {
      "width": 531,
      "height": 32,
      "xpos": 237,
      "ypos": 31,
      "type": "match"
    }
  ],
  "properties": [],
  "tags": [
    "ENV-DISTRI-rocky",
    "topbar_generic"
  ]
}
If you have the time, could you change that to the same values as `rocky-topbar_generic-20220612.json` to also make the other language tests work 🙂 ```json { "area": [ { "width": 531, "height": 32, "xpos": 237, "ypos": 31, "type": "match" } ], "properties": [], "tags": [ "ENV-DISTRI-rocky", "topbar_generic" ] } ```
"topbar_generic"
]
}
lumarel commented 2022-07-06 19:52:29 +00:00 (Migrated from github.com)
Review

If you have the time, could you change that to the same values as rocky-topbar_generic-20220612.json to also make the other language tests work 🙂

{
  "area": [
    {
      "width": 531,
      "height": 32,
      "xpos": 237,
      "ypos": 31,
      "type": "match"
    }
  ],
  "properties": [],
  "tags": [
    "ENV-DISTRI-rocky",
    "topbar_generic"
  ]
}
If you have the time, could you change that to the same values as `rocky-topbar_generic-20220612.json` to also make the other language tests work 🙂 ```json { "area": [ { "width": 531, "height": 32, "xpos": 237, "ypos": 31, "type": "match" } ], "properties": [], "tags": [ "ENV-DISTRI-rocky", "topbar_generic" ] } ```
}
lumarel commented 2022-07-06 19:52:29 +00:00 (Migrated from github.com)
Review

If you have the time, could you change that to the same values as rocky-topbar_generic-20220612.json to also make the other language tests work 🙂

{
  "area": [
    {
      "width": 531,
      "height": 32,
      "xpos": 237,
      "ypos": 31,
      "type": "match"
    }
  ],
  "properties": [],
  "tags": [
    "ENV-DISTRI-rocky",
    "topbar_generic"
  ]
}
If you have the time, could you change that to the same values as `rocky-topbar_generic-20220612.json` to also make the other language tests work 🙂 ```json { "area": [ { "width": 531, "height": 32, "xpos": 237, "ypos": 31, "type": "match" } ], "properties": [], "tags": [ "ENV-DISTRI-rocky", "topbar_generic" ] } ```

lumarel commented 2022-07-06 19:52:29 +00:00 (Migrated from github.com)
Review

If you have the time, could you change that to the same values as rocky-topbar_generic-20220612.json to also make the other language tests work 🙂

{
  "area": [
    {
      "width": 531,
      "height": 32,
      "xpos": 237,
      "ypos": 31,
      "type": "match"
    }
  ],
  "properties": [],
  "tags": [
    "ENV-DISTRI-rocky",
    "topbar_generic"
  ]
}
If you have the time, could you change that to the same values as `rocky-topbar_generic-20220612.json` to also make the other language tests work 🙂 ```json { "area": [ { "width": 531, "height": 32, "xpos": 237, "ypos": 31, "type": "match" } ], "properties": [], "tags": [ "ENV-DISTRI-rocky", "topbar_generic" ] } ```
lumarel commented 2022-07-06 19:52:29 +00:00 (Migrated from github.com)
Review

If you have the time, could you change that to the same values as rocky-topbar_generic-20220612.json to also make the other language tests work 🙂

{
  "area": [
    {
      "width": 531,
      "height": 32,
      "xpos": 237,
      "ypos": 31,
      "type": "match"
    }
  ],
  "properties": [],
  "tags": [
    "ENV-DISTRI-rocky",
    "topbar_generic"
  ]
}
If you have the time, could you change that to the same values as `rocky-topbar_generic-20220612.json` to also make the other language tests work 🙂 ```json { "area": [ { "width": 531, "height": 32, "xpos": 237, "ypos": 31, "type": "match" } ], "properties": [], "tags": [ "ENV-DISTRI-rocky", "topbar_generic" ] } ```