testing/os-autoinst-distri-rocky-migrated
10
0
Fork 0
Code Issues 12 Pull Requests 1 Packages Projects Releases Wiki Activity

Replace blivet tests with custom GUI tests #51

Merged
akatch merged 15 commits from issue_9 into develop 2021-10-26 15:56:01 +00:00
Conversation 5 Commits 15 Files Changed 42 +2 -39
5 changed files with 2 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 21e805152b - Show all commits

1
needles/anaconda/partitioning/custom-gui/rocky-anaconda_custom_part_add-20211008.json
View File

@ -11,6 +11,7 @@
"properties": [], "properties": [],
"tags": [ "tags": [
"ENV-DISTRI-rocky", "ENV-DISTRI-rocky",
"LANGUAGE-english",
"anaconda_custom_part_add" "anaconda_custom_part_add"
tcooper commented 2021-10-25 04:57:05 +00:00 (Migrated from github.com)
Review
Copy Link

Not critical but you didn't specify LANGUAGE-english in this needle.

Not critical but you didn't specify `LANGUAGE-english` in this needle.
] ]
} }

17
needles/anaconda/partitioning/custom-gui/rocky-anaconda_custom_size_unit-20211005.json
View File

@ -1,17 +0,0 @@
tcooper commented 2021-10-25 05:09:36 +00:00 (Migrated from github.com)
Review
Copy Link

It's unclear to me why there are three needles matching for anaconda_custom_size. They have slightly different locations and the two have a click but one does not. In my disk_custom_gui_standard_partition_ext4@x86_64 test the needle matched here is rocky-anaconda_custom_size-20211010. Are rocky-anaconda_custom_size-20211005 and rocky-anaconda_custom_size-20211007 needed at all?

It's unclear to me why there are three needles matching for `anaconda_custom_size`. They have slightly different locations and the two have a click but one does not. In my `disk_custom_gui_standard_partition_ext4@x86_64` test the needle matched here is `rocky-anaconda_custom_size-20211010`. Are `rocky-anaconda_custom_size-20211005` and `rocky-anaconda_custom_size-20211007` needed at all?
tcooper commented 2021-10-25 05:09:36 +00:00 (Migrated from github.com)
Review
Copy Link

It's unclear to me why there are three needles matching for anaconda_custom_size. They have slightly different locations and the two have a click but one does not. In my disk_custom_gui_standard_partition_ext4@x86_64 test the needle matched here is rocky-anaconda_custom_size-20211010. Are rocky-anaconda_custom_size-20211005 and rocky-anaconda_custom_size-20211007 needed at all?

It's unclear to me why there are three needles matching for `anaconda_custom_size`. They have slightly different locations and the two have a click but one does not. In my `disk_custom_gui_standard_partition_ext4@x86_64` test the needle matched here is `rocky-anaconda_custom_size-20211010`. Are `rocky-anaconda_custom_size-20211005` and `rocky-anaconda_custom_size-20211007` needed at all?
akatch commented 2021-10-25 23:20:52 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.
akatch commented 2021-10-25 23:20:52 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.
{
tcooper commented 2021-10-25 05:09:36 +00:00 (Migrated from github.com)
Review
Copy Link

It's unclear to me why there are three needles matching for anaconda_custom_size. They have slightly different locations and the two have a click but one does not. In my disk_custom_gui_standard_partition_ext4@x86_64 test the needle matched here is rocky-anaconda_custom_size-20211010. Are rocky-anaconda_custom_size-20211005 and rocky-anaconda_custom_size-20211007 needed at all?

It's unclear to me why there are three needles matching for `anaconda_custom_size`. They have slightly different locations and the two have a click but one does not. In my `disk_custom_gui_standard_partition_ext4@x86_64` test the needle matched here is `rocky-anaconda_custom_size-20211010`. Are `rocky-anaconda_custom_size-20211005` and `rocky-anaconda_custom_size-20211007` needed at all?
akatch commented 2021-10-25 23:20:52 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.
"area": [
tcooper commented 2021-10-25 05:09:36 +00:00 (Migrated from github.com)
Review
Copy Link

It's unclear to me why there are three needles matching for anaconda_custom_size. They have slightly different locations and the two have a click but one does not. In my disk_custom_gui_standard_partition_ext4@x86_64 test the needle matched here is rocky-anaconda_custom_size-20211010. Are rocky-anaconda_custom_size-20211005 and rocky-anaconda_custom_size-20211007 needed at all?

It's unclear to me why there are three needles matching for `anaconda_custom_size`. They have slightly different locations and the two have a click but one does not. In my `disk_custom_gui_standard_partition_ext4@x86_64` test the needle matched here is `rocky-anaconda_custom_size-20211010`. Are `rocky-anaconda_custom_size-20211005` and `rocky-anaconda_custom_size-20211007` needed at all?
akatch commented 2021-10-25 23:20:52 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.
{
tcooper commented 2021-10-25 05:09:36 +00:00 (Migrated from github.com)
Review
Copy Link

It's unclear to me why there are three needles matching for anaconda_custom_size. They have slightly different locations and the two have a click but one does not. In my disk_custom_gui_standard_partition_ext4@x86_64 test the needle matched here is rocky-anaconda_custom_size-20211010. Are rocky-anaconda_custom_size-20211005 and rocky-anaconda_custom_size-20211007 needed at all?

It's unclear to me why there are three needles matching for `anaconda_custom_size`. They have slightly different locations and the two have a click but one does not. In my `disk_custom_gui_standard_partition_ext4@x86_64` test the needle matched here is `rocky-anaconda_custom_size-20211010`. Are `rocky-anaconda_custom_size-20211005` and `rocky-anaconda_custom_size-20211007` needed at all?
akatch commented 2021-10-25 23:20:52 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.
"xpos": 352,
tcooper commented 2021-10-25 05:09:36 +00:00 (Migrated from github.com)
Review
Copy Link

It's unclear to me why there are three needles matching for anaconda_custom_size. They have slightly different locations and the two have a click but one does not. In my disk_custom_gui_standard_partition_ext4@x86_64 test the needle matched here is rocky-anaconda_custom_size-20211010. Are rocky-anaconda_custom_size-20211005 and rocky-anaconda_custom_size-20211007 needed at all?

It's unclear to me why there are three needles matching for `anaconda_custom_size`. They have slightly different locations and the two have a click but one does not. In my `disk_custom_gui_standard_partition_ext4@x86_64` test the needle matched here is `rocky-anaconda_custom_size-20211010`. Are `rocky-anaconda_custom_size-20211005` and `rocky-anaconda_custom_size-20211007` needed at all?
akatch commented 2021-10-25 23:20:52 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.
"ypos": 397,
tcooper commented 2021-10-25 05:09:36 +00:00 (Migrated from github.com)
Review
Copy Link

It's unclear to me why there are three needles matching for anaconda_custom_size. They have slightly different locations and the two have a click but one does not. In my disk_custom_gui_standard_partition_ext4@x86_64 test the needle matched here is rocky-anaconda_custom_size-20211010. Are rocky-anaconda_custom_size-20211005 and rocky-anaconda_custom_size-20211007 needed at all?

It's unclear to me why there are three needles matching for `anaconda_custom_size`. They have slightly different locations and the two have a click but one does not. In my `disk_custom_gui_standard_partition_ext4@x86_64` test the needle matched here is `rocky-anaconda_custom_size-20211010`. Are `rocky-anaconda_custom_size-20211005` and `rocky-anaconda_custom_size-20211007` needed at all?
akatch commented 2021-10-25 23:20:52 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.
"width": 317,
tcooper commented 2021-10-25 05:09:36 +00:00 (Migrated from github.com)
Review
Copy Link

It's unclear to me why there are three needles matching for anaconda_custom_size. They have slightly different locations and the two have a click but one does not. In my disk_custom_gui_standard_partition_ext4@x86_64 test the needle matched here is rocky-anaconda_custom_size-20211010. Are rocky-anaconda_custom_size-20211005 and rocky-anaconda_custom_size-20211007 needed at all?

It's unclear to me why there are three needles matching for `anaconda_custom_size`. They have slightly different locations and the two have a click but one does not. In my `disk_custom_gui_standard_partition_ext4@x86_64` test the needle matched here is `rocky-anaconda_custom_size-20211010`. Are `rocky-anaconda_custom_size-20211005` and `rocky-anaconda_custom_size-20211007` needed at all?
akatch commented 2021-10-25 23:20:52 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.
"height": 32,
tcooper commented 2021-10-25 05:09:36 +00:00 (Migrated from github.com)
Review
Copy Link

It's unclear to me why there are three needles matching for anaconda_custom_size. They have slightly different locations and the two have a click but one does not. In my disk_custom_gui_standard_partition_ext4@x86_64 test the needle matched here is rocky-anaconda_custom_size-20211010. Are rocky-anaconda_custom_size-20211005 and rocky-anaconda_custom_size-20211007 needed at all?

It's unclear to me why there are three needles matching for `anaconda_custom_size`. They have slightly different locations and the two have a click but one does not. In my `disk_custom_gui_standard_partition_ext4@x86_64` test the needle matched here is `rocky-anaconda_custom_size-20211010`. Are `rocky-anaconda_custom_size-20211005` and `rocky-anaconda_custom_size-20211007` needed at all?
akatch commented 2021-10-25 23:20:52 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.
"type": "match"
tcooper commented 2021-10-25 05:09:36 +00:00 (Migrated from github.com)
Review
Copy Link

It's unclear to me why there are three needles matching for anaconda_custom_size. They have slightly different locations and the two have a click but one does not. In my disk_custom_gui_standard_partition_ext4@x86_64 test the needle matched here is rocky-anaconda_custom_size-20211010. Are rocky-anaconda_custom_size-20211005 and rocky-anaconda_custom_size-20211007 needed at all?

It's unclear to me why there are three needles matching for `anaconda_custom_size`. They have slightly different locations and the two have a click but one does not. In my `disk_custom_gui_standard_partition_ext4@x86_64` test the needle matched here is `rocky-anaconda_custom_size-20211010`. Are `rocky-anaconda_custom_size-20211005` and `rocky-anaconda_custom_size-20211007` needed at all?
akatch commented 2021-10-25 23:20:52 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.
}
tcooper commented 2021-10-25 05:09:36 +00:00 (Migrated from github.com)
Review
Copy Link

It's unclear to me why there are three needles matching for anaconda_custom_size. They have slightly different locations and the two have a click but one does not. In my disk_custom_gui_standard_partition_ext4@x86_64 test the needle matched here is rocky-anaconda_custom_size-20211010. Are rocky-anaconda_custom_size-20211005 and rocky-anaconda_custom_size-20211007 needed at all?

It's unclear to me why there are three needles matching for `anaconda_custom_size`. They have slightly different locations and the two have a click but one does not. In my `disk_custom_gui_standard_partition_ext4@x86_64` test the needle matched here is `rocky-anaconda_custom_size-20211010`. Are `rocky-anaconda_custom_size-20211005` and `rocky-anaconda_custom_size-20211007` needed at all?
akatch commented 2021-10-25 23:20:52 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.
],
tcooper commented 2021-10-25 05:09:36 +00:00 (Migrated from github.com)
Review
Copy Link

It's unclear to me why there are three needles matching for anaconda_custom_size. They have slightly different locations and the two have a click but one does not. In my disk_custom_gui_standard_partition_ext4@x86_64 test the needle matched here is rocky-anaconda_custom_size-20211010. Are rocky-anaconda_custom_size-20211005 and rocky-anaconda_custom_size-20211007 needed at all?

It's unclear to me why there are three needles matching for `anaconda_custom_size`. They have slightly different locations and the two have a click but one does not. In my `disk_custom_gui_standard_partition_ext4@x86_64` test the needle matched here is `rocky-anaconda_custom_size-20211010`. Are `rocky-anaconda_custom_size-20211005` and `rocky-anaconda_custom_size-20211007` needed at all?
akatch commented 2021-10-25 23:20:52 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.
"properties": [],
tcooper commented 2021-10-25 05:09:36 +00:00 (Migrated from github.com)
Review
Copy Link

It's unclear to me why there are three needles matching for anaconda_custom_size. They have slightly different locations and the two have a click but one does not. In my disk_custom_gui_standard_partition_ext4@x86_64 test the needle matched here is rocky-anaconda_custom_size-20211010. Are rocky-anaconda_custom_size-20211005 and rocky-anaconda_custom_size-20211007 needed at all?

It's unclear to me why there are three needles matching for `anaconda_custom_size`. They have slightly different locations and the two have a click but one does not. In my `disk_custom_gui_standard_partition_ext4@x86_64` test the needle matched here is `rocky-anaconda_custom_size-20211010`. Are `rocky-anaconda_custom_size-20211005` and `rocky-anaconda_custom_size-20211007` needed at all?
akatch commented 2021-10-25 23:20:52 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.
"tags": [
tcooper commented 2021-10-25 05:09:36 +00:00 (Migrated from github.com)
Review
Copy Link

It's unclear to me why there are three needles matching for anaconda_custom_size. They have slightly different locations and the two have a click but one does not. In my disk_custom_gui_standard_partition_ext4@x86_64 test the needle matched here is rocky-anaconda_custom_size-20211010. Are rocky-anaconda_custom_size-20211005 and rocky-anaconda_custom_size-20211007 needed at all?

It's unclear to me why there are three needles matching for `anaconda_custom_size`. They have slightly different locations and the two have a click but one does not. In my `disk_custom_gui_standard_partition_ext4@x86_64` test the needle matched here is `rocky-anaconda_custom_size-20211010`. Are `rocky-anaconda_custom_size-20211005` and `rocky-anaconda_custom_size-20211007` needed at all?
akatch commented 2021-10-25 23:20:52 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.
"ENV-DISTRI-rocky",
tcooper commented 2021-10-25 05:09:36 +00:00 (Migrated from github.com)
Review
Copy Link

It's unclear to me why there are three needles matching for anaconda_custom_size. They have slightly different locations and the two have a click but one does not. In my disk_custom_gui_standard_partition_ext4@x86_64 test the needle matched here is rocky-anaconda_custom_size-20211010. Are rocky-anaconda_custom_size-20211005 and rocky-anaconda_custom_size-20211007 needed at all?

It's unclear to me why there are three needles matching for `anaconda_custom_size`. They have slightly different locations and the two have a click but one does not. In my `disk_custom_gui_standard_partition_ext4@x86_64` test the needle matched here is `rocky-anaconda_custom_size-20211010`. Are `rocky-anaconda_custom_size-20211005` and `rocky-anaconda_custom_size-20211007` needed at all?
akatch commented 2021-10-25 23:20:52 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.
"LANGUAGE-english",
tcooper commented 2021-10-25 05:09:36 +00:00 (Migrated from github.com)
Review
Copy Link

It's unclear to me why there are three needles matching for anaconda_custom_size. They have slightly different locations and the two have a click but one does not. In my disk_custom_gui_standard_partition_ext4@x86_64 test the needle matched here is rocky-anaconda_custom_size-20211010. Are rocky-anaconda_custom_size-20211005 and rocky-anaconda_custom_size-20211007 needed at all?

It's unclear to me why there are three needles matching for `anaconda_custom_size`. They have slightly different locations and the two have a click but one does not. In my `disk_custom_gui_standard_partition_ext4@x86_64` test the needle matched here is `rocky-anaconda_custom_size-20211010`. Are `rocky-anaconda_custom_size-20211005` and `rocky-anaconda_custom_size-20211007` needed at all?
akatch commented 2021-10-25 23:20:52 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.
"anaconda_custom_size"
tcooper commented 2021-10-25 05:09:36 +00:00 (Migrated from github.com)
Review
Copy Link

It's unclear to me why there are three needles matching for anaconda_custom_size. They have slightly different locations and the two have a click but one does not. In my disk_custom_gui_standard_partition_ext4@x86_64 test the needle matched here is rocky-anaconda_custom_size-20211010. Are rocky-anaconda_custom_size-20211005 and rocky-anaconda_custom_size-20211007 needed at all?

It's unclear to me why there are three needles matching for `anaconda_custom_size`. They have slightly different locations and the two have a click but one does not. In my `disk_custom_gui_standard_partition_ext4@x86_64` test the needle matched here is `rocky-anaconda_custom_size-20211010`. Are `rocky-anaconda_custom_size-20211005` and `rocky-anaconda_custom_size-20211007` needed at all?
akatch commented 2021-10-25 23:20:52 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.
]
tcooper commented 2021-10-25 05:09:36 +00:00 (Migrated from github.com)
Review
Copy Link

It's unclear to me why there are three needles matching for anaconda_custom_size. They have slightly different locations and the two have a click but one does not. In my disk_custom_gui_standard_partition_ext4@x86_64 test the needle matched here is rocky-anaconda_custom_size-20211010. Are rocky-anaconda_custom_size-20211005 and rocky-anaconda_custom_size-20211007 needed at all?

It's unclear to me why there are three needles matching for `anaconda_custom_size`. They have slightly different locations and the two have a click but one does not. In my `disk_custom_gui_standard_partition_ext4@x86_64` test the needle matched here is `rocky-anaconda_custom_size-20211010`. Are `rocky-anaconda_custom_size-20211005` and `rocky-anaconda_custom_size-20211007` needed at all?
akatch commented 2021-10-25 23:20:52 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.
}
tcooper commented 2021-10-25 05:09:36 +00:00 (Migrated from github.com)
Review
Copy Link

It's unclear to me why there are three needles matching for anaconda_custom_size. They have slightly different locations and the two have a click but one does not. In my disk_custom_gui_standard_partition_ext4@x86_64 test the needle matched here is rocky-anaconda_custom_size-20211010. Are rocky-anaconda_custom_size-20211005 and rocky-anaconda_custom_size-20211007 needed at all?

It's unclear to me why there are three needles matching for `anaconda_custom_size`. They have slightly different locations and the two have a click but one does not. In my `disk_custom_gui_standard_partition_ext4@x86_64` test the needle matched here is `rocky-anaconda_custom_size-20211010`. Are `rocky-anaconda_custom_size-20211005` and `rocky-anaconda_custom_size-20211007` needed at all?
akatch commented 2021-10-25 23:20:52 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.

I don't think those needles are needed at all. I have removed them in my most recent commit and am rerunning all the tests to make sure nothing broke.

BIN
needles/anaconda/partitioning/custom-gui/rocky-anaconda_custom_size_unit-20211005.png
View File

Binary file not shown.

21
needles/anaconda/partitioning/custom-gui/rocky-anaconda_custom_size_unit-20211007.json
View File

@ -1,21 +0,0 @@
{
"area": [
{
"ypos": 404,
"height": 24,
"xpos": 352,
"width": 134,
"type": "match",
"click_point": {
"xpos": 134,
"ypos": 10
}
}
],
"properties": [],
"tags": [
"ENV-DISTRI-rocky",
"LANGUAGE-english",
"anaconda_custom_size"
]
}

BIN
needles/anaconda/partitioning/custom-gui/rocky-anaconda_custom_size_unit-20211007.png
View File

Binary file not shown.