163a8fd94a
Summary: The 'reclaim_space_first_partition' needles aren't very good. Using the area with the filesystem means we need to duplicate the needle for NTFS, and the needles in fact also match the *second* partition in most cases, sometimes causing the tests to delete the second partition instead of the first and fail. This design should work better: a single needle should match all filesystems, and by including some of the highlighted top row in the match, we should never match on the second row. Including 'da' in the needle makes this really 'first disk, first partition', but that's all the cases we currently use it for. We don't really need this needle to work hard to make sure we're on the right screen, as the subsequent needles (which match buttons that only exist on this screen) do that job fine. We drop some needles that should no longer be necessary: F23 should now be using the cantarell17 version of the needle, and F24 the freetype262 needle. We don't run installer tests for any other release. We could tweak second_partition needle to match, but nothing is actually using it anyway. Test Plan: Do a full test and run and make sure the tests which use this needle work, and always select the correct partition. Reviewers: jskladan, garretraziel Reviewed By: garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D681
17 lines
342 B
JSON
17 lines
342 B
JSON
{
|
|
"area": [
|
|
{
|
|
"height": 39,
|
|
"type": "match",
|
|
"width": 25,
|
|
"xpos": 150,
|
|
"ypos": 249
|
|
}
|
|
],
|
|
"properties": [],
|
|
"tags": [
|
|
"anaconda_install_destination_reclaim_space_first_partition",
|
|
"ENV-DISTRI-fedora",
|
|
"ENV-FLAVOR-server"
|
|
]
|
|
} |