os-autoinst-distri-rocky-mi.../lib
Adam Williamson dcb68d93c8 drop our implementation of script_run in favour of os-autoinst
Summary:
os-autoinst implements `script_run` itself now, we aren't
required to implement it ourselves any more. os-autoinst's
implementation is better than ours, as it allows for verifying
the script actually ran (via the redirect-output-to-serial-
console trick).

So this drops our implementation so we'll just use the upstream
one. Where I judged we don't want to bother with the 'check
the command actually ran' feature I've adjusted our direct
`script_run` calls to pass a wait time of 0, which skips the
'wait for command to run' stuff entirely and just does a simple
'type the string and hit enter'.

Because of how the inheritance works, our `assert_script_run`
calls already used the os-autoinst `script_run`, rather than
the one from our distribution.

This should prevent `prepare_test_packages` sometimes going
wrong right after removing the python3-kickstart package, as
we'll properly wait for that removal to complete now (before
we weren't, we'd just start typing the next command while it
was still running, which could result in lost keypresses).

Test Plan:
Check all tests still run OK (I've tried this on
staging and it seems fine).

Reviewers: jskladan, garretraziel

Reviewed By: garretraziel

Subscribers: tflink

Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1034
2016-10-20 09:24:48 -07:00
..
anacondatest.pm drop our implementation of script_run in favour of os-autoinst 2016-10-20 09:24:48 -07:00
fedorabase.pm redo console_login with multiple matches, move to main_common 2016-09-30 08:42:45 -07:00
fedoradistribution.pm drop our implementation of script_run in favour of os-autoinst 2016-10-20 09:24:48 -07:00
freeipa.pm try to be safer when typing in X: slower, more checks 2016-09-12 10:24:30 -07:00
installedtest.pm drop our implementation of script_run in favour of os-autoinst 2016-10-20 09:24:48 -07:00
main_common.pm drop check_type_string, use upstream merged code instead 2016-10-20 09:12:55 -07:00
packagetest.pm drop our implementation of script_run in favour of os-autoinst 2016-10-20 09:24:48 -07:00