68acecb6d4
Summary: This is a first cut which more or less works for now. Issues: 1) We're not really testing the BUILD, here. All the test does is try and upgrade to the specified VERSION - so it'll be using the latest 'stable' for the given VERSION at the time the test runs. This isn't really that terrible, but especially for TC/RC validation, we might want to make things a bit more elaborate and set up the repo for the actual BUILD (and disable the main repos). 2) We'd actually need --nogpgcheck for non-Rawhide, at one specific point in the release cycle - after Branching but before Bodhi activation (which is when we can be sure all packages are signed). This won't matter until 24 branches, and maybe releng will have it fixed by then...if not, I'll tweak it. 3) We don't really test that the upgrade actually *happened* for desktop, at the moment - the only thing in the old test that really checked that was where we checked for the fedup boot menu entry, but that has no analog in dnf. What we should probably do is check that GUI login works, then switch to a console and check /etc/fedora-release just as the minimal test does. Test Plan: Run the tests. Note that creating the desktop disk image doesn't work ATM, so I can't verify the desktop test works, but the minimal one seems to (with D565). There'll be a matching diff for openqa_fedora_tools to update the test case names there. Reviewers: jskladan, garretraziel Reviewed By: jskladan, garretraziel Subscribers: tflink Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D567
46 lines
1.4 KiB
Perl
46 lines
1.4 KiB
Perl
use base "installedtest";
|
|
use strict;
|
|
use testapi;
|
|
|
|
sub run {
|
|
my $release = lc(get_var('VERSION'));
|
|
my $milestone = lc((split /_/, get_var("BUILD"))[1]);
|
|
my $args = "--releasever=${release}";
|
|
# This is excessive - after the Bodhi activation point we don't
|
|
# need --nogpgcheck for Branched. But that's hard to detect magically
|
|
if ($release eq 'rawhide' or $milestone eq 'branched') {
|
|
$args .= " --nogpgcheck";
|
|
}
|
|
type_string "dnf -y system-upgrade download ${args}";
|
|
send_key "ret";
|
|
|
|
# wait until dnf finishes its work (screen stops moving for 30 seconds)
|
|
wait_still_screen 30, 6000; # TODO: shorter timeout, longer stillscreen?
|
|
|
|
upload_logs "/var/log/dnf.log";
|
|
upload_logs "/var/log/dnf.rpm.log";
|
|
|
|
type_string "dnf system-upgrade reboot";
|
|
send_key "ret";
|
|
|
|
# now offline upgrading starts. user doesn't have to do anything, just wait untill
|
|
# system reboots and login screen is shown
|
|
if (get_var('UPGRADE') eq "desktop") {
|
|
assert_screen "graphical_login", 6000;
|
|
} else {
|
|
assert_screen "text_console_login", 6000;
|
|
}
|
|
}
|
|
|
|
|
|
sub test_flags {
|
|
# without anything - rollback to 'lastgood' snapshot if failed
|
|
# 'fatal' - whole test suite is in danger if this fails
|
|
# 'milestone' - after this test succeeds, update 'lastgood'
|
|
# 'important' - if this fails, set the overall state to 'fail'
|
|
return { fatal => 1 };
|
|
}
|
|
|
|
1;
|
|
|
|
# vim: set sw=4 et:
|