Update Activities button handling for latest GNOME

Make the 'deactivate overview if it's active' thing a bit more
robust by asserting the inactive state after deactivating it,
and add new needles for the new RC (text got a bit brighter).

Signed-off-by: Adam Williamson <awilliam@redhat.com>

lib/utils.pm

@@ -865,7 +865,10 @@ sub check_desktop {
     assert_screen "apps_menu_button", $args{timeout};
     # GNOME 40 starts on the overview by default; for consistency with
     # older GNOME and KDE, let's just close it
-    send_key "alt-f1" if match_has_tag "apps_menu_button_active";
+    if (match_has_tag "apps_menu_button_active") {
+        send_key "alt-f1";
+        assert_screen "apps_menu_button_inactive";
+    }
 }
 
 sub download_modularity_tests {

needles/gnome/apps_menu_button-20190625.json

@@ -13,6 +13,7 @@
         "DESKTOP-gnome",
         "ENV-DISTRI-fedora",
         "LANGUAGE-english",
-        "apps_menu_button"
+        "apps_menu_button",
+        "apps_menu_button_inactive"
     ]
-}
+}

needles/gnome/apps_menu_button-20210316.json

@@ -0,0 +1,19 @@
+{
+  "area": [
+    {
+      "xpos": 15,
+      "height": 15,
+      "ypos": 9,
+      "type": "match",
+      "width": 67
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "DESKTOP-gnome",
+    "ENV-DISTRI-fedora",
+    "LANGUAGE-english",
+    "apps_menu_button",
+    "apps_menu_button_inactive"
+  ]
+}

needles/gnome/apps_menu_button_active-20210316.json

@@ -0,0 +1,19 @@
+{
+  "area": [
+    {
+      "height": 15,
+      "xpos": 15,
+      "ypos": 9,
+      "type": "match",
+      "width": 67
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "DESKTOP-gnome",
+    "ENV-DISTRI-fedora",
+    "LANGUAGE-english",
+    "apps_menu_button",
+    "apps_menu_button_active"
+  ]
+}