Stop having two 'firefox close tabs' needle tags, drop old ones

We still have a 'apps_run_firefox_stop' needle tag which is for
the same thing as 'firefox_close_tabs'. That's dumb. Get rid of
it and only have the firefox_close_tabs tag and needles. Also
clean up some old firefox_close_tabs needles that haven't matched
for months and all the 'apps_run_firefox_stop' needles.

Signed-off-by: Adam Williamson <awilliam@redhat.com>

needles/firefox/firefox_close_tabs-20181031.json

@@ -1,15 +0,0 @@
-{
-    "area": [
-        {
-            "height": 13,
-            "type": "match",
-            "width": 68,
-            "xpos": 668,
-            "ypos": 419
-        }
-    ],
-    "properties": [],
-    "tags": [
-        "firefox_close_tabs"
-    ]
-}

needles/firefox/firefox_close_tabs-adwaita-20190211.json

@@ -1,15 +0,0 @@
-{
-  "area": [
-    {
-      "height": 13,
-      "xpos": 668,
-      "width": 68,
-      "type": "match",
-      "ypos": 419
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "firefox_close_tabs"
-  ]
-}

needles/gnome/apps/apps_run_firefox_stop-20190220.json

@@ -1,15 +0,0 @@
-{
-  "area": [
-    {
-      "type": "match",
-      "ypos": 451,
-      "width": 75,
-      "height": 18,
-      "xpos": 662
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "apps_run_firefox_stop"
-  ]
-}

needles/gnome/apps/apps_run_firefox_stop-20190328.json

@@ -1,15 +0,0 @@
-{
-  "area": [
-    {
-      "xpos": 658,
-      "height": 15,
-      "width": 75,
-      "type": "match",
-      "ypos": 451
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "apps_run_firefox_stop"
-  ]
-}

needles/gnome/apps/apps_run_firefox_stop.json

@@ -1,15 +0,0 @@
-{
-  "properties": [],
-  "tags": [
-    "apps_run_firefox_stop"
-  ],
-  "area": [
-    {
-      "xpos": 662,
-      "ypos": 451,
-      "width": 75,
-      "height": 18,
-      "type": "match"
-    }
-  ]
-}

needles/kde/apps/firefox_close_tabs-20190509.json

@@ -1,15 +0,0 @@
-{
-  "area": [
-    {
-      "ypos": 416,
-      "xpos": 672,
-      "type": "match",
-      "height": 14,
-      "width": 70
-    }
-  ],
-  "properties": [],
-  "tags": [
-    "firefox_close_tabs"
-  ]
-}

needles/kde/apps/firefox_close_tabs.json

@@ -1,15 +0,0 @@
-{
-  "properties": [],
-  "tags": [
-    "firefox_close_tabs"
-  ],
-  "area": [
-    {
-      "xpos": 672,
-      "ypos": 416,
-      "width": 70,
-      "height": 14,
-      "type": "match"
-    }
-  ]
-}

tests/apps_startstop/gnome/firefox.pm

@@ -19,8 +19,8 @@ sub run {
     assert_and_click 'apps_stop';
     wait_still_screen 2;
     # deal with warning screen
-    if (check_screen("apps_run_firefox_stop", 1)) {
+    if (check_screen("firefox_close_tabs", 1)) {
-        assert_and_click 'apps_run_firefox_stop';
+        click_lastmatch;
     }
     wait_still_screen 2;
     # Register application