From 5d7b46cb9d165e3cd7ada63cbb9b968bad9ea885 Mon Sep 17 00:00:00 2001 From: Adam Williamson Date: Mon, 29 Aug 2016 11:00:53 -0700 Subject: [PATCH] widen reclaim_space_delete_btn area to make it unambiguous this needle can actually also match the 'Delete all' button, resulting in the test not doing what it should. openQA should prefer the match closer to the area's location in the needle, but https://openqa.fedoraproject.org/tests/31136 seems to show this not happening, so let's make the match area wider in all versions of the needle so it should no longer match the Delete all button. --- .../reclaim_space_delete_btn-20160823.json | 2 +- .../reclaim_space_delete_btn-cantarell20.json | 34 +++++++++---------- .../reclaim_space_delete_btn-freetype262.json | 34 +++++++++---------- .../reclaim_space_delete_btn.json | 32 ++++++++--------- 4 files changed, 51 insertions(+), 51 deletions(-) diff --git a/needles/anaconda/install_destination/reclaim_space_delete_btn-20160823.json b/needles/anaconda/install_destination/reclaim_space_delete_btn-20160823.json index 5b9836c3..1c493cd1 100644 --- a/needles/anaconda/install_destination/reclaim_space_delete_btn-20160823.json +++ b/needles/anaconda/install_destination/reclaim_space_delete_btn-20160823.json @@ -3,7 +3,7 @@ { "height": 16, "type": "match", - "width": 41, + "width": 48, "xpos": 108, "ypos": 519 } diff --git a/needles/anaconda/install_destination/reclaim_space_delete_btn-cantarell20.json b/needles/anaconda/install_destination/reclaim_space_delete_btn-cantarell20.json index 8d9530cf..552b57af 100644 --- a/needles/anaconda/install_destination/reclaim_space_delete_btn-cantarell20.json +++ b/needles/anaconda/install_destination/reclaim_space_delete_btn-cantarell20.json @@ -1,18 +1,18 @@ -{ - "tags": [ - "anaconda_install_destination_reclaim_space_delete_btn", - "ENV-DISTRI-fedora", - "LANGUAGE-english", - "ENV-FLAVOR-server" - ], - "area": [ - { - "type": "match", - "xpos": 108, - "height": 21, - "width": 46, - "ypos": 519 - } - ], - "properties": [] +{ + "area": [ + { + "height": 21, + "type": "match", + "width": 53, + "xpos": 108, + "ypos": 519 + } + ], + "properties": [], + "tags": [ + "anaconda_install_destination_reclaim_space_delete_btn", + "ENV-DISTRI-fedora", + "LANGUAGE-english", + "ENV-FLAVOR-server" + ] } \ No newline at end of file diff --git a/needles/anaconda/install_destination/reclaim_space_delete_btn-freetype262.json b/needles/anaconda/install_destination/reclaim_space_delete_btn-freetype262.json index 25d72656..76722544 100644 --- a/needles/anaconda/install_destination/reclaim_space_delete_btn-freetype262.json +++ b/needles/anaconda/install_destination/reclaim_space_delete_btn-freetype262.json @@ -1,18 +1,18 @@ -{ - "tags": [ - "anaconda_install_destination_reclaim_space_delete_btn", - "ENV-DISTRI-fedora", - "LANGUAGE-english", - "ENV-FLAVOR-server" - ], - "properties": [], - "area": [ - { - "xpos": 108, - "height": 21, - "width": 46, - "ypos": 416, - "type": "match" - } - ] +{ + "area": [ + { + "height": 21, + "type": "match", + "width": 53, + "xpos": 108, + "ypos": 416 + } + ], + "properties": [], + "tags": [ + "anaconda_install_destination_reclaim_space_delete_btn", + "ENV-DISTRI-fedora", + "LANGUAGE-english", + "ENV-FLAVOR-server" + ] } \ No newline at end of file diff --git a/needles/anaconda/install_destination/reclaim_space_delete_btn.json b/needles/anaconda/install_destination/reclaim_space_delete_btn.json index e13ba4f1..2a08b267 100644 --- a/needles/anaconda/install_destination/reclaim_space_delete_btn.json +++ b/needles/anaconda/install_destination/reclaim_space_delete_btn.json @@ -1,17 +1,17 @@ -{ - "tags": [ - "anaconda_install_destination_reclaim_space_delete_btn", - "ENV-DISTRI-fedora", - "LANGUAGE-english", - "ENV-FLAVOR-server" - ], - "area": [ - { - "xpos": 108, - "ypos": 517, - "width": 46, - "height": 21, - "type": "match" - } - ] +{ + "area": [ + { + "height": 21, + "type": "match", + "width": 53, + "xpos": 108, + "ypos": 517 + } + ], + "tags": [ + "anaconda_install_destination_reclaim_space_delete_btn", + "ENV-DISTRI-fedora", + "LANGUAGE-english", + "ENV-FLAVOR-server" + ] } \ No newline at end of file