From 6a79565afa1c007815e783a8caaf122930e84e82 Mon Sep 17 00:00:00 2001
From: Adam Williamson <awilliam@redhat.com>
Date: Mon, 21 Jun 2021 15:16:40 -0700
Subject: [PATCH] Fix up KDE 'plasma-disks' test stuff

In #235 we accidentally included an entire disks.pm test that
wasn't meant to be there - the infocenter module test is the
right thing to exercise plasma-disks, there is no standalone
app, running 'disks' just gets you the KDE Partition Manager,
which we already test. So this removes that test and renames a
needle that looks like it's for that test but is actually for
the kinfocenter module, to make this clearer.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
---
 ...son => infocenter_smart_status_shown.json} |   4 +--
 ....png => infocenter_smart_status_shown.png} | Bin
 tests/apps_startstop/kde/disks.pm             |  26 ------------------
 tests/apps_startstop/kde/infocenter.pm        |   2 +-
 4 files changed, 3 insertions(+), 29 deletions(-)
 rename needles/kde/apps/{disks_runs.json => infocenter_smart_status_shown.json} (81%)
 rename needles/kde/apps/{disks_runs.png => infocenter_smart_status_shown.png} (100%)
 delete mode 100644 tests/apps_startstop/kde/disks.pm

diff --git a/needles/kde/apps/disks_runs.json b/needles/kde/apps/infocenter_smart_status_shown.json
similarity index 81%
rename from needles/kde/apps/disks_runs.json
rename to needles/kde/apps/infocenter_smart_status_shown.json
index f22205c8..c081e295 100644
--- a/needles/kde/apps/disks_runs.json
+++ b/needles/kde/apps/infocenter_smart_status_shown.json
@@ -1,7 +1,7 @@
 {
   "properties": [],
   "tags": [
-    "disks_runs"
+    "infocenter_smart_status_shown"
   ],
   "area": [
     {
@@ -12,4 +12,4 @@
       "type": "match"
     }
   ]
-}
\ No newline at end of file
+}
diff --git a/needles/kde/apps/disks_runs.png b/needles/kde/apps/infocenter_smart_status_shown.png
similarity index 100%
rename from needles/kde/apps/disks_runs.png
rename to needles/kde/apps/infocenter_smart_status_shown.png
diff --git a/tests/apps_startstop/kde/disks.pm b/tests/apps_startstop/kde/disks.pm
deleted file mode 100644
index 21cf19e3..00000000
--- a/tests/apps_startstop/kde/disks.pm
+++ /dev/null
@@ -1,26 +0,0 @@
-use base "installedtest";
-use strict;
-use testapi;
-use utils;
-
-# This test checks that Disks starts.
-
-sub run {
-    my $self = shift;
-    
-    # Start the application
-    menu_launch_type 'disks';
-    # Check that it is started
-    assert_screen 'disks_runs';
-    # Close the application
-    quit_with_shortcut();
-}
-
-sub test_flags {
-    return {always_rollback => 1};
-}
-
-
-1;
-
-# vim: set sw=4 et:
diff --git a/tests/apps_startstop/kde/infocenter.pm b/tests/apps_startstop/kde/infocenter.pm
index 5b14cc23..a1eebbfb 100644
--- a/tests/apps_startstop/kde/infocenter.pm
+++ b/tests/apps_startstop/kde/infocenter.pm
@@ -19,7 +19,7 @@ sub run {
     # If the disks module is present, open it
     assert_and_click "infocenter_smart_status";
     # Check that a correct screen is displayed.
-    assert_screen "disks_runs";
+    assert_screen "infocenter_smart_status_shown";
     # Close the application
     quit_with_shortcut();
 }