iSCSI: test user authentication

Summary:
This isn't in the criteria, but it's commonly used, so we ought
to test this way. Require authentication for the iSCSI target
and have the test provide the appropriate auth info.

Test Plan:
Run the iscsi test and check it works (you need the
recent fixes for support_server to make *that* work). Nothing
else should be affected.

Reviewers: jskladan, garretraziel

Reviewed By: garretraziel

Subscribers: tflink

Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D1070

lib/anacondatest.pm

@@ -110,7 +110,9 @@ sub select_disks {
     if (%iscsi) {
         assert_and_click "anaconda_install_destination_add_network_disk";
         foreach my $target (keys %iscsi) {
-            my $ip = $iscsi{$target};
+            my $ip = $iscsi{$target}->[0];
+            my $user = $iscsi{$target}->[1];
+            my $password = $iscsi{$target}->[2];
             assert_and_click "anaconda_install_destination_add_iscsi_target";
             wait_still_screen 2;
             type_safely $ip;
@@ -118,6 +120,14 @@ sub select_disks {
             type_safely $target;
             # start discovery - three tabs, enter
             type_safely "\t\t\t\n";
+            if ($user && $password) {
+                assert_and_click "anaconda_install_destination_target_auth_type";
+                assert_and_click "anaconda_install_destination_target_auth_type_chap";
+                send_key "tab";
+                type_safely $user;
+                send_key "tab";
+                type_safely $password;
+            }
             assert_and_click "anaconda_install_destination_target_login";
             assert_and_click "anaconda_install_destination_select_target";
         }

needles/anaconda/install_destination/target_auth_type-20161214.json

@@ -0,0 +1,15 @@
+{
+  "tags": [
+    "anaconda_install_destination_target_auth_type"
+  ],
+  "properties": [],
+  "area": [
+    {
+      "xpos": 426,
+      "ypos": 313,
+      "width": 88,
+      "height": 17,
+      "type": "match"
+    }
+  ]
+}

needles/anaconda/install_destination/target_auth_type_chap-20161214.json

@@ -0,0 +1,15 @@
+{
+  "area": [
+    {
+      "xpos": 425,
+      "ypos": 343,
+      "width": 83,
+      "height": 20,
+      "type": "match"
+    }
+  ],
+  "properties": [],
+  "tags": [
+    "anaconda_install_destination_target_auth_type_chap"
+  ]
+}

tests/_support_server.pm

@@ -27,7 +27,7 @@ sub run {
     ## ISCSI
 
     # start up iscsi target
-    assert_script_run "printf '<target iqn.2016-06.local.domain:support.target1>\n    backing-store /dev/vdb\n</target>' > /etc/tgt/conf.d/openqa.conf";
+    assert_script_run "printf '<target iqn.2016-06.local.domain:support.target1>\n    backing-store /dev/vdb\n    incominguser test weakpassword\n</target>' > /etc/tgt/conf.d/openqa.conf";
     # open firewall port
     assert_script_run "firewall-cmd --add-service=iscsi-target";
     assert_script_run "systemctl restart tgtd.service";

tests/disk_custom_iscsi.pm

@@ -6,7 +6,7 @@ sub run {
     my $self = shift;
     # iscsi config hash
     my %iscsi;
-    $iscsi{'iqn.2016-06.local.domain:support.target1'} = '10.0.2.110';
+    $iscsi{'iqn.2016-06.local.domain:support.target1'} = ['10.0.2.110', 'test', 'weakpassword'];
     # Anaconda hub
     # Go to INSTALLATION DESTINATION and ensure one regular disk
     # and the iscsi target are selected.